From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794047760; b=OLiq+YT0Anqx3yT2GxzJTtYCtWvq9IveUOoYbThLx6WoFSc64FuXuusDgFQDUznCwLTl pF7RAsEYc1C8HZBD/jOWm32mmZ3a+IgPi/VpLp2fuuKBG1/qk7MXe5gw7Uj/ri0Ebd5VX RoB4JNFZRba9UoZ5r+LVWaZZMQS0QIJluKBmzU7St7kSa6jYlDdgn74tT93rdah3PXmDn 7hhCF0N7mAdW7Csszwo9AyMDPfZUceNAX4ATFfHAT9S5KayH9KmaE4jWi7jN0E3OF/vTk TVjc2w9R2KrSKqbHJ4Ik5FoRa/C0eVv4n3XcU1oQ0b0yVsNRs6s/8CO0TFbEb0qzrhA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794047760; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=+g/+8uUWNH1K/jIkswVqueM4pQKWRHj8m0tLDyhqYrQ=; b=IurrdRqckfEIxMksNy1aURqwDRO5sE2iyT4rYM1XSHcR54r6RaXmHxdPLlwT3RqMJ7Jc 6OzwneBOAI14wwp9fvcIm8l2d4dQUmhuzcDmQ7ROMcICnvwUAX0274s3dzUwlJaklu9LO X4DW/yuwDQPda/xsLjJNtZ+I5Ygg5U5jiKLHFZXPZ8Sok8Xk+JKbhnrm+F488FAM55weg kEFlXBIw3/dMTqznfyBgWWLvWdwejZKx6AT1RIFF7dNikXAvHf5LsGCoxQR5HgAiHazZU oKO0celHRDa8j0L243GRdIeliQ4C0hAKZsUWHFrvOdf0ddkkFg7I7hSD2LdpPZnT2LQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=CMog5Pfd; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23B1F606A32C for ; Sat, 7 Nov 2026 10:36:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=CMog5Pfd Received: by smtp.kernel.org (Postfix) with ESMTPSA id 749661F0089F; Sat, 7 Nov 2026 10:35:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794047760; bh=+g/+8uUWNH1K/jIkswVqueM4pQKWRHj8m0tLDyhqYrQ=; h=From:To:Cc:Subject:Date; b=CMog5PfdcnbZFGr7R/zxPfQx/5ctHlfVrGlQb4SdVBAfvsR9+LpCm9Tk23C/ln7tr /ySpCiIGY0gA9AOKqSe9A3021P9AMOgLo0hDWblEzpjrb9AQVwWXaXHIjKq9fWXAL/ cf5KYo/BCYL2NIgHq7WVK1l9HMj6dN1KT7qt3+ZAJvZCMnkbboAQuPCuc1TMo04TOf MKFOH4c8u9qmws5ksdGoMI1DL7VfxUGZET2rqhX+/BDEV1y+UPM/oE7hvUdM6XhaBV 4/IElgMx2nAcfcRduU4EI2oSxoGBi3X8fbmUpV7LolpcFvvz36Wm2c6PHKtgBveGte bIvRNuzJBcVFA== From: Sasha Levin To: rosenp@gmail.com, daniel.machon@microchip.com, kuba@kernel.org Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] net: bgmac: enable interrupts only after NAPI is ready" failed to apply to 6.6-stable tree Date: Sat, 7 Nov 2026 05:35:58 -0500 Message-ID: <20261107053558-failed-6.6-ac1f6e58cb77@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x ac1f6e58cb77bb66b8811f7d98703e0f076a8f65 # git commit -s git send-email --to '' --in-reply-to '20261107053558-failed-6.6-ac1f6e58cb77@kernel.org' --subject-prefix 'PATCH 6.6.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From ac1f6e58cb77bb66b8811f7d98703e0f076a8f65 Mon Sep 17 00:00:00 2001 From: Rosen Penev Date: Sat, 10 Oct 2026 00:00:11 -0700 Subject: [PATCH] net: bgmac: enable interrupts only after NAPI is ready bgmac_open() calls bgmac_chip_init(), which unmasks the interrupts and enables the MAC receiver, before request_irq() and napi_enable(). bgmac_enet_resume() also enables NAPI only after bgmac_chip_init(). When frames arrive in that window, the first RX interrupt masks all interrupts in bgmac_interrupt() and calls napi_schedule() on a NAPI instance that is still disabled, so nothing is scheduled. Nothing unmasks the interrupts again, the RX ring fills up and the interface stays deaf until it is brought down and up without traffic. On an Asus RT-N16 (BCM4716) a single "ip link set eth0 down/up" while a host sends UDP to the router left INT_MASK at 0, INT_STATUS with RX pending and the RX DMA idle on a full ring, with the RX packet and interrupt counters no longer moving. With this change, 10 of 10 such cycles recovered on their own. Request the IRQ and enable NAPI before the chip is initialized. Fixes: dd4544f05469 ("bgmac: driver for GBit MAC core on BCMA bus") Fixes: f3537b3494c0 ("net: ethernet: bgmac: driver power manangement") Cc: stable@vger.kernel.org Signed-off-by: Rosen Penev Reviewed-by: Daniel Machon Link: https://patch.msgid.link/20261010070011.60403-1-rosenp@gmail.com Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/broadcom/bgmac.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c index 3e9c57196a397..1835266fdd09f 100644 --- a/drivers/net/ethernet/broadcom/bgmac.c +++ b/drivers/net/ethernet/broadcom/bgmac.c @@ -1183,9 +1183,6 @@ static int bgmac_open(struct net_device *net_dev) if (err) return err; - /* Specs say about reclaiming rings here, but we do that in DMA init */ - bgmac_chip_init(bgmac); - err = request_irq(bgmac->irq, bgmac_interrupt, IRQF_SHARED, net_dev->name, net_dev); if (err < 0) { @@ -1195,6 +1192,9 @@ static int bgmac_open(struct net_device *net_dev) } napi_enable(&bgmac->napi); + /* Specs say about reclaiming rings here, but we do that in DMA init */ + bgmac_chip_init(bgmac); + phy_start(net_dev->phydev); netif_start_queue(net_dev); @@ -1608,10 +1608,10 @@ int bgmac_enet_resume(struct bgmac *bgmac) if (rc) return rc; - bgmac_chip_init(bgmac); - napi_enable(&bgmac->napi); + bgmac_chip_init(bgmac); + netif_tx_lock(bgmac->net_dev); netif_device_attach(bgmac->net_dev); netif_tx_unlock(bgmac->net_dev); -- 2.53.0