From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794047885; b=2L9N3vjNV0D0vKHG9Ks0b5mTVu4/crmRSNlw3g4nva5EGe+I6Yf/cHhjnrreJuZDgw2i ToL36ULXNd8syMuQPej0IxSmuwf9bLXvEzTZ6cM65lGbTK1jBti2RVPjJS/AUX4/sUNyO Fm0ZSmdjtDVYPAyS4V64qjCAQtXb0Tq4F5yT/0/1IC+I8uUQFy6wSVBYX/fAQQddP1076 M4ahO7kVJHQOlujaQU9IRCY1DLGFdCsjd1Py7IbAM4qMmLZCAzPyD0xupdjaRWzcStgP2 hPhvNYStOdfbmDgwKC/O0x7xAw0Q55T1dNs2mTLmLhJqQCs5jjcvv/8bah+4Gv9E5/w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794047885; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=18GngfcsCF8njYniND5CUP8LWPmPec4SFxohZB85pqE=; b=e0uum4sArtq3M5PQeOq/6ANckxbraMpamHJZjW7fA1++Y7/Wvqwl7hzqApi8nzwHn1DX 0wQ12ywhUyCX78vhaz0yquqWi1rraVisrkvooXuLOPQTVe3BT2J3+Jwck6J2Up303bTJB Dep6X4QazrO+uhN9R2yxG+d/SVgCuLRuFuhxoAvq+WZUZ6FbCULmpW6scBigPyQlqaxgN Oj9l5uGv6ZOm98FNC5/y0nu2pJiBa+2Hc8QL/HLUhPqBqFrMBvA50bChABDPTcs0C8Vl+ q1wTf/D6y/PaPRln/V+OWqNnLp3/3HIc4GBTBrRbOtP6wwjqFUWB2xtTAXpMlZZDV9Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="Hnkkc0/T"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F70E606A326 for ; Sat, 7 Nov 2026 10:38:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Hnkkc0/T Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD6ED1F0089F; Sat, 7 Nov 2026 10:38:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794047885; bh=18GngfcsCF8njYniND5CUP8LWPmPec4SFxohZB85pqE=; h=From:To:Cc:Subject:Date; b=Hnkkc0/TirXcMCAMTuUIiev13yQ3JXZ5YUh97MRZ7+V7vNCsoQ811PVOjWoDEfeyL D2u2LQrMlmVd6zEqJx0Ngp85tN7/xL0Q8DFlJs32hODT65Srv1IPCs28Lqzl3kyhiT k+YzfwfVjCt8gZjUnQEAUnhnYTfrANFVsuCIWSIhSBZWL32LY6t4zezf4+EC8E4qhN o4xbaH5+/IApO0gXlO8s6Xu2pB7V+mMC+fJf0kkKIkiYLVCLInOHDvgC/Y60sJQcIf 0h9fuI3WbEzp5hOiBjs8+HI7Nx5ZYbKW3tnyF1RbuEyN1bpI/4830GnrGP3mMTOjyR aQFRIYlApyojQ== From: Sasha Levin To: henrik.enquist@gmail.com, tiwai@suse.de Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] ALSA: aloop: Update the PCM Slave controls for a matching playback" failed to apply to 6.6-stable tree Date: Sat, 7 Nov 2026 05:38:03 -0500 Message-ID: <20261107053803-failed-6.6-c3bde2beacbc@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x c3bde2beacbcb40790f0e3c3f909f9e16bbced9c # git commit -s git send-email --to '' --in-reply-to '20261107053803-failed-6.6-c3bde2beacbc@kernel.org' --subject-prefix 'PATCH 6.6.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From c3bde2beacbcb40790f0e3c3f909f9e16bbced9c Mon Sep 17 00:00:00 2001 From: Henrik Enquist Date: Wed, 21 Oct 2026 09:46:45 +0200 Subject: [PATCH] ALSA: aloop: Update the PCM Slave controls for a matching playback The "PCM Slave" format, rate, channels and access controls report the parameters of the playback side of a cable. loopback_check_format() updates them when a playback starts, but returns early when a capture is open and its parameters match. The controls then keep the module defaults, or the parameters of an earlier stream. A playback that joins an open capture with the same parameters is the normal case without notify, where it is constrained to the capture's parameters, and also with notify whenever the player happens to use them. An application that reads the controls to find the playback's parameters, for example to reopen the capture side at the right rate after a restart, then gets the wrong values. Only skip the capture stop when the parameters match, and update the controls in every case. A value event is still sent only for a control whose value changes. Reproducer: arecord -D hw:Loopback,1,0 -r 44100 -f S16_LE -c 2 /dev/null & aplay -D hw:Loopback,0,0 -t raw -r 44100 -f S16_LE -c 2 /dev/zero & amixer -c Loopback cget "iface=PCM,name='PCM Slave Rate',device=1" Before: the control reports 48000, the module default. After: it reports 44100. Fixes: 597603d615d2 ("ALSA: introduce the snd-aloop module for the PCM loopback") Cc: stable@vger.kernel.org Signed-off-by: Henrik Enquist Link: https://patch.msgid.link/20261021-aloop-slave-controls-v1-1-62297727177f@gmail.com Signed-off-by: Takashi Iwai --- sound/drivers/aloop.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/sound/drivers/aloop.c b/sound/drivers/aloop.c index d6a059ab37474..824d320b665bf 100644 --- a/sound/drivers/aloop.c +++ b/sound/drivers/aloop.c @@ -412,11 +412,14 @@ static int loopback_check_format(struct loopback_cable *cable, int stream) runtime->channels != cruntime->channels || is_access_interleaved(runtime->access) != is_access_interleaved(cruntime->access); - if (!check) - return 0; - if (stream == SNDRV_PCM_STREAM_CAPTURE) + /* + * Matching params also go on to the update below, so that + * the setup controls follow a playback that joins an open + * capture. + */ + if (check && stream == SNDRV_PCM_STREAM_CAPTURE) return -EIO; - else if (cruntime->state == SNDRV_PCM_STATE_RUNNING) { + else if (check && cruntime->state == SNDRV_PCM_STATE_RUNNING) { /* close must not free the peer runtime below */ snd_refcount_get(&cable->stop_count); stop_capture = true; -- 2.53.0