From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794048082; b=gaJ7Lc2B5lmfwoFUkw9NlaLZa0BPI8DE3KrvRoILYMgVfGjziQ7Jl0GdOdPXxibJ5206 UjKT8lr3UCD4jAeNouV6NBuOSBKlxFk87VmAbtPI3ucbbD6V3C30bx/go9vCpsfJ8yIGr LtdEF8HlGVGxD4yaNd2rMfkIopWAKWV8o1tXyg2XRyLxg3xQG2YP5DTPdmKTYC34ZIUR2 Hz50eJi8lZnJG5x1ynN1KttYcLS4b5w8HMF0bEmx5arzVe2cereY9/5Y7T7FSw4wdAt+8 oK9PcvnufRiCM3RpghTd/0v3LaVMTGcMzTlDdWP7byUTEi4xXcOpXh3ooJ8B1zb4X7w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794048082; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=EJqF7mlF01yQ4K6nLMjffiT5TWXxjVLxD+zED8Bz1Pc=; b=kWitGcIv+HOmyj9FEsBJbZUKiWIaD16yS5hDX2tW3HLBW4DEyFXMeMz1CtWzvfNI/lng 5Lhc/mBXW3DCTHTPBcZsAZ05Ua3z7o9mGOQVWWCZEMY36BkBQylwXellgbNazHZpKcdZS TRWWyaXseFm8mQ9ydK5U080ktxEaz0RPcpi6KSsyqhYnZLLZO4l/HijDcu6KvIUupQAL5 gp4/RWUM7QINkqyln9KTUGHA3R6DEERk/bU8Hcsz6EcrIQI+zkT4oD44RQDCtIygNN/MW mwfRj+uZbHZSdEzCwK1Ukp4gDSyPWYAqbSU5Aex70SPF8eVLM9/ykKmMv7/Q/Y/oPXA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="mFBiYE/J"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5244E606A32C for ; Sat, 7 Nov 2026 10:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=mFBiYE/J Received: by smtp.kernel.org (Postfix) with ESMTPSA id C409B1F0089F; Sat, 7 Nov 2026 10:41:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794048082; bh=EJqF7mlF01yQ4K6nLMjffiT5TWXxjVLxD+zED8Bz1Pc=; h=From:To:Cc:Subject:Date; b=mFBiYE/J//gyxrEPvmSzUOjaTWHsn5NP6Tw+lzQTIZ2pUcYInT2zpQyaJD5JoTNPI RoaJoBowRMcK6Sy7obrOEmeIsZUqcFm6E+FYyfTD7PED4LvaQ07a7PWh9hAPhDfTzQ t78edFymG9ZdTu1hz6zkmNbI3RQzOmGjX7M2SpzLJWssbJxAePy7wklhODK0N1nXvU VSxXsQJGBwHaCukHZCYjfN5g05GhHWO8uztglfjGgbeMU1HCDSq7vNFd+fsl26OHH8 6U62BcLSkSLJn6WCXn2b/uM039GX37oPasoM+ONGYrUckf3phGQ0gjVoJbeUewCKQJ J51RjNGt2sjsg== From: Sasha Levin To: punnaysharma805@gmail.com, hverkuil+cisco@kernel.org Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] staging: media: av7110: fix sp8870 initialization failure state" failed to apply to 6.1-stable tree Date: Sat, 7 Nov 2026 05:41:20 -0500 Message-ID: <20261107054120-failed-6.1-30684fa98394@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x 30684fa98394bc0eb4362282908612aab7d4dad9 # git commit -s git send-email --to '' --in-reply-to '20261107054120-failed-6.1-30684fa98394@kernel.org' --subject-prefix 'PATCH 6.1.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 30684fa98394bc0eb4362282908612aab7d4dad9 Mon Sep 17 00:00:00 2001 From: Punnay Sharma Date: Sat, 8 Aug 2026 00:04:43 +0530 Subject: [PATCH] staging: media: av7110: fix sp8870 initialization failure state The SP8870 DVB frontend driver prematurely flags the device as initialized at the very beginning of the sp8870_init() routine, prior to requesting the firmware (dvb-fe-sp8870.fw) and executing the I2C upload sequence. If request_firmware() times out or sp8870_firmware_upload() encounters an I2C bus error, the function aborts and returns -EIO. However, because `state->initialised` is already set to 1, all subsequent invocations of `fe->ops.init()` by the DVB core will immediately return 0 (success) without attempting to load the firmware again. This leaves the demodulator microcontroller halted and the frontend permanently dead until the module is forcibly reloaded. Relocate the `state->initialised = 1` assignment to the end of sp8870_init(), ensuring the flag is only set after the firmware is successfully uploaded and the system controller is actually restarted. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Punnay Sharma Signed-off-by: Hans Verkuil --- drivers/staging/media/av7110/sp8870.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c index 340e4b22859d6..aecdbd87976fd 100644 --- a/drivers/staging/media/av7110/sp8870.c +++ b/drivers/staging/media/av7110/sp8870.c @@ -315,7 +315,6 @@ static int sp8870_init(struct dvb_frontend *fe) sp8870_wake_up(state); if (state->initialised) return 0; - state->initialised = 1; dprintk("initialising frontend...\n"); @@ -353,6 +352,8 @@ static int sp8870_init(struct dvb_frontend *fe) sp8870_writereg(state, 0x0D00, 0x010); sp8870_writereg(state, 0x0D01, 0x000); + state->initialised = 1; + return 0; } -- 2.53.0