From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794048745; b=OmRdPi213c2M1Fd7eoV+fBNWncibFkI9JCvc1cYJvMWPrlNymQn2705mdoq7nJfZpZUF 7FOIGLwayfckybJq6bHOFluC+jcD6PnV4IkiExC498shVEmgzPhplQzRUOTtJqjKFP2W/ 99Iynt/lIZjClDF0UG+GGiEcV5I3rm0SsLwQEdabfD6fW99ARG6k4Yl8tT5X/cTVY6xyE ZIReB9oPvASfYlWBGyX0ZPRupiUZ5Cy5fNY3ysvbaxzWC/Q3wvkYBKik6kzVO3A1luAmD 3YgcxFBZAIs/Q+cJbhDgeaMfAGCYbllrtbzMqBxtC3yW4bvRt/2b6x4uLbVhp5IjR7g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794048745; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=gNvZYkVKBufzmCjO2Q+u+hcRMFb05QzdxdhHuCIl1Sg=; b=FL3SYlzMXmoayphUpAyqQvBX4a4QU5z0oYyEa8Zx2ENM8cAD13oUT6WZP8Y+AQczf/AH t8Y3ZwQzhYq+y8WRTlTxV7mlnDfY2W86k+0heSBQqQ7MZ97/8Yy7hTXotmZYDTcB3VBsd qtzwrrYIqlzFxj2s4akM9/v1P7v3emdAZlbeRPWyofTGR9uxeFBd/B4vq6zRbvcchA//M yqOrN276qr1R0MQ9smc5kPrEYtLfXOGMZSyCPdf7eZm9VU4XaUpOPFriBlq+PUyiK60Nx oZyp5+YSxaCCbA+QtwjLE8rA/ue/xFQwuv8cYvoUmYOsM0qzhjUPls5x9WP/vUblStQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KKIb+86r; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 591E7606A326 for ; Sat, 7 Nov 2026 10:52:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KKIb+86r Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C1B71F0089F; Sat, 7 Nov 2026 10:52:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794048744; bh=gNvZYkVKBufzmCjO2Q+u+hcRMFb05QzdxdhHuCIl1Sg=; h=From:To:Cc:Subject:Date; b=KKIb+86rzAv8uLyvV3+4NzCljKf2Hfemg3WbetV7ehwMSSs7YLh9rzj50BElhkavB K8W+9qPSeOVFxgIBpj5an0upj5Rz6Q5yCU30DvPP5MnX3JA70oEEiKgC6GzYVFWK/d esxxK4S9GwJ40YyIcg+9OGsztLTMLjrAfUgu3pGNtkAD1xESFgIaL9fCzPB6SQI4Xx KzBhiY+M6E3763iqktEHpucArLQsCpz0z0xvic7v9aOAKYvwAJweDDhcs+ttABA3sC Wb8tDWDgT6ofJHC4VkAN+ml7DLM1TF7nAkEeWCxO37MlmCq3jsFhrUxhsTMPAzzNuU 6veXeboEHmeGw== From: Sasha Levin To: daehojeong@google.com, chao@kernel.org, jaegeuk@kernel.org Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] f2fs: don't use truncate_inode_pages_final() on live inodes" failed to apply to 6.1-stable tree Date: Sat, 7 Nov 2026 05:52:23 -0500 Message-ID: <20261107055222-failed-6.1-74bbd6ada01f@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x 74bbd6ada01f91fcad60608e0417bf45a9fa99e6 # git commit -s git send-email --to '' --in-reply-to '20261107055222-failed-6.1-74bbd6ada01f@kernel.org' --subject-prefix 'PATCH 6.1.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 74bbd6ada01f91fcad60608e0417bf45a9fa99e6 Mon Sep 17 00:00:00 2001 From: Daeho Jeong Date: Thu, 15 Oct 2026 16:17:14 +0000 Subject: [PATCH] f2fs: don't use truncate_inode_pages_final() on live inodes truncate_inode_pages_final() is meant to be called from ->evict_inode. It sets AS_EXITING on the mapping, and nothing ever clears it, to tell the VM that the inode is going away. f2fs calls it in two places where the inode stays live: - F2FS_IOC_START_ATOMIC_REPLACE uses it to drop the page cache of the original inode before setting i_size to 0. The atomic write then goes on through this inode. - f2fs_abort_atomic_write() uses it to drop the uncommitted data. It is called on eviction, but also on the last writer's close in f2fs_release_file(), from f2fs_file_flush() when the atomic writer exits, from F2FS_IOC_ABORT_ATOMIC_WRITE and when F2FS_IOC_COMMIT_ATOMIC_WRITE fails. Other processes may still have the file open or mapped in all of these cases. The mapping then stays marked as exiting for as long as the inode is in memory. This stops reclaim from storing workingset shadow entries for it and breaks any code that assumes an exiting mapping has no users left. All we need in both places is to drop the page cache, so use truncate_inode_pages(mapping, 0) instead. The eviction path is not affected, because f2fs_pre_evict_inode() still calls truncate_inode_pages_final() after f2fs_abort_atomic_write(). Cc: stable@kernel.org Fixes: 3db1de0e582c ("f2fs: change the current atomic write way") Fixes: 41e8f85a75fc ("f2fs: introduce F2FS_IOC_START_ATOMIC_REPLACE") Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim --- fs/f2fs/file.c | 2 +- fs/f2fs/segment.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 3b5ad281b518e..b077e4eb790d6 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -2462,7 +2462,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp, bool truncate) fi->original_i_size = isize; if (truncate) { set_inode_flag(inode, FI_ATOMIC_REPLACE); - truncate_inode_pages_final(inode->i_mapping); + truncate_inode_pages(inode->i_mapping, 0); f2fs_i_size_write(inode, 0); isize = 0; } diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 92c3f255ea8fa..daf6d9617d5b6 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -194,7 +194,7 @@ void f2fs_abort_atomic_write(struct inode *inode, bool clean) return; if (clean) - truncate_inode_pages_final(inode->i_mapping); + truncate_inode_pages(inode->i_mapping, 0); release_atomic_write_cnt(inode); clear_inode_flag(inode, FI_ATOMIC_COMMITTED); -- 2.53.0