From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794049115; b=Pus1HxaI7pG535t534oKyuhUqXHP02nNnu3+fD8ttpEXDf2PpL5cKCp8Ly+FFIbRdquk ge7AloiFHQnrZj0V4mttnaqvB6fFqUHAp15Y7f8vHu2wVKxeEp31BP3N/AQrZU9lvxqoD NO0o2lZ+EQ0TbGcNu4Ddxy87F2tIcdSZ0s8QY6oDoPd6jELQdj6g08LAq4ddvVAqZoFxv 5EcmLgOa1H1wxyLBBRMxlMnGb3vhPqchaIbbuR6yDeNj38YJ7/ANkjWcbbPExR9MjNjom iWLsj8M1jZkC/5kESpcLiITZG+UMHQmoIPQuXoXwrassUdf8SSwjFFH191DdZJejPxw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794049115; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=5/XvZ+kumJNybMgzJXlj6I82QaWXUIxnXpwaLo5pjVM=; b=xJl5siDkVTdYOVngmSYq/zG8oQ6VJuw0UCrY3sbcleZngN5dgbZEqIdylbXJkiDLjUkb Z6SLuZLzN+uc3qrhQvDlsnKk5vX+kOhM7mP2KAOe4ktT7iKIGLnaKSmZd80rNLlyAgNzV GwiNAshIce1eNAeDPTlt1UqeMINnsCRtp7iB+bE1H4dpRGIvIXl2ddOkYBj+zVHmPRvjf 90gQZZVqO/FZjWqpyM7TUntRNuTPAXbTa0zqrVdJ/ZavPA9tXdvCENlF/pIczmbDjxVRp ixDLd6ljXgKGe+nC4whClvwP4E4XOdO6iie4Wcjv8fpYKdZfsfOK+yBVf5hpYO3DkzQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=aZnK8eE7; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E899606A326 for ; Sat, 7 Nov 2026 10:58:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=aZnK8eE7 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35F0F1F0089F; Sat, 7 Nov 2026 10:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794049114; bh=5/XvZ+kumJNybMgzJXlj6I82QaWXUIxnXpwaLo5pjVM=; h=From:To:Cc:Subject:Date; b=aZnK8eE77CcLr8eyje0F0nbq87Um+GDDlbI3BgED4juhLX3zI+jT9DectkfrTTYPS frQHgxVi+rBR0J3E99Ov+ppd7upWbGw2ZzoDdYM5e59k3Nzz3v4Q1opDRi+zVLDgEy bgML/KkRDW8owdxdHfyGwyE41knY54A15oT07GhJ7QxA6wDOOWLY+iP59M1jYY3WtK R29D+mk906d51wf2P+PgkiiISTBwv+BhG2sKm2xv0Jfss8mjVf25ryflqC+k4U39SC dpqKzmZ0qzYV4P+ReSHpwyAYE10TErlqINIOPiJXu5o9FdMMRc0Z7aMso5LIGyKN3/ NClAOQomrBJZQ== From: Sasha Levin To: msakai@redhat.com, mpatocka@redhat.com Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] dm vdo indexer: prevent delta list overflow on load" failed to apply to 5.15-stable tree Date: Sat, 7 Nov 2026 05:58:32 -0500 Message-ID: <20261107055832-failed-5.15-936293c9f3f4@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y git checkout FETCH_HEAD git cherry-pick -x 936293c9f3f4f2a0d1b80df9332e96c552ac3b37 # git commit -s git send-email --to '' --in-reply-to '20261107055832-failed-5.15-936293c9f3f4@kernel.org' --subject-prefix 'PATCH 5.15.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 936293c9f3f4f2a0d1b80df9332e96c552ac3b37 Mon Sep 17 00:00:00 2001 From: Matthew Sakai Date: Tue, 11 Aug 2026 15:02:33 -0400 Subject: [PATCH] dm vdo indexer: prevent delta list overflow on load Check for corrupted delta lists sizes that overflow the memory available for the delta_lists. An overflow can cause the delta list data to be written outside the reserved delta memory space. Signed-off-by: Matthew Sakai Signed-off-by: Mikulas Patocka Cc: stable@vger.kernel.org --- drivers/md/dm-vdo/indexer/delta-index.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/md/dm-vdo/indexer/delta-index.c b/drivers/md/dm-vdo/indexer/delta-index.c index b288749067dee..257612b81a9d9 100644 --- a/drivers/md/dm-vdo/indexer/delta-index.c +++ b/drivers/md/dm-vdo/indexer/delta-index.c @@ -800,7 +800,7 @@ static void compute_new_list_offsets(struct delta_zone *delta_zone, u32 growing_ (delta_zone->size * BITS_PER_BYTE - delta_lists[tail_guard_index].size); } -static void rebalance_lists(struct delta_zone *delta_zone) +static int rebalance_lists(struct delta_zone *delta_zone) { struct delta_list *delta_lists; u32 i; @@ -811,9 +811,17 @@ static void rebalance_lists(struct delta_zone *delta_zone) for (i = 0; i <= delta_zone->list_count + 1; i++) used_space += get_delta_list_byte_size(&delta_lists[i]); + if (delta_zone->size < used_space) { + return vdo_log_warning_strerror(UDS_CORRUPT_DATA, + "delta zone lists overflow zone size %zu", + delta_zone->size); + } + compute_new_list_offsets(delta_zone, 0, 0, used_space); for (i = 1; i <= delta_zone->list_count + 1; i++) delta_lists[i].start = delta_zone->new_offsets[i]; + + return UDS_SUCCESS; } /* Start restoring a delta index from multiple input streams. */ @@ -941,8 +949,11 @@ int uds_start_restoring_delta_index(struct delta_index *delta_index, } /* Prepare each zone to start receiving the delta list data. */ - for (z = 0; z < delta_index->zone_count; z++) - rebalance_lists(&delta_index->delta_zones[z]); + for (z = 0; z < delta_index->zone_count; z++) { + result = rebalance_lists(&delta_index->delta_zones[z]); + if (result != UDS_SUCCESS) + return result; + } return UDS_SUCCESS; } -- 2.53.0