From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794049973; b=FAqyiohKCjMZ0ML0KLbRdaVTh38FOF6yWHJlR2ADN57b8LlIQhGGUKHFgxAWREiM1Wzu VQZggkNRBMd0xeWSVURXvyZYQg8xzZqmaF/VQhbFcHdLsobIuHVWRsiFIlxgkAInWQ2Vd V9uwqnePwV4a6+QrxfvtFegtdzPjbPlziJrr9TPUtrjIbpST0h0rwwSzM7Vf61BhUujEN GUj03yLUsoYPxaiD2uwKh/v4MMYv4RypHiCesJX+OcXVhSgF4TKLGWcLmy550W50c7s2g 5NT3hmRTCj8GNClMVu8cXAzNanDjrjMbgXvDV4CtjpHgTFAa3LUTfyCOvCOypUfdlAg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794049973; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=5qDOzmjRlKIdgcmbiySQF+q8bzAJHuwpafZ/DC86uwg=; b=iDEG1Bm5puvvOb4EPQ64wRQpdFLEG8yfh9Fh5JnoXTYK7gdNx5DB+yfGYNIut0Nfzeyc yDkqvLqqP53zfElvB7jCHJjyBnYeEVZb9d//CBSPArmm4d4PdwJJknUx6nyOW4yg+uJu9 YOVOtdSWy2+kfzTD+HwtC7S3HndDPrqB9A2rp2YNYy5H5L/BZAvYkxJm/Y2lsZWqk7/l8 xEqKnEk5gQP1eL4rx22t5zeyiAHIhmNANo9wlc2cQH5/MyF13qhm0HJrVUSRur7huemry UYDHV9ml6th2uyXLdNXEhZt3BoPHNbPoe79F69ZnzjYglZ0m2gmV95ZlPY26a0xC+1A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ikLJBKtn; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF6CA606A326 for ; Sat, 7 Nov 2026 11:12:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ikLJBKtn Received: by smtp.kernel.org (Postfix) with ESMTPSA id 219221F0089F; Sat, 7 Nov 2026 11:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794049972; bh=5qDOzmjRlKIdgcmbiySQF+q8bzAJHuwpafZ/DC86uwg=; h=From:To:Cc:Subject:Date; b=ikLJBKtnt/p/VG1FsSzf11dgf/5ESDKsn6IDlxvykvqwpxu8yyWmUjT/AV8r5lhky m2WVJTG6ghxZSkJeFoXMsVkUJy1akstJF7/KXvnPYKihqQvGZ2FcPi4FuEp9omDZP+ qCbcTnue8pQHpnP6mDCIuQcjVRjVvorRBThkON+ONf34n6883eXGa4or4LMmJgf8gC XPxp8pV9G/Z/7rmlu0e/mDJbbkwv4dN4414QwP5JMR05zRiUjO4jlOEhvALeF+DsJk IcV7xDNt3H7j+1zjBbCEHZLPpXomZo2dmvosJ9v33hYa5A/9zZ649sxqEF3Vnn+Gr5 PGG47OWtsrItA== From: Sasha Levin To: olivier.kaloudoff@gmail.com, xiaogang.chen@amd.com, felix.kuehling@amd.com, alexander.deucher@amd.com Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] drm/amdkfd: stop restore retries on device unplug" failed to apply to 5.15-stable tree Date: Sat, 7 Nov 2026 06:12:50 -0500 Message-ID: <20261107061250-failed-5.15-3254ed0b15f2@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y git checkout FETCH_HEAD git cherry-pick -x 3254ed0b15f2fe656c9cb36ccb59b92422440bf8 # git commit -s git send-email --to '' --in-reply-to '20261107061250-failed-5.15-3254ed0b15f2@kernel.org' --subject-prefix 'PATCH 5.15.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 3254ed0b15f2fe656c9cb36ccb59b92422440bf8 Mon Sep 17 00:00:00 2001 From: Olivier Kaloudoff Date: Tue, 13 Oct 2026 20:53:12 +0200 Subject: [PATCH] drm/amdkfd: stop restore retries on device unplug amdgpu_amdkfd_restore_userptr_worker() and svm_range_restore_work() reschedule themselves when validation fails with evicted objects pending. After a surprise removal the restore paths fail with -ENODEV permanently, so rescheduling just spins the worker uselessly until cancel_delayed_work_sync() in fini finally stops it - which can take a while, since process teardown itself is delayed by the dead device. Treat -ENODEV as terminal in both workers. Cc: Xiaogang Chen Signed-off-by: Olivier Kaloudoff Signed-off-by: Felix Kuehling Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher (cherry picked from commit 266fab83139600e58db7e900e930c722e619b78c) Cc: stable@vger.kernel.org --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 18 +++++++++++++----- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 8 +++++--- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c index ff77e8ae9fe6f..3a4b3424b5b29 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c @@ -2854,6 +2854,7 @@ static void amdgpu_amdkfd_restore_userptr_worker(struct work_struct *work) struct task_struct *usertask; struct mm_struct *mm; uint32_t evicted_bos; + int ret; mutex_lock(&process_info->notifier_lock); evicted_bos = process_info->evicted_bos; @@ -2873,14 +2874,16 @@ static void amdgpu_amdkfd_restore_userptr_worker(struct work_struct *work) mutex_lock(&process_info->lock); - if (update_invalid_user_pages(process_info, mm)) + ret = update_invalid_user_pages(process_info, mm); + if (ret) goto unlock_out; /* userptr_inval_list can be empty if all evicted userptr BOs * have been freed. In that case there is nothing to validate * and we can just restart the queues. */ if (!list_empty(&process_info->userptr_inval_list)) { - if (validate_invalid_user_pages(process_info)) + ret = validate_invalid_user_pages(process_info); + if (ret) goto unlock_out; } /* Final check for concurrent evicton and atomic update. If @@ -2889,11 +2892,14 @@ static void amdgpu_amdkfd_restore_userptr_worker(struct work_struct *work) * reference counting inside KFD will handle this case. */ mutex_lock(&process_info->notifier_lock); - if (process_info->evicted_bos != evicted_bos) + if (process_info->evicted_bos != evicted_bos) { + ret = -EAGAIN; goto unlock_notifier_out; + } if (confirm_valid_user_pages_locked(process_info)) { WARN(1, "User pages unexpectedly invalid"); + ret = -EINVAL; goto unlock_notifier_out; } @@ -2911,8 +2917,10 @@ static void amdgpu_amdkfd_restore_userptr_worker(struct work_struct *work) unlock_out: mutex_unlock(&process_info->lock); - /* If validation failed, reschedule another attempt */ - if (evicted_bos) { + /* If validation failed, reschedule another attempt, unless the + * device is gone for good + */ + if (evicted_bos && ret != -ENODEV) { queue_delayed_work(system_freezable_wq, &process_info->restore_userptr_work, msecs_to_jiffies(AMDGPU_USERPTR_RESTORE_DELAY_MS)); diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c index 1f5d73f0ebce3..a4ce54b06975b 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c @@ -1963,7 +1963,7 @@ static void svm_range_restore_work(struct work_struct *work) struct mm_struct *mm; int evicted_ranges; int invalid; - int r; + int r = 0; svms = container_of(dwork, struct svm_range_list, restore_work); evicted_ranges = atomic_read(&svms->evicted_ranges); @@ -2037,8 +2037,10 @@ static void svm_range_restore_work(struct work_struct *work) mmap_write_unlock(mm); mutex_unlock(&process_info->lock); - /* If validation failed, reschedule another attempt */ - if (evicted_ranges) { + /* If validation failed, reschedule another attempt, unless the + * device is gone for good + */ + if (evicted_ranges && r != -ENODEV) { pr_debug("reschedule to restore svm range\n"); queue_delayed_work(system_freezable_wq, &svms->restore_work, msecs_to_jiffies(AMDGPU_SVM_RANGE_RESTORE_DELAY_MS)); -- 2.53.0