From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794050095; b=Fq275LmJOvWgtIglTc1JeZmuXHYwxxvUhP5WTQjhHgR265fOT8pZnX3/7Gtknb9ooaWq c7ElO5xpFNIJoNyfea82IoEewqS6JAC/JcXL4qRxoVdUT8BoSxibYRJpd08SwzF/oWMHS MPwcogDw+HV72T+juB2wvHGJjdk8W7mibqSAdOyaA46Q/MRNW3SRelAag4CP5IZt+Fzl0 2OQp9gq4FvlmkYwgf8cmmmZ/122cLDNrsppRpfZBiPr8b6BgoKgo5GrsZNF5uXLTPLVSy OQu2yJV+mdVM4dd0nXMfgz92lzxhsmqrCp3XJIBSI90Cn6qYeKVXK54OE3+ov5wMx/A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794050095; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=hdd6c9ljMTCahGFcUja3q9KpUywdv4o2CJUdYtTCJ0w=; b=aCO/ysp/ehJe4DYEX9phUiD5RIBgoXK82PepOYTpG5qcQUKBtkXznXQnig8ZCT2JYBvI z+jvnlTlwnjyFZOWtReCN2XzkUbD0/choNefp6b4ZY48fYNGeCE3zHtdE3ugXLoe0w/h2 0V1c/o9/vLf3C3iSa1LuaJnGQmLmYERae8Ym6uAOMv3EIzejNo6TrbnqbghbMDb+V3ruA thw5gzaNRTJ8ZOOdif/MV5OZRVLv005uhgfOwkf4PJcG13ydGEyXRqbZYg96rSXvHCHgb XngQOV6mY8qYplK1sNUjlcrR9DMt09dBOdO69sEjFWDrHQnjrOdDmLnE0xP8909wR7Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=cWMmosB9; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85CD2606A32D for ; Sat, 7 Nov 2026 11:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=cWMmosB9 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 066911F0089F; Sat, 7 Nov 2026 11:14:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794050094; bh=hdd6c9ljMTCahGFcUja3q9KpUywdv4o2CJUdYtTCJ0w=; h=From:To:Cc:Subject:Date; b=cWMmosB9EmcbPraZVbm2GXneVemNQYClMJybqXViq5T1S2VWW9RfJtZF+rkZ+X6y0 N4DqM44brQytHEQ1y34PkBNGOeQqoTDbGBR3tRIJyWL95LmX61/zZOCX0xOWoTjllf VV8XWafWH9kbR4qADNatzLN3epJ/kqRayrqBXadepS9ZrhSI6TUjWLp/svHBfNHheu Rg+aV7IPeShLD5d56GJ4g8YqFkr8sTtSUfeiXoJcf4R1zVCPgkEPXXrkAkLr9MfQNh Hho41Rfv/rMsx5rCiNdRgfXftWeyIXWTuZP5M9bHkhXMJWyDbcV76RdItRBYK+vGAz mncmyRxhNDK4w== From: Sasha Levin To: punnaysharma805@gmail.com, hverkuil+cisco@kernel.org Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] staging: media: av7110: fix sp8870 initialization failure state" failed to apply to 5.10-stable tree Date: Sat, 7 Nov 2026 06:14:52 -0500 Message-ID: <20261107061452-failed-5.10-30684fa98394@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 30684fa98394bc0eb4362282908612aab7d4dad9 # git commit -s git send-email --to '' --in-reply-to '20261107061452-failed-5.10-30684fa98394@kernel.org' --subject-prefix 'PATCH 5.10.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 30684fa98394bc0eb4362282908612aab7d4dad9 Mon Sep 17 00:00:00 2001 From: Punnay Sharma Date: Sat, 8 Aug 2026 00:04:43 +0530 Subject: [PATCH] staging: media: av7110: fix sp8870 initialization failure state The SP8870 DVB frontend driver prematurely flags the device as initialized at the very beginning of the sp8870_init() routine, prior to requesting the firmware (dvb-fe-sp8870.fw) and executing the I2C upload sequence. If request_firmware() times out or sp8870_firmware_upload() encounters an I2C bus error, the function aborts and returns -EIO. However, because `state->initialised` is already set to 1, all subsequent invocations of `fe->ops.init()` by the DVB core will immediately return 0 (success) without attempting to load the firmware again. This leaves the demodulator microcontroller halted and the frontend permanently dead until the module is forcibly reloaded. Relocate the `state->initialised = 1` assignment to the end of sp8870_init(), ensuring the flag is only set after the firmware is successfully uploaded and the system controller is actually restarted. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Punnay Sharma Signed-off-by: Hans Verkuil --- drivers/staging/media/av7110/sp8870.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c index 340e4b22859d6..aecdbd87976fd 100644 --- a/drivers/staging/media/av7110/sp8870.c +++ b/drivers/staging/media/av7110/sp8870.c @@ -315,7 +315,6 @@ static int sp8870_init(struct dvb_frontend *fe) sp8870_wake_up(state); if (state->initialised) return 0; - state->initialised = 1; dprintk("initialising frontend...\n"); @@ -353,6 +352,8 @@ static int sp8870_init(struct dvb_frontend *fe) sp8870_writereg(state, 0x0D00, 0x010); sp8870_writereg(state, 0x0D01, 0x000); + state->initialised = 1; + return 0; } -- 2.53.0