From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794050266; b=qJHxo5ORSPozMZp6/9qVdKYtV6HFUpTuTwk9/CfqQ48AcyYvlfQdtxK3Z+tlC0rtYTYS 88Kg5y2XJ7k2bCpVD9NBuJLfR71lVVfYEVNBSnd+/fMrUnfi3ZrJwKOFdg0OWQhiFS4oT kLh2oL89G4pEA4eB9+GMJ5pBv67NNyTV2rtYOocWUKc1bRMxBQbF8mF3/J036vT0fKQbH fC/oFCfatve2R8UZRb7Izpfsu3u+qiteUZVtr5HcUGH39FJCLYF9qKB0bpKuPEZvl1Zo+ yQh5r3xEZRHgSJGfZkrf1zLc8+0TRScwA7vbM+aDwx6GBJtfVv32KZlCLVd9qqzNdMw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794050266; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=xANZVg/bVPfcLzJAut5bj2JLKHwSKM19nK4JwumcAeQ=; b=ESizcdbPJYFJhBwc3beRkak5US+OrjmMm+H2bUYMKbu/QIxRJc6MSPBzON/gO6Xdiaew aCWGUeMk+vzlFiOaZOmwT50tmxUijV6LMyhUXS+tJ31Ps/CUfSmaeyppRBpNyvqCj5p/Q BxTdyALtKJAh0cKkAvrDcFPfv+Km8HVlXoZlbWQL8uPZHSXHLm4Oa2Zt06rfMuJ+zktBg g2GiwunlzEM0Kee0JxKVRgRCTwxf6ORNmRj9mso/ZMYLhrCibxjiJwLpKn5+Iu/zEhuRD oMoEEigLTWJyLnoiVJfI6bGwg28KzCpV7rfw0YK7No8BgldxicfCJ0OIBqwDayRZLCQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=hHN6L1FZ; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49A35606A326 for ; Sat, 7 Nov 2026 11:17:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=hHN6L1FZ Received: by smtp.kernel.org (Postfix) with ESMTPSA id A33E21F008A1; Sat, 7 Nov 2026 11:17:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794050266; bh=xANZVg/bVPfcLzJAut5bj2JLKHwSKM19nK4JwumcAeQ=; h=From:To:Cc:Subject:Date; b=hHN6L1FZjuycJ+rt+vJidSkYB81M6Db//ajsEWUULIg+OwzonBmojfbwowkLZTK2l ioZuXxngVbu2e++l/QzhJBaZ7Tpip6jGaQ6pHuN59uAYIO48nTw8SBgotcPEimjXZK j5H1jqr3Dg0gcZXzKIMucJn6HvQbAfodN0YWqLZVUkmwkDgWkpWQZD3r6mjUbM8ajT EPjoEmNtLEf4SAsyInk5Dyreh0A3Oj/JsHxQ+8raMBLBLynK/qXYOL9gOGWp18B8Ji ZrAw1XLdIgyLdI2LPkgwMSp4CefC1TJjXUQrwFkz6E65dJep6f+ewfPRrqGSVbTPfu VWHRbVJO4J6tQ== From: Sasha Levin To: pkshih@realtek.com, luka.gejak@linux.dev, pepe.schlehofer@gmail.com Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] wifi: rtw88: TX report with long timeout for non-PCIE devices" failed to apply to 5.10-stable tree Date: Sat, 7 Nov 2026 06:17:44 -0500 Message-ID: <20261107061744-failed-5.10-7cde94dab0e7@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 7cde94dab0e74434ccc0a387d7ad373fb3becda0 # git commit -s git send-email --to '' --in-reply-to '20261107061744-failed-5.10-7cde94dab0e7@kernel.org' --subject-prefix 'PATCH 5.10.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 7cde94dab0e74434ccc0a387d7ad373fb3becda0 Mon Sep 17 00:00:00 2001 From: Ping-Ke Shih Date: Thu, 24 Sep 2026 08:46:37 +0800 Subject: [PATCH] wifi: rtw88: TX report with long timeout for non-PCIE devices Many USB and SDIO devices can't report TX status within 500 ms, and extending to 2500 ms as tested USB/SDIO devices can fix the problem [1]. To avoid adding chip ID one by one, and this change looks harmless. Keep PCIE using short timeout, and others use long timeout. [1] https://lore.kernel.org/linux-wireless/20260921165343.8131-1-pepe.schlehofer@gmail.com/ Cc: stable@vger.kernel.org Signed-off-by: Ping-Ke Shih Reviewed-by: Luka Gejak Tested-by: Josef Schlehofer Link: https://patch.msgid.link/20260924004637.9958-1-pkshih@realtek.com --- drivers/net/wireless/realtek/rtw88/tx.c | 10 +++++----- drivers/net/wireless/realtek/rtw88/tx.h | 3 ++- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/tx.c b/drivers/net/wireless/realtek/rtw88/tx.c index 4e110a457e71d..701ed7c4f3f75 100644 --- a/drivers/net/wireless/realtek/rtw88/tx.c +++ b/drivers/net/wireless/realtek/rtw88/tx.c @@ -196,7 +196,7 @@ void rtw_tx_report_purge_timer(struct timer_list *t) void rtw_tx_report_enqueue(struct rtw_dev *rtwdev, struct sk_buff *skb, u8 sn) { struct rtw_tx_report *tx_report = &rtwdev->tx_report; - unsigned long timeout = RTW_TX_PROBE_TIMEOUT; + unsigned long timeout; unsigned long flags; u8 *drv_data; @@ -208,10 +208,10 @@ void rtw_tx_report_enqueue(struct rtw_dev *rtwdev, struct sk_buff *skb, u8 sn) __skb_queue_tail(&tx_report->queue, skb); spin_unlock_irqrestore(&tx_report->q_lock, flags); - if ((rtwdev->chip->id == RTW_CHIP_TYPE_8723D && - rtwdev->hci.type == RTW_HCI_TYPE_USB) || - rtw_is_8723bs(rtwdev)) - timeout = msecs_to_jiffies(2500); + if (rtwdev->hci.type == RTW_HCI_TYPE_PCIE) + timeout = RTW_TX_PROBE_TIMEOUT_SHORT; + else + timeout = RTW_TX_PROBE_TIMEOUT_LONG; mod_timer(&tx_report->purge_timer, jiffies + timeout); } diff --git a/drivers/net/wireless/realtek/rtw88/tx.h b/drivers/net/wireless/realtek/rtw88/tx.h index d34cdeca16f19..168f48e87853d 100644 --- a/drivers/net/wireless/realtek/rtw88/tx.h +++ b/drivers/net/wireless/realtek/rtw88/tx.h @@ -7,7 +7,8 @@ #define RTK_TX_MAX_AGG_NUM_MASK 0x1f -#define RTW_TX_PROBE_TIMEOUT msecs_to_jiffies(500) +#define RTW_TX_PROBE_TIMEOUT_SHORT msecs_to_jiffies(500) +#define RTW_TX_PROBE_TIMEOUT_LONG msecs_to_jiffies(2500) struct rtw_tx_desc { __le32 w0; -- 2.53.0