From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794050344; b=vvkK9pafI9aAh96mIp4kxxZ9s9KtsU90L/UeXSP6Sd9tBKklhTG9MSo8n07dDH2rNh8p rEz1mkVRRqU3pfzmn0RDl+dmfQ5SSh31C59lvaVAcR0n0QPdjTiA67uj1quRIRw1wMw6x DvJBsY5H+1qWCB3CSYf87dj3L0qvx0VVfq40IBsCugmqXENHPJJvGVsLBsSYguZ05bSyK 9EBB2TlgI+qFoVwPGPNu8NftmV+rP2R5z8v6B3ygwNQLqxN8oVunfhPzEcfL4kJBhWVb7 hNeArFSYj0qyTnUURESKjOK5uHZGt/b9I9cgczaVFiGbiXgKmiBZKuVhU+WSIq6klBA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794050344; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=Jl5bmy6vGzCpijvTg/hYWvRIELAlchWayhXBU4xHvnE=; b=Y2kCl9TEjYNL/8lwTdKVQ21ZWqb4JmQVn+tO/gmZvWQaHmGqbcJXKiPtFagGqI4kDxJV NpHdKhsOrYda/yLktU0BuNOe+Bv39LAHtmp2iM4fQNpsFtmhb/hwRZfSrZvchrN7DjkCl DDR6RzbPBr7cggN3ooIFNt0AOotEtbg40rOM4VE0+M1V7NBVolktlYaM1JL5lFEDnTRk1 qYjGWmQ4Sl9PUBEKhwKzrw3r/bsf+F17evVC+FJyCr/ixRO+POUmujCbpJRYiYEwhHoQb T7K5ViISM11yARSjVjF5Mf7334qkHMVztfa4H3/+MAl5z240n8LeFA+Cg1bUpHIgQWg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Sd2koTkh; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33D51606A326 for ; Sat, 7 Nov 2026 11:19:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Sd2koTkh Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88FF11F0089F; Sat, 7 Nov 2026 11:19:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794050344; bh=Jl5bmy6vGzCpijvTg/hYWvRIELAlchWayhXBU4xHvnE=; h=From:To:Cc:Subject:Date; b=Sd2koTkhrskxs50sFFc3utDQhafG5IiUrr8OAmvT7MyevuUb9CfgM3Tbr26f1t06j 7iFuJXzU2P5Qd2JldQ3CJI42L3iBjDxhC0BYpZlVqnKRI/trEsQ17dUC0SJijw0Ajj OqkD2rPZLmEnBzJCvSjRhFi7Rt9rGBpkUIn203TTyXfKJOgaHBeNBL4QPMW4LfCuI0 w0Ix6DNsJcGPvdLF1D+Zf8Vn8Ng0i0rTycQGmKdN/3z3rY3YqNctQ3Qh8Gdv9JK7cF 1cqWIhaKYvxtIniQMSpg3umYMO/Ui6oeOBkq8AInK49Ro9+soCcAAUULIvNMxGc5jx G8aXu6f+793PA== From: Sasha Levin To: mhun512@gmail.com, ae878000@gmail.com, broonie@kernel.org Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] ASoC: stm: stm32_i2s: request IRQ after regmap initialization" failed to apply to 5.10-stable tree Date: Sat, 7 Nov 2026 06:19:02 -0500 Message-ID: <20261107061902-failed-5.10-1b207c85551f@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 1b207c85551fd74854d632116849295b2305245f # git commit -s git send-email --to '' --in-reply-to '20261107061902-failed-5.10-1b207c85551f@kernel.org' --subject-prefix 'PATCH 5.10.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 1b207c85551fd74854d632116849295b2305245f Mon Sep 17 00:00:00 2001 From: Myeonghun Pak Date: Sun, 4 Oct 2026 00:34:51 -0400 Subject: [PATCH] ASoC: stm: stm32_i2s: request IRQ after regmap initialization The ISR accesses the managed regmap, but probe requests the IRQ before creating it. An early interrupt can reach an uninitialized regmap. Reverse-order cleanup can free the regmap while the IRQ remains active. Request the IRQ after regmap initialization so probe unwind and removal free and synchronize it before releasing the regmap. The teardown ordering issue was found by static analysis. Fixes: e4e6ec7b127c ("ASoC: stm32: Add I2S driver") Cc: stable@vger.kernel.org Assisted-by: LLM Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Link: https://patch.msgid.link/20261004043451.1138613-1-mhun512@gmail.com Signed-off-by: Mark Brown --- sound/soc/stm/stm32_i2s.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/sound/soc/stm/stm32_i2s.c b/sound/soc/stm/stm32_i2s.c index a59ad94423726..22196f789ae4a 100644 --- a/sound/soc/stm/stm32_i2s.c +++ b/sound/soc/stm/stm32_i2s.c @@ -1197,7 +1197,7 @@ static int stm32_i2s_parse_dt(struct platform_device *pdev, struct device_node *np = pdev->dev.of_node; struct reset_control *rst; struct resource *res; - int irq, ret; + int ret; if (!np) return -ENODEV; @@ -1243,16 +1243,6 @@ static int stm32_i2s_parse_dt(struct platform_device *pdev, return ret; } - /* Get irqs */ - irq = platform_get_irq(pdev, 0); - if (irq < 0) - return irq; - - ret = devm_request_irq(&pdev->dev, irq, stm32_i2s_isr, 0, - dev_name(&pdev->dev), i2s); - if (ret) - return ret; - /* Reset */ rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL); if (IS_ERR(rst)) @@ -1277,7 +1267,7 @@ static int stm32_i2s_probe(struct platform_device *pdev) { struct stm32_i2s_data *i2s; u32 val; - int ret; + int irq, ret; i2s = devm_kzalloc(&pdev->dev, sizeof(*i2s), GFP_KERNEL); if (!i2s) @@ -1303,6 +1293,15 @@ static int stm32_i2s_probe(struct platform_device *pdev) return dev_err_probe(&pdev->dev, PTR_ERR(i2s->regmap), "Regmap init error\n"); + irq = platform_get_irq(pdev, 0); + if (irq < 0) + return irq; + + ret = devm_request_irq(&pdev->dev, irq, stm32_i2s_isr, 0, + dev_name(&pdev->dev), i2s); + if (ret) + return ret; + ret = snd_dmaengine_pcm_register(&pdev->dev, &stm32_i2s_pcm_config, 0); if (ret) return ret; -- 2.53.0