From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794050351; b=NaHqXG+hNXWklw6IQeEL05uPIr9YTWfJpNQBlYqG4pLEU++FWx5zx6rIhHIAoqfqDZ9A YIPfZziZqsCitAPSCHpQ/DOHNfyebIFLz2s/90sgHTWNch9VdF6ym7Cs/nYqoBdGyD5Jr 2w7g+dXcFSVL53VfyDYHCVsLDN8vRKhhkPyKnCCaFYzOwxPEwfPtU9KgtsxbYmhQqMy+9 ZG1nQy5A88U3pun/kKpad4Oe9J4l5seMBdIPtLA2SOXH2dV58tx8rJ6tQvZCx4ia6u7xu lWamLfNiybP7y6fONpaEzPe/IDkT2GUflLzCu8KOR1CGlY1L8L9xv+BkzZhJISkCymA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794050351; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=qfawm8Rl7fAC1ApH712Nq/UDr+bBNWona89NY/nbvnI=; b=U0icH6Ee+Gh5DIswluvoGavIm+36/gdxYIaghiuMgl6iR/NPQmGLR44mW81qZrko1MLj PaQMmLdq4MH4A2zkLnwTc4VzWNd44E7+9TCYWe8DWZraf8lcPRegDiE5rKD1GksmmPKtT K+vbZrLv1VzE6XPqNa61SV8/AfXPTR/vC+FpcdpoRVm7N0xFxWXxfaKMUG3q/06dx5sdc +TPntHVuHIDqDbjXPTj1n7IE14nc+M7j2DQiV+YPcMicRS+YNU8YGqM+9r4PS5TPtjo6m aNShnUQ/URIffKKpn7qtDZf1etZ+NjHTAF1+FdeENkvaujBixnQxfxuXOUxqfJ3KcCA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="KY/CcQDW"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5268606A32D for ; Sat, 7 Nov 2026 11:19:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KY/CcQDW Received: by smtp.kernel.org (Postfix) with ESMTPSA id 138691F0089F; Sat, 7 Nov 2026 11:19:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794050350; bh=qfawm8Rl7fAC1ApH712Nq/UDr+bBNWona89NY/nbvnI=; h=From:To:Cc:Subject:Date; b=KY/CcQDW6RnW8da+/5xBobyzu3fEd6OCdOelCiPfPXG3W98TBYq1d0qDQxQtJzziR 6uDLitXpLxTpjcLRjGXDEtZzd/SnHlVMencgw31Cd5IhR1yP1HWvneJTF2hH0O9o5O YllEk0zbkEEFgROzIt6K3079CK0w9XMuk6lPjOSl2eZyZorSkW5kyNz+0btmGDWXR9 31MsPGgfOlbHsUd1IYdwTYIUy7zhV3YxZvSiG6txXmW5VgdqA7YQnHvh+kGzZQ2RMU auhmVY2vWjRQDX0xZwqddQd7mpjPCa9krjuhBduzXaPdyyLMMb90/84/E2NZalTgw6 uONlrOl4vc0xw== From: Sasha Levin To: nicoyip.dev@gmail.com, akpm@linux-foundation.org, xu.xin16@zte.com.cn, david@kernel.org, hughd@google.com Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] mm/ksm: mark migration stores with WRITE_ONCE()" failed to apply to 5.10-stable tree Date: Sat, 7 Nov 2026 06:19:08 -0500 Message-ID: <20261107061908-failed-5.10-d3863210464f@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x d3863210464f69c18615cbe400d48a6e53e770d4 # git commit -s git send-email --to '' --in-reply-to '20261107061908-failed-5.10-d3863210464f@kernel.org' --subject-prefix 'PATCH 5.10.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From d3863210464f69c18615cbe400d48a6e53e770d4 Mon Sep 17 00:00:00 2001 From: Chengfeng Ye Date: Mon, 24 Aug 2026 19:24:33 +0800 Subject: [PATCH] mm/ksm: mark migration stores with WRITE_ONCE() ksm_get_folio() deliberately samples stable_node->kpfn and folio->mapping without taking the folio lock because the KSM folio may be migrated concurrently. folio_migrate_ksm() updates the same state using plain assignments. The reader can load the old kpfn, then the migrator can store the new kpfn, execute smp_wmb(), and clear the old folio's mapping before the reader checks that mapping. Thus the initial kpfn load can overlap its update and the subsequent mapping load can overlap the clear, with no common lock. This leaves marked READ_ONCE() accesses racing with plain stores. The kernel reported: BUG: KCSAN: data-race in folio_migrate_ksm / ksm_get_folio read (marked) to 0xffff8ce401421330 of 8 bytes by task 48 on cpu 3: ksm_get_folio+0x7f/0x2a0 ksm_scan_thread+0x1635/0x3330 kthread+0x1af/0x1f0 write to 0xffff8ce401421330 of 8 bytes by task 102 on cpu 1: folio_migrate_ksm+0x6a/0xd0 folio_migrate_flags+0x193/0x420 __migrate_folio.isra.0+0x162/0x1a0 migrate_folio+0x4c/0x70 move_to_new_folio+0xd6/0x170 Use WRITE_ONCE() for both stores to pair them with the existing lockless reads. This preserves the existing smp_wmb()/smp_rmb() migration protocol and control flow while preventing compiler transformations of the shared accesses. Link: https://lore.kernel.org/20260824112433.191301-1-nicoyip.dev@gmail.com Fixes: c8d6553b9580 ("ksm: make KSM page migration possible") Signed-off-by: Chengfeng Ye Signed-off-by: Andrew Morton Acked-by: Xu Xin Acked-by: David Hildenbrand (Arm) Cc: Hugh Dickins Cc: --- mm/ksm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mm/ksm.c b/mm/ksm.c index 49d48d1e09980..fe42c17490b89 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -1115,7 +1115,8 @@ static inline void folio_set_stable_node(struct folio *folio, struct ksm_stable_node *stable_node) { VM_WARN_ON_FOLIO(folio_test_anon(folio) && PageAnonExclusive(&folio->page), folio); - folio->mapping = (void *)((unsigned long)stable_node | FOLIO_MAPPING_KSM); + WRITE_ONCE(folio->mapping, + (void *)((unsigned long)stable_node | FOLIO_MAPPING_KSM)); } #ifdef CONFIG_SYSFS @@ -3316,7 +3317,7 @@ void folio_migrate_ksm(struct folio *newfolio, struct folio *folio) stable_node = folio_stable_node(folio); if (stable_node) { VM_BUG_ON_FOLIO(stable_node->kpfn != folio_pfn(folio), folio); - stable_node->kpfn = folio_pfn(newfolio); + WRITE_ONCE(stable_node->kpfn, folio_pfn(newfolio)); /* * newfolio->mapping was set in advance; now we need smp_wmb() * to make sure that the new stable_node->kpfn is visible -- 2.53.0