From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794050553; b=wYNHB4pT2Q06ZTia+LE4QeUK8m1n8w+TYdcSCZw25Y7vNpt1EVbXjFRAcGPYUV2YueR8 MvC5TuIoV4IoeG4JRAEGqux+M9LLT7pOARljd8FbsOq58oi+7kwQOM6JnkVa4VzXaxeQw iklGyB9ymNZEagozntAeMRa+X3NKPjE/wUYF8F0yuaetWZ7eUsZbMd5Yv8Fw3DFztedej MWPAPgV9QyfJsHq5YKj4i4B3i+MrfM1yyqq8C4af0OEqno8lmhLxEhX+aPE50RDSWePCS 8lxkFhyXWs4Ct9FaKLRWAnb5CXI5uPR6jU2QTYeyPHjYLyaDEFoDKT+czDuvtBTyTIw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794050553; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=SEzxHIyXQ5+FWWoZs1LGnZG8H+VspyiKKFJ4PCzLJ4M=; b=Yc298K8V1h76V+f4XxJBh2nBfjR66h+DZ0TpwPEkMK8Cm8zx7f2N643y/YqVUBzp/7eH JxFSGBYCjSbHBRXOMRQQqflw6OJFMyPLhaHzneGCHip+qKM+J4pN867YN7vOEWcEuqH4/ GAT2XVImmYogzQax0BPCiC3ToibMqP5ocCX8tOki9jOw5T7vVpxRWrlxCS5PCBhYLWwCp OG9uYvNAOWtvEOaIfmkLEvUl3rH7e4R6XBzNgUCuepxnc2FZB10ByQfZ9OpT8cqCqi5sS ipBzwRm80ljcTVWbRpxWWLs7YCcJPii5FoiaxHH+v8DscomOH1oN59vGzHEh0qCr7JA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KuY1N9bW; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3533B606A326 for ; Sat, 7 Nov 2026 11:22:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KuY1N9bW Received: by smtp.kernel.org (Postfix) with ESMTPSA id 757051F0089F; Sat, 7 Nov 2026 11:22:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794050553; bh=SEzxHIyXQ5+FWWoZs1LGnZG8H+VspyiKKFJ4PCzLJ4M=; h=From:To:Cc:Subject:Date; b=KuY1N9bWgNr4l6o7fNeyM9CR3F6aiGmn/pfY3abbqEB5TZapdNPGi6dArx8OH0EqQ wkx6AYwjDyf3ut6cPDxCuvg3uHtDgETHFFRbm/ryOwDn9q43Fv9nSBa7iqh4OteqEU 3UWzOoHegHRaWRbXB0+eaUNtNYpe72grP/rP1f8FbuH+Pnrf6LB0cfJrVK7mfeeUjW gHw8AJpkPewoTrJk7nqzrbKqLUx/I9aNcVBOQ8tI6orvOg7C9r4kwGHsqZDaG1ERqs ZUcseBOGB3KsEvf78mD6hrEfa0bGU5NCw6O083UP5+DHv8wnD8UXV9qZI5Qi7vLiS4 +f54uixy+gY4A== From: Sasha Levin To: zhaonanzhe@xiaomi.com, sashiko-bot@kernel.org, chao@kernel.org, jaegeuk@kernel.org Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] f2fs: read i_size once in f2fs_vm_page_mkwrite" failed to apply to 5.10-stable tree Date: Sat, 7 Nov 2026 06:22:31 -0500 Message-ID: <20261107062230-failed-5.10-c04f209773ec@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x c04f209773ecb31e592cababce0d6658ee0b8d58 # git commit -s git send-email --to '' --in-reply-to '20261107062230-failed-5.10-c04f209773ec@kernel.org' --subject-prefix 'PATCH 5.10.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From c04f209773ecb31e592cababce0d6658ee0b8d58 Mon Sep 17 00:00:00 2001 From: Nanzhe Zhao Date: Tue, 13 Oct 2026 18:56:28 +0800 Subject: [PATCH] f2fs: read i_size once in f2fs_vm_page_mkwrite f2fs_vm_page_mkwrite() reads i_size twice: once to check whether the folio is partially beyond EOF, and once to calculate the offset for folio_zero_segment(). But a concurrent buffered write can extend isize and cause the following race condition to corrupt data: buffered write writes [0,3500) CPU0 (write fault) CPU1 (buffered write) ---- ---- f2fs_vm_page_mkwrite() folio_lock(folio) if (((loff_t)(folio->index + 1) << PAGE_SHIFT) > i_size_read(inode)) /* i_size_read() = 3500 */ write(fd, buf, 200, 4096) /* writes into page1, does not wait for folio lock */ i_size_write(inode, 4296) offset = i_size_read(inode) & ~PAGE_MASK /* i_size_read() = 4296, offset = 200 */ folio_zero_segment(folio, offset, folio_size(folio)) /* valid data [200, 3500) is zeroed */ Fix this by reading i_size once and using the same value for both the EOF check and the zeroing offset. Reported-by: Sashiko Closes: https://sashiko.dev/#/patchset/20261012030315.978375-1-zhaonanzhe%40xiaomi.com Fixes: fbfa2cc58d53 ("f2fs: add file operations") Cc: stable@vger.kernel.org Signed-off-by: Nanzhe Zhao Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim --- fs/f2fs/file.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 4363e28056e6b..713fb6f49bcb3 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -125,6 +125,7 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf) struct f2fs_sb_info *sbi = F2FS_I_SB(inode); struct dnode_of_data dn; bool need_alloc = !f2fs_is_pinned_file(inode); + loff_t isize; int err = 0; vm_fault_t ret; @@ -188,8 +189,14 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf) filemap_invalidate_lock_shared(inode->i_mapping); folio_lock(folio); + /* + * A concurrent buffered write can extend isize, so we store isize in a + * local variable to let the zeroing offset match the EOF check below. + */ + isize = i_size_read(inode); + if (unlikely(folio->mapping != inode->i_mapping || - folio_pos(folio) > i_size_read(inode) || + folio_pos(folio) > isize || !folio_test_uptodate(folio))) { folio_unlock(folio); err = -EFAULT; @@ -219,11 +226,10 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf) f2fs_wait_on_block_writeback(inode, dn.data_blkaddr); /* page is wholly or partially inside EOF */ - if (((loff_t)(folio->index + 1) << PAGE_SHIFT) > - i_size_read(inode)) { + if (((loff_t)(folio->index + 1) << PAGE_SHIFT) > isize) { loff_t offset; - offset = i_size_read(inode) & ~PAGE_MASK; + offset = isize & ~PAGE_MASK; folio_zero_segment(folio, offset, folio_size(folio)); } folio_mark_dirty(folio); -- 2.53.0