From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794050623; b=3p4gos5xcgrJIztTX8Gfzelpn1LGOVYqxGb8tyXU/QVX5vQuh1I1MmHh4OiJnBDWHLI1 uhnxA2kTz3KL3Ahzj5AzsNQHsN1Oo0uXIKjgxU40xA+NVZab79bN7wS1t82tUYHgaVAp8 uXEPdRa49bsK98Lz+kWVo+DkLqTX2N4C7luzlpuMOnUwdjz16CdcbViY3Xnbb6Ul/j+Ix RiWM+gBK2PDGSQb/T/qx3GJUJ1fpAaNTfW6hrnN5YY4c5bBbXAtmOZXFYX+Gzz9yNb0qK Pm3behquMWL8fTvQm2Ih8IDEf1je5ACDQONuEzOs5sZEw5ho9edYKUndldMlqAFyG2Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794050623; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=w/k73HRKUFR2tBQc2OrHGQYQapK+CMaDD6l9gy91Vss=; b=Se2nHrisvenJ/XPSJkyeBgzPqdgOKZXFYae9OTJXHtXCTwoQ8nvmL3w/knKyZxjSj2fT CiW71DlRaVluZSLRwCMxGLWBtDyCHUAGq+gPQO3DSCgxDr6UiJXGGSn2PHPfa7GBlXMFc mMxYJl762FWjcLLDku1KpEuPQX3mzOHklj92N7HSVPjuzXXqlOLQMLqcwbB++H5m7Qz9Q tjgWFPqPaBDrxpjS88mRIaNuP68mebfzL+CuZ8GtjfdfQTsLNM5+6OLXSFrvKwnla7g2I HEqzOaoe5FeBhg/4RKVq31d6mP1t3hVdlmStg3lQTl7iZ1rPHq3lL8iMckTQuzxJJRg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="T/A3DwWA"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F44D606A32C for ; Sat, 7 Nov 2026 11:23:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=T/A3DwWA Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECD3A1F0089F; Sat, 7 Nov 2026 11:23:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794050623; bh=w/k73HRKUFR2tBQc2OrHGQYQapK+CMaDD6l9gy91Vss=; h=From:To:Cc:Subject:Date; b=T/A3DwWAFTmojoa7G0FcYmBWl0nB1a3ztOgJHMcXCcl94cdI9/FVMx1KM/3xfwsXD OdsdCDbERQBxbubPLyS9pmCO4HltcB4YX3yrYjn9MHbQ1zcEpWTyIaINYCEtVTJ8yV cc7SAUqDjtZIvKGVxavgRniOHnhbVcL40lNl53I3vnqKBY1SvLnUpFSCahifjGHxOH fWzCI4E+ER5UKWI4sTVx52OlCVeU76bYZhZNsaNkWiI1d6+tixY3QSOd4SC3fGb7/g ALpzZHX8U8MSdrlx6I4Hp7UoYr6ZBnXOEwzAqRCiriZw+BQh+VykTYiuoTGkTBSSQ9 dSO9hBPuJ4fIw== From: Sasha Levin To: kmehltretter@gmail.com, tglx@kernel.org, radu@rendec.net Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] irqchip/atmel-aic[5]: Disable interrupts in the irq_pm_shutdown() callbacks" failed to apply to 5.10-stable tree Date: Sat, 7 Nov 2026 06:23:41 -0500 Message-ID: <20261107062341-failed-5.10-0ca21fe11145@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 0ca21fe111457c843624a835641bb490e704bb2f # git commit -s git send-email --to '' --in-reply-to '20261107062341-failed-5.10-0ca21fe11145@kernel.org' --subject-prefix 'PATCH 5.10.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 0ca21fe111457c843624a835641bb490e704bb2f Mon Sep 17 00:00:00 2001 From: Karl Mehltretter Date: Sat, 26 Sep 2026 02:41:24 +0200 Subject: [PATCH] irqchip/atmel-aic[5]: Disable interrupts in the irq_pm_shutdown() callbacks irq_gc_shutdown() calls the irq_pm_shutdown() callbacks from syscore_shutdown() with interrupts enabled. aic_pm_shutdown() and aic5_pm_shutdown() take the generic chip lock with raw_spin_lock(), and irq_gc_eoi() takes the same lock from the interrupt handler. An interrupt from the chip while the lock is held spins in irq_gc_eoi() and hangs the reboot. Lockdep reports this on every reboot of a SAM9X75 Curiosity board: WARNING: inconsistent lock state inconsistent {IN-HARDIRQ-W} -> {HARDIRQ-ON-W} usage. busybox/101 [HC0[0]:SC0[0]:HE1:SE1] takes: c1c2b434 (&gc->lock){?.-.}-{2:2}, at: aic5_pm_shutdown+0x34/0xd8 {IN-HARDIRQ-W} state was registered at: ... irq_gc_eoi+0x28/0x60 handle_fasteoi_irq+0x120/0x214 ... aic5_pm_shutdown from irq_gc_shutdown+0x4c/0x58 irq_gc_shutdown from syscore_shutdown+0x5c/0x9c syscore_shutdown from kernel_restart+0x34/0x78 kernel_restart from sys_reboot+0x180/0x25c Use the irqsave guard, as commit 33517881ede7 ("irqchip/brcmstb-l2: Use _irqsave locking variants in non-interrupt code") did for brcmstb-l2. Fixes: b1479ebb7720 ("irqchip: atmel-aic: Add atmel AIC/AIC5 drivers") Signed-off-by: Karl Mehltretter Signed-off-by: Thomas Gleixner Assisted-by: LLM Reviewed-by: Radu Rendec Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260926004124.88221-1-kmehltretter@gmail.com --- drivers/irqchip/irq-atmel-aic.c | 2 +- drivers/irqchip/irq-atmel-aic5.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-atmel-aic.c b/drivers/irqchip/irq-atmel-aic.c index 1dcc52760ecae..4a7935e75e4dd 100644 --- a/drivers/irqchip/irq-atmel-aic.c +++ b/drivers/irqchip/irq-atmel-aic.c @@ -123,7 +123,7 @@ static void aic_pm_shutdown(struct irq_data *d) { struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d); - guard(raw_spinlock)(&gc->lock); + guard(raw_spinlock_irqsave)(&gc->lock); irq_reg_writel(gc, 0xffffffff, AT91_AIC_IDCR); irq_reg_writel(gc, 0xffffffff, AT91_AIC_ICCR); } diff --git a/drivers/irqchip/irq-atmel-aic5.c b/drivers/irqchip/irq-atmel-aic5.c index 1f14b401f71d0..07a317ed06ef4 100644 --- a/drivers/irqchip/irq-atmel-aic5.c +++ b/drivers/irqchip/irq-atmel-aic5.c @@ -217,7 +217,7 @@ static void aic5_pm_shutdown(struct irq_data *d) struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d); int i; - guard(raw_spinlock)(&bgc->lock); + guard(raw_spinlock_irqsave)(&bgc->lock); for (i = 0; i < dgc->irqs_per_chip; i++) { irq_reg_writel(bgc, i + gc->irq_base, AT91_AIC5_SSR); irq_reg_writel(bgc, 1, AT91_AIC5_IDCR); -- 2.53.0