From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794050786; b=cnY5PfFDJXk71aKuZUDGBEbWdl9YD/wuQ8CZSJT4chUHA7RmI1HlDCF7IM5N+MS77Yin 2N5+nkEbUeyiq/pF6ZX3wrmthJ9eyZrLh6wvbuDlqAoSsX1f1X852E88okJ58JkUNwEv4 S2pz3ZdEbCR/Qg+DLN0XCXWC11OuYzKcY5ybsWGkbSMgatZNRvYLAbyhxiPcekWSP1rtw 2Lwn8D34mXbi84OIhmvKbHqgLOFKA3rtv52oBvE3M1Q1Ci4G6XCloJCZjEerpUO2K/i0Y n1g8Afpoq6/Yt7+6EkRng0smKH8J12XpTAh8//YRjTuAimhlcGWyJo0uBQESERHWqig== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794050786; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=NDrH+9xs76/VVQf6DHhGsgxgqosEVsnjOoPV+GjCh8Q=; b=pFWpMXKZwe2mBsIu4DLmtR/THU6uDK3QcMT75y4iXG0f3oKnswoYCEjdVdQImkcekjiQ NNF+99ZMUX0b3cIEflSKLgRgHPj+Ffu1A3BzldocokaTiKaxcw58lJ/ksLbNofmOrC6Dt ygqkbLZXcIyDHHHidb7SAbpIcgMjWdVFtnch5VhqiM7lG01W/mcDx0w1BiOmJK05eytwC w8HyixFrW9mpLpWioR7rGrnrJ1WI+p53z1sFsLqiKLDZszuzjsl0MNutV9Jwq4+4H/kqc y3T3Rn4x8xR2b5mTqWGzKOK6n1ZBJn47ywJr5rDmey1J7QxhFakqlYd49C1h71m4JKA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=SGbDdejE; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05A63606A32C for ; Sat, 7 Nov 2026 11:26:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=SGbDdejE Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73CEB1F0089F; Sat, 7 Nov 2026 11:26:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794050785; bh=NDrH+9xs76/VVQf6DHhGsgxgqosEVsnjOoPV+GjCh8Q=; h=From:To:Cc:Subject:Date; b=SGbDdejEPqDwzNalFd4EcqVU90fM/FDMw8WT+WHut5VixYrG7431QHP3e1/xbNJ6M Ftt9ezd1zq9T/9mvUQ4lb5UrI6tQTdUq6Fz6XQUs7ivLHAJpGtO93krM6XYyvYfIYF yN9lpWV1k1N1u5B9jQLcRvdym7o4Hh2y9/qE8AIvsDdNtCrqteZ4HbA7Nt8FBkM6eX mEzAREnWJssrph/B3nkYX7nPiBlfOkDyjl+eIuAWvekwi9NKfsJ5zMfMlch8QKcimR C/UivF92BF34Hk2ZzsrZsS1GCa700cnTrH1Dl/z+ouP0OZ6SH09wdtMr6lFO99EJEf VB6qfzUDCjeLA== From: Sasha Levin To: sahaj123.sc@gmail.com, bartosz.golaszewski@oss.qualcomm.com Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] gpio: pca953x: Handle direction register read errors in IRQ paths" failed to apply to 5.10-stable tree Date: Sat, 7 Nov 2026 06:26:24 -0500 Message-ID: <20261107062623-failed-5.10-a0fe26929350@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x a0fe269293509acdd93b9cfb3f46636f7b91b33a # git commit -s git send-email --to '' --in-reply-to '20261107062623-failed-5.10-a0fe26929350@kernel.org' --subject-prefix 'PATCH 5.10.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From a0fe269293509acdd93b9cfb3f46636f7b91b33a Mon Sep 17 00:00:00 2001 From: Sahaj Chaudhari Date: Sun, 18 Oct 2026 22:20:03 +0530 Subject: [PATCH] gpio: pca953x: Handle direction register read errors in IRQ paths Three IRQ paths ignore the result of reading the direction registers and then use the destination bitmap. pca953x_read_regs() does not populate that bitmap when regmap_bulk_read() fails, leaving the callers to use uninitialized stack data. This can select incorrect GPIOs for direction changes during IRQ bus synchronization, corrupt the saved input state during IRQ setup, or produce incorrect pending interrupt decisions. Check the read result at all three sites. Release irq_lock without changing GPIO directions on failure, leave the IRQ history untouched when pending detection fails, and propagate the error from IRQ setup. The read helper already logs the error. Fixes: 0f25fda840a9 ("gpio: pca953x: Zap ad-hoc reg_direction cache") Cc: stable@vger.kernel.org Signed-off-by: Sahaj Chaudhari Link: https://patch.msgid.link/20261018165003.3372368-1-sahaj123.sc@gmail.com Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-pca953x.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index 869ed4264d48a..afec5ec236968 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -867,6 +867,7 @@ static void pca953x_irq_bus_sync_unlock(struct irq_data *d) DECLARE_BITMAP(irq_mask, MAX_LINE); DECLARE_BITMAP(reg_direction, MAX_LINE); int level; + int ret; guard(mutex)(&chip->i2c_lock); @@ -885,7 +886,9 @@ static void pca953x_irq_bus_sync_unlock(struct irq_data *d) } /* Switch direction to input if needed */ - pca953x_read_regs(chip, chip->regs->direction, reg_direction); + ret = pca953x_read_regs(chip, chip->regs->direction, reg_direction); + if (ret) + goto out; bitmap_or(irq_mask, chip->irq_trig_fall, chip->irq_trig_raise, gc->ngpio); bitmap_or(irq_mask, irq_mask, chip->irq_trig_level_high, gc->ngpio); @@ -895,6 +898,7 @@ static void pca953x_irq_bus_sync_unlock(struct irq_data *d) for_each_andnot_bit(level, irq_mask, reg_direction, gc->ngpio) pca953x_gpio_direction_input_unlocked(&chip->gpio_chip, level); +out: mutex_unlock(&chip->irq_lock); } @@ -989,7 +993,9 @@ static bool pca953x_irq_pending(struct pca953x_chip *chip, unsigned long *pendin } /* Remove output pins from the equation */ - pca953x_read_regs(chip, chip->regs->direction, reg_direction); + ret = pca953x_read_regs(chip, chip->regs->direction, reg_direction); + if (ret) + return false; bitmap_copy(old_stat, chip->irq_stat, gc->ngpio); @@ -1089,7 +1095,9 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base) * interrupt. We have to rely on the previous read for * this purpose. */ - pca953x_read_regs(chip, chip->regs->direction, reg_direction); + ret = pca953x_read_regs(chip, chip->regs->direction, reg_direction); + if (ret) + return ret; bitmap_and(chip->irq_stat, irq_stat, reg_direction, gc->ngpio); mutex_init(&chip->irq_lock); -- 2.53.0