From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794062774; b=kym+GmAjKoGirpFH8+uxvEu/cj2jnxHjb/x7zUyqdt2z5rOVE5oMJpdJIm8vPiOWdy/i siUZyYm39MG74yhIs9URYB1IlApxXKlYfC35ibPNVX1YypxVDzfgZIrftRc/s6F+2xhmt F11LjNNLhS4PDpXQ67+c2L+pItfB8VYUiB7qNmroGG8WE33BePCy4NWx3vHBaXZZP8dju nqBLZhg4f95vx5wC/BD7jVjq2Eo7mktxCs1xV0kdJdQwZIrjMIZKyisq4AlaUiUKEtT13 3KftYXD6JlijViIIOpOJNfxLEm0+pchnjjQCiHO8x5EaumI66YrEk8G+Slkgl0CMktw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794062774; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=RTvqh10eXWUhO2li3P6t6O7+He774wW5C0RjwNj1czo=; b=k+aD3XvBuW2Ocl7IPA+kWBNOrlGM1ptmFxCT7Gum5y4f/E7MeY1Lgj6LTjoo0VgKJ+Ey etE0TvM9nghHbtNXd6jDspV1EX9f0f/4ZJjZESeqF1hm0ycum2bBRLhb7YA+fb/CcvYKB l2PNmyPpC7+va9/MM/vchQsicKQzUEpf3S4KMvpm3mp8V5njb2E+qjKShF5G4DnncE3DD VZAE+cYVFfx3067iqTPnYaJszcGoa5C36jkrE0wwHN5YdX9Aw4RY67tMwLFiKZjFP9k4k RBlVx2JGdHWhJnk/VPuZ4cL7NTcA6W1fxNmzBrUXTSzUZVri1wVOhO7yMYj5BD1K3Mg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Cpb6e8n0; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFD46606A32C; Sat, 7 Nov 2026 14:46:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Cpb6e8n0 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D49D1F0089F; Sat, 7 Nov 2026 14:46:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794062773; bh=RTvqh10eXWUhO2li3P6t6O7+He774wW5C0RjwNj1czo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Cpb6e8n03S29cSfm9+2CCluhn3usrqaksaptGG9XhWsY0KpOmAgOoHkxJj/8at2ji Lx70RQzVnM3MwRd1P+47vafzZ++Zmn1N18IBqS2go2FOiziQhF6AVfFXEqnlMmNbkO zA9JD383HXojtpt2V8DZVO3YWqYtwCooizh2byY4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ruoyu Wang , Hans Verkuil , Sasha Levin Subject: [PATCH 6.18 080/869] media: au0828: Free URBs when starting DVB streaming fails Date: Sat, 7 Nov 2026 08:46:02 -0500 Message-ID: <20261107134855.432889950@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134852.069646174@linuxfoundation.org> References: <20261107134852.069646174@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ruoyu Wang [ Upstream commit b8dd133d96a40012f4b67fd48d8ddd7306a3e024 ] start_urb_transfer() stores each allocated URB in dev->urbs[], but sets urb_streaming only after all URBs have been submitted. If a later URB or transfer buffer allocation fails, earlier entries are left allocated. A submission failure calls stop_urb_transfer(), but that function returns immediately while urb_streaming is false, leaving both submitted and unsubmitted URBs behind. Make stop_urb_transfer() release every populated slot regardless of the streaming flag and clear each slot after release. Route all start errors through this cleanup. usb_kill_urb() safely handles both submitted and unsubmitted URBs, while the existing preallocation check preserves the lifetime of shared transfer buffers. This issue was found by a static analysis checker and confirmed by manual source review. Fixes: 265a6510629a ("V4L/DVB (7621): Add support for Hauppauge HVR950Q/HVR850/FusioHDTV7-USB") Cc: stable@vger.kernel.org Signed-off-by: Ruoyu Wang Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/usb/au0828/au0828-dvb.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/media/usb/au0828/au0828-dvb.c b/drivers/media/usb/au0828/au0828-dvb.c index 51752a922a744..4dc6377466858 100644 --- a/drivers/media/usb/au0828/au0828-dvb.c +++ b/drivers/media/usb/au0828/au0828-dvb.c @@ -163,9 +163,6 @@ static int stop_urb_transfer(struct au0828_dev *dev) dprintk(2, "%s()\n", __func__); - if (!dev->urb_streaming) - return 0; - if (dev->bulk_timeout_running == 1) { dev->bulk_timeout_running = 0; timer_delete(&dev->bulk_timeout); @@ -179,6 +176,7 @@ static int stop_urb_transfer(struct au0828_dev *dev) kfree(dev->urbs[i]->transfer_buffer); usb_free_urb(dev->urbs[i]); + dev->urbs[i] = NULL; } } @@ -200,8 +198,10 @@ static int start_urb_transfer(struct au0828_dev *dev) for (i = 0; i < URB_COUNT; i++) { dev->urbs[i] = usb_alloc_urb(0, GFP_KERNEL); - if (!dev->urbs[i]) - return -ENOMEM; + if (!dev->urbs[i]) { + ret = -ENOMEM; + goto err; + } purb = dev->urbs[i]; @@ -217,7 +217,7 @@ static int start_urb_transfer(struct au0828_dev *dev) ret = -ENOMEM; pr_err("%s: failed big buffer allocation, err = %d\n", __func__, ret); - return ret; + goto err; } purb->status = -EINPROGRESS; @@ -235,10 +235,9 @@ static int start_urb_transfer(struct au0828_dev *dev) for (i = 0; i < URB_COUNT; i++) { ret = usb_submit_urb(dev->urbs[i], GFP_ATOMIC); if (ret != 0) { - stop_urb_transfer(dev); pr_err("%s: failed urb submission, err = %d\n", __func__, ret); - return ret; + goto err; } } @@ -249,6 +248,10 @@ static int start_urb_transfer(struct au0828_dev *dev) dev->bulk_timeout_running = 1; return 0; + +err: + stop_urb_transfer(dev); + return ret; } static void au0828_start_transport(struct au0828_dev *dev) -- 2.53.0