From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794063188; b=PdSpCGGvcBfX+KIYj7dAB7LKl2mmIPoKmseETL1mzdzT6pEDx1CooGkwkaKzg2fGJXPV 5/MC0mei9zIJEoM/LXFEBML5+QTyamLRn91Owutq8hN2edrZq9ZHkOsM9ppvST6AzCK+b uynu9KDmBf8VKrj5ju8ojnrXblROFdmc7a6rzd1upT6FX5hnLCDvfFGi/W7gCPlXuwH1C rebCUzFJZy3PqpVX//XWzrRtwqcHhOlDiSOiD/uQTFGoC8vrq3sXane6liiWoC1xWLWvK Bzh3En+YQTFxEc/a4EB2iZPRxCDgg/i34kysR3YU6hDFyHl78udR4aIGKZBfGb2GRHA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794063188; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=tk0hGNn1vV7rjP5H7p9iA2RaiYQwgu2TU3E1+HfB5KU=; b=P+APaawM7tHYiiHxAje80U37imQgCBOKCmKKut4JOkDbRNqvrhT+2ToRoog2iOnmAOZV m52liNbXYr1iVsj4Xt9Xf7sgFc8H5rY8aJvnoBGwfFRSf1DWKOCQuPmbA3WxI1/sIVwmO 1DB8Nf1/KuKwVwp7/HENIvViITAsruHi6RcqoHAmgs3f+k0vFh6FgoGjptdou/q5ILv1a +U63+RQ79t/55w4Gp/jWFggne/I53wLB/yu2SvkCc80lVQmlgM5/mqY5mVb8UEeq/OIWZ zk6kjM7/CanbPtfgnWjdD4JE+qiHmkYEGucfPWiM9EpTtSwDybRwEVTTAlmiMDtwnbQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=wY9WIzDI; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7288606A330; Sat, 7 Nov 2026 14:53:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=wY9WIzDI Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5639A1F0089F; Sat, 7 Nov 2026 14:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794063187; bh=tk0hGNn1vV7rjP5H7p9iA2RaiYQwgu2TU3E1+HfB5KU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=wY9WIzDI36Zr8PY6kUznmM/5mo/UHADNPG8q6UP0fvHKhVd5OMaUgwp3TcYJWd5eO vxumkmJ4xU08OOUNsuK6oxWqyetDdgEKahJGZzbVOgPcziztXlpyPdsgulIZYZCiKp jDAu8XJQVW5GSCVpLKNFbB0Z+/n1wua1rhwmEy3M= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wentao Liang , Felix Fietkau , Sasha Levin Subject: [PATCH 6.18 404/869] wifi: mt76: Fix of_node reference leak in mt76_get_rate_power_limits() Date: Sat, 7 Nov 2026 08:51:26 -0500 Message-ID: <20261107134907.070657023@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134852.069646174@linuxfoundation.org> References: <20261107134852.069646174@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wentao Liang [ Upstream commit 8d604c899f7bd1a76a2eb21c0b706c02878abd36 ] mt76_find_power_limits_node() and mt76_find_channel_node() return nodes with the reference held, but mt76_get_rate_power_limits() overwrites the "txpower-" node reference and never releases the channel node reference, leaking both. Drop the intermediate and the channel node reference on every exit path, and take a reference on the fallback node returned by mt76_find_power_limits_node() so the caller's of_node_put() is balanced. Fixes: 22b980badc0f ("mt76: add functions for parsing rate power limits from DT") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang Link: https://patch.msgid.link/20260917121944.2150737-1-vulab@iscas.ac.cn Signed-off-by: Felix Fietkau Signed-off-by: Sasha Levin --- drivers/net/wireless/mediatek/mt76/eeprom.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c index 6ce8e4af18fe5..281b2c3e9e7cf 100644 --- a/drivers/net/wireless/mediatek/mt76/eeprom.c +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c @@ -224,12 +224,14 @@ mt76_find_power_limits_node(struct mt76_dev *dev) struct property *regd = of_find_property(cur, "regdomain", NULL); if (!country && !regd) { - fallback = cur; + of_node_put(fallback); + fallback = of_node_get(cur); continue; } if (mt76_string_prop_find(country, dev->alpha2) || mt76_string_prop_find(regd, region_name)) { + of_node_put(fallback); of_node_put(np); return cur; } @@ -356,7 +358,7 @@ s8 mt76_get_rate_power_limits(struct mt76_phy *phy, s8 target_power) { struct mt76_dev *dev = phy->dev; - struct device_node *np; + struct device_node *np, *band_np; const s8 *val; char name[16]; u32 mcs_rates = dev->drv->mcs_rates; @@ -389,15 +391,18 @@ s8 mt76_get_rate_power_limits(struct mt76_phy *phy, band = '6'; break; default: + of_node_put(np); return target_power; } snprintf(name, sizeof(name), "txpower-%cg", band); - np = of_get_child_by_name(np, name); - if (!np) + band_np = of_get_child_by_name(np, name); + of_node_put(np); + if (!band_np) return target_power; - np = mt76_find_channel_node(np, chan); + np = mt76_find_channel_node(band_np, chan); + of_node_put(band_np); if (!np) return target_power; @@ -422,6 +427,8 @@ s8 mt76_get_rate_power_limits(struct mt76_phy *phy, ARRAY_SIZE(dest->ru), val, len, target_power, txs_delta, &max_power); + of_node_put(np); + return max_power; } EXPORT_SYMBOL_GPL(mt76_get_rate_power_limits); -- 2.53.0