From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794063302; b=oK8zO1Qy4cs/5vkwrubhK72/PRwzP/ZE0vGeDCo52bCWdu3qq46wdqNQuvtOJwW4t9nH AuHBbqmDidOqc1WlxrllKJkOP1fMG4F7k6y2W6ayV1J3/IxNXypdP/Mw3jqtxBBuvz4V2 7werf84tUxUz4F9kdw++PlBM3HM8WIY7EA7o2WwVZcneogeEaQCTKnOln1KQaONacnVEF ot8lIq5VPaaCQbQZxKyaOG8/Uf/TdUNlBvL+J7/fLliORcfnBzODTEcEf0FEMuGB8GJ8R UjGk4vKDRMYRdKBjT/BzzTWcje4hRyYH2MBgO6R3TveCURIdm/z19PKe8pWGYG539bg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794063302; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=j9EnOf8L80ApiTUQdrxvrxhSbmm+IsAwHa2CvSa9DCE=; b=K+pMJItQ9ByWjRoaVu4Tc3yRHwMQmTocOgZYaTLn7+fgznk9DxF+4uPxx/GC8QUCPz9D yZuB7bHxK168mnH++ic1Ly6x6F1mRyxYmvignN+sD4f/AF+jW24Wuuc6LBwTzG+YiBNKI uebcKL3gVpZCJ61BjHu4tfREb8ApM8WUFZ0mTShGv1BjNgqL7NtDCKpPr+asmj6kb3mE0 cq5kL9XXhxMG4f516BCFTaEGcasdiu+PzV9UwBD6VDjNyBv8GF3EpQC5ghVwBAKsS0Hha 5fHM3bRUA6CBgUH7bpOELw8YRYsICeNlQpBPPOKUflw3ePvzyj7zxi4YT71xcRPS9dA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=KvufEsvW; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AB69606EEB1; Sat, 7 Nov 2026 14:55:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=KvufEsvW Received: by smtp.kernel.org (Postfix) with ESMTPSA id 075821F008A2; Sat, 7 Nov 2026 14:55:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794063302; bh=j9EnOf8L80ApiTUQdrxvrxhSbmm+IsAwHa2CvSa9DCE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=KvufEsvWmNUF6F/k3kk26rm4JmgQVAHDeWiGAfdj6nmsFM5A48nFF8GktrfOIYofC hJgveNyjASXXAuMMo4bjlLs/Kx5/BoWHT6QxxV1zWx3ifUcQUP+kgELm7NsIZweIuR ScEDzxZqlTTf0Ko3T1ogWIlySBRbFX18ucAWfN04= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Muhammad Bilal , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sasha Levin Subject: [PATCH 6.18 493/869] platform/x86: hp-wmi: fix heap OOB read and memory corruption in hp_wmi_perform_query() Date: Sat, 7 Nov 2026 08:52:55 -0500 Message-ID: <20261107134910.263715775@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134852.069646174@linuxfoundation.org> References: <20261107134852.069646174@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Muhammad Bilal [ Upstream commit 6dea092b261f04d632411c2be52d13190f5f67b1 ] hp_wmi_perform_query() evaluates an ACPI WMI method and expects a struct bios_return header in the returned buffer. However, it only checks that the ACPI object type is ACPI_TYPE_BUFFER without verifying that obj->buffer.length is at least sizeof(*bios_return) (8 bytes). If the firmware or ACPI method returns a buffer shorter than 8 bytes: 1. bios_return->return_code at offset 4 reads out of bounds from the allocated ACPI buffer slab. 2. If return_code evaluates to 0 and outsize is non-zero, (int)(obj->buffer.length - sizeof(*bios_return)) evaluates to a negative integer (e.g. -8 for a 0-length buffer). actual_outsize is set to this negative value and passed to memcpy(buffer, ..., actual_outsize), where the signed negative value is cast to size_t (e.g. 0xfffffffffffffff8), attempting to copy ~18 Exabytes and triggering an immediate kernel crash. Additionally, memset(buffer + actual_outsize, ...) performs an out-of-bounds write before buffer. Fix this by ensuring obj->buffer.length is at least sizeof(*bios_return) before accessing the return code, and compute actual_outsize safely using min_t(u32, ...), which is sound specifically because the guard above already rules out obj->buffer.length being smaller than sizeof(*bios_return) by the time that subtraction runs. Fixes: c3021ea1beee ("hp-wmi: allow setting input and output buffer sizes separately") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal Link: https://patch.msgid.link/20260826103012.240453-1-meatuni001@gmail.com Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen Signed-off-by: Sasha Levin --- drivers/platform/x86/hp/hp-wmi.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c index 5eb2aade44cca..f92bb3dca2e30 100644 --- a/drivers/platform/x86/hp/hp-wmi.c +++ b/drivers/platform/x86/hp/hp-wmi.c @@ -491,8 +491,9 @@ static int hp_wmi_perform_query(int query, enum hp_wmi_command command, goto out_free; } - if (obj->type != ACPI_TYPE_BUFFER) { - pr_warn("query 0x%x returned an invalid object 0x%x\n", query, ret); + if (obj->type != ACPI_TYPE_BUFFER || + obj->buffer.length < sizeof(*bios_return)) { + pr_warn("query 0x%x returned wrong type or too small buffer\n", query); ret = -EINVAL; goto out_free; } @@ -511,7 +512,7 @@ static int hp_wmi_perform_query(int query, enum hp_wmi_command command, if (!outsize) goto out_free; - actual_outsize = min(outsize, (int)(obj->buffer.length - sizeof(*bios_return))); + actual_outsize = min_t(u32, outsize, obj->buffer.length - sizeof(*bios_return)); memcpy(buffer, obj->buffer.pointer + sizeof(*bios_return), actual_outsize); memset(buffer + actual_outsize, 0, outsize - actual_outsize); -- 2.53.0