From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794063911; b=c4VPmfgbdx9CzhZVDBVwfjfc7oxgKg6X7G7VmBmYyA7906oZooMsnGafAHLPfy4eqDB4 VoNPl9yHVFLG7PAum34Vwb+N2Fx6u2StAgBuqniQ6gE/nWzmJdRkwkRgFSHMTEbSu0swh pvzmDhcJRXg8iFNxvqg20U6pmxMW1UoxuYqB13NZDSToLjT9PY1w/Q/0HMRLImUAiivhp 5edtZN0p4+faRStjfbE84PtE/GlbSgqi49EtMUt7WyD+s6gOYgDVpUAd2qhJsQx/Qsm8m NEr8avkVjPwJAF0hDQRqpfLPC3cmNsdLmphbAjJ7MJ4XLWUAqtFyDRRf9/7L2LwohZA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794063911; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=Efw53lAdWBlSL9kn9o0BmkQZVvKQHTmhwyEOIxhB3bs=; b=QXLs3No7V1uYFbsMJT0IvV3GVEdS3N8B+1aBARmbUVrWqA1WUXQQOA7vXDJ1moLzK69i iTbDuStgyhOSCeJM9lrhOYeuCSdmQW5VpFZtaOTPUL1vArLFNy9gWVDujFsSZbZ4a5zGT knZ6R0DrRvh/2pACKgdA92YXFsSwzodhbXHxZBQij0jGcZoysia1+Yjt1d8dYsFP+1hgG ftJshJfHluxv0UhFMD5z4eLZa6Itn8WohfL5bPa8crPgyQRaiKiU/oThFaRd8ylZ82A/M 6NAFsY3EuW9kRRBgvH6/QMrCK8E+pOMB+/mAItjO33CqGqlXh8rWz/SsMEpRAwiDizg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=rLN4R0t4; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1FD0606E8E7; Sat, 7 Nov 2026 15:05:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=rLN4R0t4 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FD211F0089F; Sat, 7 Nov 2026 15:05:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794063910; bh=Efw53lAdWBlSL9kn9o0BmkQZVvKQHTmhwyEOIxhB3bs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=rLN4R0t4V71NAY84R2vj+hwgxY31NGnc0wGC3unsCtVoyj15T19VEivGLviLltOxS i6dL1F28Qiij09N/8JxVrLNQ+VTrHlhQEGzbtdtHpLhCcpmDOyqXNOt3dmoEPIk6ut 4D9Kz+mNmnGEC7Vhowb8FnCPfm6aIROmEKz/8O2I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Balakrishnan Sambath , Eugen Hristev , Hans Verkuil , Sasha Levin Subject: [PATCH 7.3 0109/1257] media: microchip-isc: synchronize the IRQ before disabling clocks on stop Date: Sat, 7 Nov 2026 08:40:05 -0500 Message-ID: <20261107134942.364632021@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134939.434104957@linuxfoundation.org> References: <20261107134939.434104957@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Balakrishnan Sambath [ Upstream commit 19fa5407da5ef3e605cacfcd90f70d8b2c121cd7 ] isc_stop_streaming() masks the DMA interrupt and then drops the runtime PM reference, which disables the ISC clocks. microchip_isc_interrupt() may still be executing on another CPU at that point; it reads ISC_INTSR over regmap, and touching the unclocked registers triggers an external abort. Store the IRQ number at probe and call synchronize_irq() after masking the interrupt, before dropping the PM reference. Fixes: 106267444f12 ("[media] atmel-isc: add the Image Sensor Controller code") Cc: stable@vger.kernel.org Signed-off-by: Balakrishnan Sambath Reviewed-by: Eugen Hristev Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/platform/microchip/microchip-isc-base.c | 3 +++ drivers/media/platform/microchip/microchip-isc.h | 1 + drivers/media/platform/microchip/microchip-sama5d2-isc.c | 2 ++ drivers/media/platform/microchip/microchip-sama7g5-isc.c | 2 ++ 4 files changed, 8 insertions(+) diff --git a/drivers/media/platform/microchip/microchip-isc-base.c b/drivers/media/platform/microchip/microchip-isc-base.c index ca4f3b5f58aa9..debbc38717de1 100644 --- a/drivers/media/platform/microchip/microchip-isc-base.c +++ b/drivers/media/platform/microchip/microchip-isc-base.c @@ -425,6 +425,9 @@ static void isc_stop_streaming(struct vb2_queue *vq) /* Disable DMA interrupt */ regmap_write(isc->regmap, ISC_INTDIS, ISC_INT_DDONE); + /* let a running IRQ handler finish before the clock is disabled */ + synchronize_irq(isc->irq); + pm_runtime_put_sync(isc->dev); /* Disable stream on the sub device */ diff --git a/drivers/media/platform/microchip/microchip-isc.h b/drivers/media/platform/microchip/microchip-isc.h index ad4e98a1dd8fc..f5e322c2e36bc 100644 --- a/drivers/media/platform/microchip/microchip-isc.h +++ b/drivers/media/platform/microchip/microchip-isc.h @@ -287,6 +287,7 @@ struct isc_device { u32 dcfg; struct device *dev; + int irq; struct v4l2_device v4l2_dev; struct video_device video_dev; diff --git a/drivers/media/platform/microchip/microchip-sama5d2-isc.c b/drivers/media/platform/microchip/microchip-sama5d2-isc.c index 18e1ec0b94fa6..5bd109e93a8fb 100644 --- a/drivers/media/platform/microchip/microchip-sama5d2-isc.c +++ b/drivers/media/platform/microchip/microchip-sama5d2-isc.c @@ -448,6 +448,8 @@ static int microchip_isc_probe(struct platform_device *pdev) if (irq < 0) return irq; + isc->irq = irq; + ret = devm_request_irq(dev, irq, microchip_isc_interrupt, 0, "microchip-sama5d2-isc", isc); if (ret < 0) { diff --git a/drivers/media/platform/microchip/microchip-sama7g5-isc.c b/drivers/media/platform/microchip/microchip-sama7g5-isc.c index 07cfe1109ff09..d978ce448a4d2 100644 --- a/drivers/media/platform/microchip/microchip-sama7g5-isc.c +++ b/drivers/media/platform/microchip/microchip-sama7g5-isc.c @@ -437,6 +437,8 @@ static int microchip_xisc_probe(struct platform_device *pdev) if (irq < 0) return irq; + isc->irq = irq; + ret = devm_request_irq(dev, irq, microchip_isc_interrupt, 0, "microchip-sama7g5-xisc", isc); if (ret < 0) { -- 2.53.0