From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794063944; b=me5K36eBRrxNuKjrOIzAuJ0v22JfSzhhEyFiroiyGTir8kbEwqU5yyrZLFWhfZ7nxtIb zrFmUHbMyAXJW1Hn98ThjlrjElGBb48NJzsfDSDqYTzaALrcPCn07kmfEWxFI7Y+rmmF4 czxP5eRGdYM4/k3qzhy8oQhRG3MzNUIX7+lJOcXOEYAEUsOIMhBaQm5lsFnVflK3oUSwb l+/tYordlX8TeIHdi7vTOKwsaw6pD4F0MOdorYkZM3z10o8jzsjgItO69/d3OH/r8fW/I tGsnMCZRLri2bnMppq2Ocgu4cJDt1CkDR9o7iF0rJz/3WsGIG4W3ezM78sVB9EzM/Qw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794063944; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=YKc2D2XA3szISivz8q3BnEVzJ3rkMDz8J2f8hkA7KP4=; b=C3VQUM0F/DweGgD/d+5uAJxGvxEwhTZpvfNFhTcLOfYNqFVAFfuPl+A7adi11GZUSYT9 v2Bd1WJDCbfmCPlc1w2LVOK27aARZ0mYZov6q00mzQjHkFxAsbAGbP23OLofBLBVmuHit xwOPa7rqmOxUNsqnb6tZ+qgf2X4WJi7AgMdG7VzzHgSDGZ6R83KMgd02ES1w8v/lRvz6w 0M8POzCvt8envyUOUMk2qk5IM3hlX6mmGzj0jfJsfx6S81lukLFDtTwAgQbdoFqkrnBDh MCosf46+J1iHdKrif+Ez4EJSSsVTeLIK1BDoFVZDVf13m7thJd7O1D3giCn+lcoim4w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=HYt6kQG0; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 125ED606D829; Sat, 7 Nov 2026 15:05:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=HYt6kQG0 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4FB21F0089F; Sat, 7 Nov 2026 15:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794063943; bh=YKc2D2XA3szISivz8q3BnEVzJ3rkMDz8J2f8hkA7KP4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=HYt6kQG0o1jYUKR8yVh2uCFRfHrUbrGsL3JXkX/pPgUyWSNavuNE2Otb3c8tJ37s8 hWUn5Sx9hbJAsDCOcS0Y/KIqi5oOkOCdwPwM4LExMSKd+tB6eBIGCp4rG8hxGw/6ti qp3ICRohhRIeX9Xmlzw0+p8l7p2/8q6CuH9hMke8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Song Li , Fan Wu , Sebastian Reichel , Sasha Levin Subject: [PATCH 7.3 0136/1257] power: supply: bq27xxx: Ensure poll work is cancelled on remove Date: Sat, 7 Nov 2026 08:40:32 -0500 Message-ID: <20261107134943.068563913@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134939.434104957@linuxfoundation.org> References: <20261107134939.434104957@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fan Wu [ Upstream commit db560f4b1c5253853f978385db066220e0c218dc ] The di->work poll work is queued from the poll callback itself and from bq27xxx_external_power_changed(). The cancel_delayed_work_sync() in bq27xxx_battery_teardown() runs while the power_supply is still registered, so external_power_changed() can re-arm the work after the cancel, and it runs after the driver data has been freed. Register a devm_delayed_work_autocancel() before devm_power_supply_register(), so on unwind the power_supply is unregistered first, after which no new external_power_changed() callback can be dispatched, and the poll work is cancelled only then. Drop the now-redundant cancel from bq27xxx_battery_teardown(). This issue was found by an in-house static analysis tool. Fixes: 740b755a3b34 ("bq27x00: Poll battery state") Cc: stable@vger.kernel.org Assisted-by: Codex:gpt-5.6 Co-developed-by: Song Li Signed-off-by: Song Li Signed-off-by: Fan Wu Link: https://patch.msgid.link/20260903081312.225535-1-fanwu01@zju.edu.cn Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/bq27xxx_battery.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c index 4d4809a70b622..cd30993b8a89e 100644 --- a/drivers/power/supply/bq27xxx_battery.c +++ b/drivers/power/supply/bq27xxx_battery.c @@ -43,6 +43,7 @@ */ #include +#include #include #include #include @@ -2234,7 +2235,6 @@ int bq27xxx_battery_setup(struct bq27xxx_device_info *di) }; int ret; - INIT_DELAYED_WORK(&di->work, bq27xxx_battery_poll); ret = devm_mutex_init(di->dev, &di->lock); if (ret) return ret; @@ -2255,6 +2255,12 @@ int bq27xxx_battery_setup(struct bq27xxx_device_info *di) psy_desc->get_property = bq27xxx_battery_get_property; psy_desc->external_power_changed = bq27xxx_external_power_changed; + /* Cancel the poll work after the power_supply is unregistered. */ + ret = devm_delayed_work_autocancel(di->dev, &di->work, + bq27xxx_battery_poll); + if (ret) + return ret; + di->bat = devm_power_supply_register(di->dev, psy_desc, &psy_cfg); if (IS_ERR(di->bat)) return dev_err_probe(di->dev, PTR_ERR(di->bat), @@ -2281,8 +2287,6 @@ void bq27xxx_battery_teardown(struct bq27xxx_device_info *di) mutex_lock(&di->lock); di->removed = true; mutex_unlock(&di->lock); - - cancel_delayed_work_sync(&di->work); } EXPORT_SYMBOL_GPL(bq27xxx_battery_teardown); -- 2.53.0