From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794063970; b=jzN17Gsm7rC8FLtJyltBF7LeSi9neA64E979Ml63qhSBHzfxei2eeYmQGqNONbIST/mj oKk4DL2qHB70bcFhcnmd9cpkX/Nr3qkZwuP2ZY7SClw6MV9rX194foT82Ial1eiTPW81O 3s/z7mlStgQuVjIXuBelyo/IjT9U+anVGGuDPI1wjbbCnYrP3m7Vzb1rXKHoNLNvDvIT5 i6n0KXuTQrXRfhGEFYRy6Et2nrs2cNP2s4dJLRoqUP76Sbrm9SY7LpGrdrXQaek2AlXXD JejwKpHukymXcaMog9ATOgU2c2hKgKVRzLXPZ1wIBFVSOqJwCeKOMLB1suSCdNbfrsA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794063970; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=UYQpvg1d+kR1yv9+3f5WpQJxpcnH/zhSe3+abZ+9IKE=; b=P6wB3rYiaxpaL4z6Gp5tgFJFnIf55gtzIDioRn5k28qTQK2PY3IsT3Ih6oINL11c2zQ5 4yFYM4VK82JslHdJmqRsHvXdJhoMDh8xPQJI9Cn5QCcqDqNSkf/RGPubXulIsqrLJ+y+4 bIeUiiEfm6UTP2LLqF1RBF90vGO8rNvwSsQjZjMbb7EoaX7os4rO4s4LBrqOoSMBualM4 6iziP8Pcx57dRbr8lqYDMQQ4mHXVwM/Lbh+fIF8kgYtqGao36UishkXKRCugPclCYjnS0 VSaUtVGg5UGDjdrIEBlK+f/ZHRCrEgigQfEgiOtfUJt+UbSrAZMKAO9djrJUw1/mh7Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=t62dLDCp; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A139F608362B; Sat, 7 Nov 2026 15:06:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=t62dLDCp Received: by smtp.kernel.org (Postfix) with ESMTPSA id 126111F008A4; Sat, 7 Nov 2026 15:06:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794063970; bh=UYQpvg1d+kR1yv9+3f5WpQJxpcnH/zhSe3+abZ+9IKE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=t62dLDCpfxPn8DkXH7q4hgpsCiO5u7l1fV+yEbyylFwPXH/GLv4BFM/yhgpdbBPqd dTlOxvEcyWqXCPzvHpOogb1EG2mNXiroDCGHfIClbxeVj4+Pn8W9H+d5v8XU8mEP8W oUEdCcKBW9Z3cHCcCpv0ad3X08nE14VxnyyQzt24= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Joshua Crofts , Fabio Cesari , Jonathan Cameron , Sasha Levin Subject: [PATCH 7.3 0155/1257] iio: light: isl29028: fix runtime PM reference leak on error paths Date: Sat, 7 Nov 2026 08:40:51 -0500 Message-ID: <20261107134943.601396113@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134939.434104957@linuxfoundation.org> References: <20261107134939.434104957@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fabio Cesari [ Upstream commit 0e30d15b15647df786e60022650613e16dd70645 ] isl29028_read_raw() and isl29028_write_raw() take a runtime PM reference with pm_runtime_resume_and_get() but return directly on their error paths without dropping it. The usage count never balances again and the device stops entering autosuspend for good. In isl29028_read_raw() this needs a regmap access to fail; in isl29028_write_raw() one rejected sysfs write is enough, for example echo 200 > in_proximity_sampling_frequency which is outside the [1:100] range and returns -EINVAL with the reference still held. Take the reference with PM_RUNTIME_ACQUIRE_AUTOSUSPEND() instead, so it is released on every return path. This also stops the return value of pm_runtime_put_autosuspend() from reaching userspace. That value only says whether the device could be suspended right away, so -EAGAIN or -EPERM turns a successful access into a failure, and with CONFIG_PM=n the stub returns -ENOSYS on every access. Fixes: 2db5054ac28d ("staging: iio: isl29028: add runtime power management support") Suggested-by: Joshua Crofts Cc: stable@vger.kernel.org Assisted-by: LLM coccinelle Signed-off-by: Fabio Cesari Reviewed-by: Joshua Crofts Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/light/isl29028.c | 33 ++++++++------------------------- 1 file changed, 8 insertions(+), 25 deletions(-) diff --git a/drivers/iio/light/isl29028.c b/drivers/iio/light/isl29028.c index 33deb1726689e..e481ac908fc13 100644 --- a/drivers/iio/light/isl29028.c +++ b/drivers/iio/light/isl29028.c @@ -342,8 +342,9 @@ static int isl29028_write_raw(struct iio_dev *indio_dev, struct device *dev = regmap_get_device(chip->regmap); int ret; - ret = pm_runtime_resume_and_get(dev); - if (ret < 0) + PM_RUNTIME_ACQUIRE_AUTOSUSPEND(dev, pm); + ret = PM_RUNTIME_ACQUIRE_ERR(&pm); + if (ret) return ret; mutex_lock(&chip->lock); @@ -392,14 +393,7 @@ static int isl29028_write_raw(struct iio_dev *indio_dev, mutex_unlock(&chip->lock); - if (ret < 0) - return ret; - - ret = pm_runtime_put_autosuspend(dev); - if (ret < 0) - return ret; - - return 0; + return ret; } static int isl29028_read_raw(struct iio_dev *indio_dev, @@ -408,10 +402,11 @@ static int isl29028_read_raw(struct iio_dev *indio_dev, { struct isl29028_chip *chip = iio_priv(indio_dev); struct device *dev = regmap_get_device(chip->regmap); - int ret, pm_ret; + int ret; - ret = pm_runtime_resume_and_get(dev); - if (ret < 0) + PM_RUNTIME_ACQUIRE_AUTOSUSPEND(dev, pm); + ret = PM_RUNTIME_ACQUIRE_ERR(&pm); + if (ret) return ret; mutex_lock(&chip->lock); @@ -461,18 +456,6 @@ static int isl29028_read_raw(struct iio_dev *indio_dev, mutex_unlock(&chip->lock); - if (ret < 0) - return ret; - - /** - * Preserve the ret variable if the call to - * pm_runtime_put_autosuspend() is successful so the reading - * (if applicable) is returned to user space. - */ - pm_ret = pm_runtime_put_autosuspend(dev); - if (pm_ret < 0) - return pm_ret; - return ret; } -- 2.53.0