From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794063979; b=CNsw394COC0m8xQieW7OLhvTSCAgn+5LRsWrBsLsdZb8DS5vaKbj2etFZxz10lSvWCyq l0j1JelPHiU7YtdWq/gknzF+CEfsezLhNadGa0hGjvN4stlUvkoj0/8SdxkIQVhKYnlET 4XZMUfOrOwwl9ifgxqAGVUxFcVdFWmq4LAgegm/VhNTsZU8JoDAzoC0225p8OqvlnHJkE Abgb1OMZlZ3rqhG/2D37xBhjd9RiW4ch1QAsXd5yBO8fD/2N48U6hdb6w3c3Sgpo+GmTk fE7ezMUxp0mR52lmNwLf20dOrbiqwId4kF8BVQ8wEHLgjIf0daHyUwQYaO6m3B1ulzQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794063979; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=Rhfmu2wc+GMxhAvyigFNchLOCbIvHw89tKhlkw2f7sI=; b=G0FXV8gulpIYmLqenlDFWLZVCFqCc8OKLEffMjh7hvdHXm0gvQBdcRWrPoySh6xluJ1P 1HLroubFyuT0i+tYN4IVpjxj1Hqz3C1Z6zRNPvimbYmYj1vTRwLxa5m9vGs1fJWZ/VzYT HGmYT2uUvYTOqQK9KtO3SN2o5sNuFyigEXlHQOWxNA2XsOGRa5jSeyeN2yAKPN1ViWsYI vnOTeqyXZEd2xSWAv5jdcoP8FSLpKsLmllY/wjWhD7f2sopKdCwwLIREYDY9Vz/hUSM0M BQQyPGFr2nUKBGYXWriAZdJjPh/vF64AeW5aRb6oknkLo0ltXvSptTSopqvKbH6Y7Pg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="Sui6/sg3"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DF3A60A2603; Sat, 7 Nov 2026 15:06:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Sui6/sg3 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09F5F1F008AB; Sat, 7 Nov 2026 15:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794063979; bh=Rhfmu2wc+GMxhAvyigFNchLOCbIvHw89tKhlkw2f7sI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Sui6/sg3cxWNStB0ed8/98VN0pBcHgoygkWnOmM6q+Qd/iBXKhxHN9kjdHb8vFHrD xNEOs/KqdZ1OZ/09n5NTZba+L6qiDiR9FMxzJg8DigdRRYc80NpuHaj1v9zSjdWoEC GDcyYUDkdouhtOhbBrJzT1RsIw35OpR8LF4z+H+8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.org, Zhiguo Niu , Chao Yu , Jaegeuk Kim , Sasha Levin Subject: [PATCH 7.3 0162/1257] f2fs: compress: fix to handle race between truncate and writeback Date: Sat, 7 Nov 2026 08:40:58 -0500 Message-ID: <20261107134943.805821191@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134939.434104957@linuxfoundation.org> References: <20261107134939.434104957@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chao Yu [ Upstream commit c0337e331b065074ce20e4258a578e07dd7e4083 ] fsstress reports a kernel BUG in f2fs_truncate_partial_cluster(): kernel BUG at fs/f2fs/compress.c:1238! RIP: 0010:f2fs_truncate_partial_cluster+0x292/0x2a0 Call Trace: f2fs_truncate+0xf6/0x210 f2fs_setattr+0x6b7/0x770 notify_change+0x33b/0x520 do_truncate+0xc2/0xf0 vfs_truncate+0x153/0x1d0 ksys_truncate+0x78/0xd0 __x64_sys_truncate+0x16/0x20 do_syscall_64+0xbe/0x540 The root cause is that Thread A (truncate) and Thread B (background writeback or fsync) can race as follows: Thread A Thread B - f2fs_setattr - f2fs_truncate - f2fs_truncate_blocks - f2fs_truncate_partial_cluster - f2fs_is_compressed_cluster return 1 - f2fs_write_cache_pages - f2fs_write_multi_pages - f2fs_write_raw_pages - f2fs_write_single_data_page dn.data_blkaddr != COMPRESS_ADDR (cluster converted to normal) - f2fs_prepare_compress_overwrite - f2fs_is_compressed_cluster return 0 - return 0 - f2fs_bug_on(sbi, err == 0): BUG! Writeback path does not acquire i_gc_rwsem or filemap_invalidate_lock. When a compressed cluster fails compression during writeback, it is overwritten with raw data blocks. If Thread A checked f2fs_is_compressed_cluster() before the conversion, but calls f2fs_prepare_compress_overwrite() after the conversion, f2fs_prepare_compress_overwrite() returns 0 because the cluster is no longer a compressed cluster. To fix this, remove the f2fs_bug_on() and retry checking the cluster status when f2fs_prepare_compress_overwrite() returns 0, so that it can fall back to f2fs_do_truncate_blocks() to handle it as a normal cluster. Cc: stable@kernel.org Fixes: 3265d3db1f16 ("f2fs: support partial truncation on compressed inode") Reviewed-by: Zhiguo Niu Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/compress.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c index ce88092d9ce26..b711076040128 100644 --- a/fs/f2fs/compress.c +++ b/fs/f2fs/compress.c @@ -1222,6 +1222,7 @@ int f2fs_truncate_partial_cluster(struct inode *inode, u64 from, bool lock) int i; int err; +repeat: err = f2fs_is_compressed_cluster(inode, start_idx); if (err < 0) return err; @@ -1233,12 +1234,11 @@ int f2fs_truncate_partial_cluster(struct inode *inode, u64 from, bool lock) /* truncate compressed cluster */ err = f2fs_prepare_compress_overwrite(inode, &pagep, start_idx, &fsdata); - - /* should not be a normal cluster */ - f2fs_bug_on(F2FS_I_SB(inode), err == 0); - - if (err <= 0) + if (err < 0) return err; + else if (err == 0) + /* the cluster became non-compressed one due to race case */ + goto repeat; rpages = fsdata; -- 2.53.0