From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794064173; b=NMm9fOS22x4IQ5ycEgvsRAa2eNcluK6oXzdAz33a2zWnLlkDpGG0To8ue13RbLE+c0gV qthxF89Dzd7n0JVH/tppecrhqp4eNIwql5iIKifhGGso3UJlrqUwSiru2lJHHfhz6vsWV VjjB7aESVB1A3E8mBw9IgyV1c6X0TQsZrxwxHdNtum4lLhGgEhxLSGUtZnbYIRaekIvwk fE0n+9Z3BYfm67qX3RuMs8zltYm7gv2MmO0gELnEIEFw5aTgD00jH9HS0KU4+wNprCnLR 46JuAOm/R4uIkAd+32Oeviaew5zw/M0AROgT6kBXehctgi100Dohb7oNR2v6i7+jdyg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794064173; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=OslPp6orxgXmt3hPxh8H57a0CtFrcoNULnZPuo8xT30=; b=IVM5ODnZeMWdDuBGoxf8GjgT/eHmlzcd5Q77qUz3D4Z8WKyDd6dk8gN0ZmMJO/zkyaqv OmFwrFbfiqt//qCG7qVo1etUdfXo8CJS8Eat9j9MgHDvf2dlhhrqPV7C7/RqzzYxc1W1+ GGtAftanlOdD0ort6O87eCrIHgr06mjPyXHMms/Q+Nsj1kQKyD+scFqTBzGDQY0CUZ+g0 N4XcMFg4vAbyyfTCWGjsrNHzKbiW1cTz+sVI4epR8XQOWyZWJQhKujWJvVqDDzzTKy/Nv JMA2+X+3xBOI3KWZlUvPX3O0NgqYCehYvvJFL/Ba+O5XvojzNtjBSwHe5z9zqLffHxQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=d3VyIqZ3; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 568C8606D810; Sat, 7 Nov 2026 15:09:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=d3VyIqZ3 Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABD3C1F0089F; Sat, 7 Nov 2026 15:09:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794064172; bh=OslPp6orxgXmt3hPxh8H57a0CtFrcoNULnZPuo8xT30=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=d3VyIqZ3YssRCoGhHqkXXxBR5os9DNmh+1Iw6eXdaluE2zKWxasdL9zCS8Dzoc1+d 3QbDkeAuwgzjssuzYpF4KCj00MeSbm9XoYYiJ7C1Tsh1FmW4DaNzVP2Qk1aqbhHdTk PmhO17x4dpc9qCSTkR2vEh4lWr3RVMeuaEvtvXKA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tom Verdonck , Guenter Roeck , Sasha Levin Subject: [PATCH 7.3 0318/1257] hwmon: (tmp108) Fix jiffies wraparound in conversion-ready check Date: Sat, 7 Nov 2026 08:43:34 -0500 Message-ID: <20261107134948.213196221@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134939.434104957@linuxfoundation.org> References: <20261107134939.434104957@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tom Verdonck [ Upstream commit 6b8b1d1d7bc7e579b53fc7c3293b787d68de702a ] tmp108 records a one-shot deadline in ->ready_time at probe (and resume) and, on every temperature read, refuses the read with -EAGAIN while time_before(jiffies, ready_time) is true, in order to skip the initial conversion. ->ready_time is an unsigned long compared with time_before(), whose signed difference is only meaningful while the two values are within LONG_MAX jiffies of each other. Because ->ready_time is set once and never refreshed, jiffies keeps advancing away from it, and after 2^31 jiffies the difference flips sign. On a 32-bit HZ=100 kernel that happens ~248.5 days after boot: time_before() then permanently reports "not ready" and the driver returns -EAGAIN on every read, without ever touching the sensor, until the next reboot. The continuous-mode path, which sets ->ready_time to jiffies with no added conversion delay, wraps the same way. Store the deadline as a 64-bit jiffies value and compare it with get_jiffies_64()/time_before64(), which does not wrap in any practical uptime. Fixes: 66e1c9171339 ("hwmon: Add Texas Instruments TMP108 temperature sensor driver.") Cc: stable@vger.kernel.org Signed-off-by: Tom Verdonck Link: https://patch.msgid.link/525fa49d8c50922344fa53e22be5e6133c9bbb62.1790358356.git.tom.verdonck@inspiral.be Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/tmp108.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hwmon/tmp108.c b/drivers/hwmon/tmp108.c index 9fa31bd66ff69..91d20a1ce1120 100644 --- a/drivers/hwmon/tmp108.c +++ b/drivers/hwmon/tmp108.c @@ -78,7 +78,7 @@ struct tmp108 { struct regmap *regmap; u16 orig_config; - unsigned long ready_time; + u64 ready_time; const struct tmp108_params *params; }; @@ -138,7 +138,7 @@ static int tmp108_read(struct device *dev, enum hwmon_sensor_types type, switch (attr) { case hwmon_temp_input: /* Is it too early to return a conversion ? */ - if (time_before(jiffies, tmp108->ready_time)) { + if (time_before64(get_jiffies_64(), tmp108->ready_time)) { dev_dbg(dev, "%s: Conversion not ready yet..\n", __func__); return -EAGAIN; @@ -477,7 +477,7 @@ static int tmp108_common_probe(struct device *dev, struct regmap *regmap, char * return err; } - tmp108->ready_time = jiffies; + tmp108->ready_time = get_jiffies_64(); if ((tmp108->orig_config & TMP108_CONF_MODE_MASK) == TMP108_MODE_SHUTDOWN) tmp108->ready_time += @@ -528,7 +528,7 @@ static int tmp108_resume(struct device *dev) err = regmap_update_bits(tmp108->regmap, TMP108_REG_CONF, TMP108_CONF_MODE_MASK, TMP108_MODE_CONTINUOUS); - tmp108->ready_time = jiffies + + tmp108->ready_time = get_jiffies_64() + msecs_to_jiffies(TMP108_CONVERSION_TIME_MS); return err; } -- 2.53.0