From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794064481; b=JbuA7tw3c0Lo65d3bIRV3if9zMvUzPN/hOcyG1SQnVz4hhomp4eOpDMWX7nMb4333C/J EQHjCzw/uKWcnnv34Jb4ABmd9QB6kHVyJVMlYRR5pPRphu2PU4GQICQU5ew15W0L41mdw ZFpL5zmsC3vQvouzVjEg6NM4oUfiZLpdFX9hOP+NjY4jhek3hRjZ47vNKtKG6vbuzoQWI X2SHMnzRIOW6HC4ehy32R3Rp8v0GGoYJ2emTrWUNjHk1TtHCTZOWwlTEpCi+mhsSgeNJ1 3Zu5/u4WK0YMJI3v8REoBcE9GDtm2JcyuEbI44aPiVZPXps0ela2cZUQqrxTrEtI9Zw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794064481; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=gcR/vsX/QD5Q3kj/Dy2s7NdBhas9IIHikzKQJXJdWp4=; b=uiRG7z6fUjS9apll58KUHiA8pOv8I2c4FKhYZ03r4nnGBT7Z3UKr1Do5NtaWjO7Yp3u9 bsA6WCQh6KC7AViE/PP/pCuk+ldjiLDkos6hlTGMcuz42zHGrh0i0Xm4DbwxD38VCLodh 9oGh7UvWeClRmcQj30D9TW9/2og/YBYvOzlBYy8GhZEPILzs8B9JcHcuNCEyB+13rVLzX /TfSVmtd0qvD9kiejNDge3qeimqW6ChfXudjLuvNkkTzyRE5Whp1s0B30ZKJw2k9diZWA FR5ERTW31BThde2/WI5bNMseu+UZmVUwlwivaNWpKLjojinaHz1YNBiUtJzDgXTkKNQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=JQmt5hbS; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C31CE606A9F0; Sat, 7 Nov 2026 15:14:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=JQmt5hbS Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DB9D1F008A2; Sat, 7 Nov 2026 15:14:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794064480; bh=gcR/vsX/QD5Q3kj/Dy2s7NdBhas9IIHikzKQJXJdWp4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=JQmt5hbSOnBuMz7tYAgLGtYvexbuvjxhrTZea4z/wJvP+weKj9IYs1BcUS/D2zHUu grvHawkggclL/tUp5PLhNb62nbBw5DPjdOoB4nlYyZqZ3gj87I5tYYxPup1KNqpsSq shIHxZ1CDP6oJ4OYjxBlcmRZe9P0j1MWvWwvHQzg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ackerley Tng , Andrew Morton , Muchun Song , Joshua Hahn , Alex Shi , David Hildenbrand , David Rientjes , Dongliang Mu , Frank van der Linden , Hongxiang Lou , James Houghton , Johannes Weiner , Jonathan Corbet , "Liam R. Howlett" , Lorenzo Stoakes , Ma Wupeng , Miaohe Lin , Michal Hocko , Mike Rapoport , Nhat Pham , Oscar Salvador , Peter Xu , Roman Gushchin , Shakeel Butt , Suren Baghdasaryan , Vishal Annapurve , Vlastimil Babka , Yanteng Si , Sasha Levin Subject: [PATCH 7.3 0519/1257] mm: hugetlb: drop refcount before freeing on memcg charge failure Date: Sat, 7 Nov 2026 08:46:55 -0500 Message-ID: <20261107134953.764677109@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134939.434104957@linuxfoundation.org> References: <20261107134939.434104957@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ackerley Tng [ Upstream commit e95d29c5df84f19881cd30b491fc81aa98f44b45 ] When mem_cgroup_charge_hugetlb(folio, gfp) returns -ENOMEM, the folio has its refcount set to 1 via folio_ref_unfreeze(folio, 1). The error path calls free_huge_folio(folio) directly, which expects a refcount of 0. Hence, VM_BUG_ON_FOLIO(folio_ref_count(folio), folio) is triggered. Even with CONFIG_DEBUG_VM disabled, returning a folio with refcount 1 to the freelist can corrupt allocator state later. Use folio_put(folio) instead of free_huge_folio(folio) to properly drop the reference before freeing it. Link: https://lore.kernel.org/20260909-hugetlb-alloc-folio-memcg-charge-error-handling-v2-2-4b4a8a19a7f7@google.com Fixes: 991135774c0e ("memcg/hugetlb: introduce mem_cgroup_charge_hugetlb") Signed-off-by: Ackerley Tng Signed-off-by: Andrew Morton Reviewed-by: Muchun Song Reviewed-by: Joshua Hahn Cc: Alex Shi Cc: David Hildenbrand Cc: David Rientjes Cc: Dongliang Mu Cc: Frank van der Linden Cc: Hongxiang Lou Cc: James Houghton Cc: Johannes Weiner Cc: Jonathan Corbet Cc: Liam R. Howlett Cc: Lorenzo Stoakes Cc: Ma Wupeng Cc: Miaohe Lin Cc: Michal Hocko Cc: Mike Rapoport Cc: Nhat Pham Cc: Oscar Salvador Cc: Peter Xu Cc: Roman Gushchin Cc: Shakeel Butt Cc: Suren Baghdasaryan Cc: Vishal Annapurve Cc: Vlastimil Babka Cc: Yanteng Si Cc: Signed-off-by: Sasha Levin --- mm/hugetlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 7a8f605881d86..930e40ac77077 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -2900,7 +2900,7 @@ struct folio *hugetlb_alloc_folio(struct hstate *h, lruvec_stat_mod_folio(folio, NR_HUGETLB, nr_pages); if (ret == -ENOMEM) { - free_huge_folio(folio); + folio_put(folio); /* * Skip uncharging hugetlb_cgroup since the charges * were committed to the folio and freeing the folio -- 2.53.0