From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794064482; b=22q2AKrGK55/XqDEPiKbgICie1c7buCQ6MGOY1uq5SuGruZzc7HaUyo/B385BqUguMwU 6dlHecF8J++Op4ka0VoioXDb0sx5cdD1xBcJ3heU3Ndel8NqOMXUy35Ib5uhmFjQx9wrB /8meY5inhm/JPVnOlh2TtvoSJwA8oOtBcRLFqXxml/uqYjiAbVv1623qat2bw77uyUtnO MJo4L/C9B7AuVI8oIYimzihcFG86Uyc47UeIYOL5oDfWWerikbOgqOfooXzAgi5ODgPGm MJJ5CvvQmhY1Zo3eaiBmEILMBuKyzggp6KmRL29N7VcXM7w/+1MIR2JWdM1kCELqVQw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794064482; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=9XqxGSQZNUxOIjm5x1dWA4MtULR08b4s9L880YKIZpA=; b=1YHJBz7GrVLatt7werr+Xt9g8xzKfrRC4tO520H0uHrFY7CHdi+QhMl4NNDFcTMRizW9 oiWyHAHChN8BRciAGL3Mij9DoKq/iS7Ji4v4w+xy/59QaLgtto+G68oDzFsywew8t7IvI BUm1OZXvtTWDdwkSNWN5aV7WI3bjUH5vqE4sOyyOJY6mrMjSLGva/Wuu5fCO83UtTcSa5 y5hmYqtCsmyEm8ZymByzDWUFY+qRZMPH4w2uNwcPPzjJjOwzjb0Px2x1emRqQlvFGj/Mu tcBjzKcTfLleOKc/z95iPSkH1QG5NCmpBUi616pMtSE0vLp0uBe2Rr46BtDjn0MPvsA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=SkHezP+U; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE806606A9F0; Sat, 7 Nov 2026 15:14:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=SkHezP+U Received: by smtp.kernel.org (Postfix) with ESMTPSA id A112E1F008A2; Sat, 7 Nov 2026 15:14:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794064481; bh=9XqxGSQZNUxOIjm5x1dWA4MtULR08b4s9L880YKIZpA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=SkHezP+UN5OFaoxui/w/O1d+AwUY2EvopYko+w0nuxWverMXFlKhoULoaE0kgFdLq PzJStMa9mgKUIPtkEyXIltdkb9c8w3xMrAUFHmyDMqH7+CLYgpuG0hf3Pat0zTjPTf ZnMnthGgByzrBmu/cQMe0xcRxcVqdFdI3Ek2ZULk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, DAI RENJIE , Andrew Morton , Bradley Morgan , Mark Brown , Kees Cook , Bjorn Helgaas , Sasha Levin Subject: [PATCH 7.3 0520/1257] resource: fix lost wakeup when waiting for a muxed region Date: Sat, 7 Nov 2026 08:46:56 -0500 Message-ID: <20261107134953.791540444@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134939.434104957@linuxfoundation.org> References: <20261107134939.434104957@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: DAI RENJIE [ Upstream commit 405c00e43a9c72a0b9b318cc2d2e298386ffb58e ] A task waiting for a muxed region can sleep forever in TASK_UNINTERRUPTIBLE even though the region it waits for is already free. __request_region_locked() queues itself on muxed_resource_wait and drops resource_lock before setting TASK_UNINTERRUPTIBLE, while __release_region() wakes the queue after dropping the same lock. A wakeup landing in between finds TASK_RUNNING, does not match TASK_NORMAL and is discarded; callers hold a muxed region only across a bounded transaction, so no further release is coming. The task is unkillable and its caller never returns. The window is one store wide, but an interrupt is enough to hold the waiter in it, and the machine this was seen on runs PREEMPT_DYNAMIC in its voluntary default. Since v6.11 spd5118 exports the DDR5 sensors of AMD boards through i2c-piix4, which takes a muxed region per SMBus transaction; a third of the in-tree users of request_muxed_region() are hwmon drivers, so reading a world-readable attribute is all an unprivileged user needs to drive the contention. The blocked task sleeps holding the i2c adapter bus lock, and 27 more piled up behind it. Reproduced by building a kernel with the two orderings selectable at runtime and a 2ms delay inside the window. Switching only that knob, a two-thread barriered reproducer loses the wakeup 200 times out of 200 before the fix and 0 out of 200 after it; without the delay it goes 20000 times through the wait path and loses none. Fix it by setting the task state before dropping resource_lock, as prepare_to_wait() does: the releasing side needs resource_lock to unlink the resource, so it cannot reach the wakeup before the state is published. Link: https://lore.kernel.org/20260821-b4-resource-muxed-lost-wakeup-v1-1-37eb6473a76c@gmail.com Fixes: 8b6d043b7ee2 ("resource: shared I/O region support") Signed-off-by: DAI RENJIE Signed-off-by: Andrew Morton Reviewed-by: Bradley Morgan Reviewed-by: Andrew Morton Assisted-by: Claude:claude-opus-5 Cc: Mark Brown Cc: Kees Cook Cc: Bjorn Helgaas Cc: Signed-off-by: Sasha Levin --- kernel/resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/resource.c b/kernel/resource.c index 08bd7579cf403..a98fd2b29ceac 100644 --- a/kernel/resource.c +++ b/kernel/resource.c @@ -1350,8 +1350,8 @@ static int __request_region_locked(struct resource *res, struct resource *parent } if (conflict->flags & flags & IORESOURCE_MUXED) { add_wait_queue(&muxed_resource_wait, &wait); - write_unlock(&resource_lock); set_current_state(TASK_UNINTERRUPTIBLE); + write_unlock(&resource_lock); schedule(); remove_wait_queue(&muxed_resource_wait, &wait); write_lock(&resource_lock); -- 2.53.0