From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794064548; b=LJDtpjAb+wUcgwsUR5pFgwy24tY9oJlpcFlMal6zrk1R7SYOo9uQGP5ZMyZM0KuOrSn/ GomfKA2IRxj6KJZ1dfLFl8YPGCgp9K7BaH9MCjJzzxAVDNj5pv+JrpBrwOy0dyiBHUz8s Jov7i+ndcRuhIPun+s8XTfi8xpEHJcY5LkPcp8WNCJzi/sPDPF64IhNHcDDyCBcusBBAw eeozcJZBS5Mx4+x6ytYuJaJnzZWjjf6mdqeKK6/riiG7ACMxa7S2CcAM8ycDmWVDyiQcp 3YLs1Y3nBvz5W2l3bvYAKzeVJ90QAmm5iy9ODJcqPAj7+RjpoCR0C1c+Au/Z5g6Lg9g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794064548; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=Nus3TZgKp4mJl8QUhGwn6iS+/fqVGYgL0KYRVx578yw=; b=s7WTsN68EsrVwNSjaTGqEaOcEyL7FViRz7mVMXtNxVzqK0KHolkcD0N+NaGLdfziBZSk b2jVq293d6z7JREyDWosdB03h1hWd5g5HYxkPmDKC2rrTLduulFaD7xhwuRKHeNWUc8ob peWVnVQd8MNNMmkh8QDzg8iCMu6fumussXfXqKVGTdeTCljpxkYwUTKHEMF1LKSgfmczY hqCjftY5INXwH1rnHDtvZ+6V51JFqeS/4JuB5LP5jHhObSYYXOgQnHbQ3R6RFgbMA/lYB 33jKgpPyDnlIqa4B3FmuDdYhVPSrBv+1t2NRm+ikBoI8dLw/ccsrwslA7KBe2ptY6lQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="QnE8/lAo"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF384606CE78; Sat, 7 Nov 2026 15:15:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=QnE8/lAo Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7345F1F0089F; Sat, 7 Nov 2026 15:15:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794064547; bh=Nus3TZgKp4mJl8QUhGwn6iS+/fqVGYgL0KYRVx578yw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=QnE8/lAodiD69D2lQKMQfWXpIh0KFPy+rWgF/vo8X+SwXR/w6cx4aacx/kPa5UrMJ v28gP3DRpO6an/VFKGJobA/IVIS+DW/yIhMVjrpZ0Ps8BuFTWGI2bxnc99K+JupyiQ qe9Ldpy/LGSgK8P9FHnZA9psJkVz4PiaTJAnHzOk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Luxiao Xu , Ren Wei , Andrew Morton , Vega , David Hildenbrand , Grazvydas Ignotas , "Liam R. Howlett" , Lorenzo Stoakes , Michal Hocko , Mike Rapoport , Suren Baghdasaryan , Vlastimil Babka , Sasha Levin Subject: [PATCH 7.3 0572/1257] mm/memory: constrain generic_access_phys() to page boundary Date: Sat, 7 Nov 2026 08:47:48 -0500 Message-ID: <20261107134955.149803606@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134939.434104957@linuxfoundation.org> References: <20261107134939.434104957@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Luxiao Xu [ Upstream commit ae0298a5fbeff32951c0d31398ccec97ec6aa0ea ] This patch addresses an issue in generic_access_phys() where accessing memory across page boundaries in PFNMAP VMAs assumes physical pages are contiguous, which can lead to accessing unintended physical memory or exceeding VMA boundaries. generic_access_phys() improperly validates the memory access range: it only validates the start address using follow_pfnmap_start() and passes PAGE_ALIGN(len + offset) to ioremap_prot(). This poses two problems: 1. In PFNMAP VMAs, consecutive virtual pages are not guaranteed to be physically contiguous, and individual PTEs may have different access permissions or writability. 2. The mapping may cross VMA boundaries if len extends beyond vma->vm_end. Constrain the access in generic_access_phys() to at most the current page boundary (PAGE_SIZE - offset) and map only a single PAGE_SIZE via ioremap_prot(). Since the caller __access_remote_vm() already loops over the requested length and handles partial transfers, it will naturally iterate over the remaining pages. Also add a missing (resource_size_t) cast during PFN re-validation to avoid truncation on 32-bit PAE systems. Link: https://lore.kernel.org/e06e28a46c2a176238f03b5740df0913e57c2861.1788842306.git.rakukuip@gmail.com Fixes: 9cb12d7b4cca ("mm/memory.c: actually remap enough memory") Signed-off-by: Luxiao Xu Signed-off-by: Ren Wei Signed-off-by: Andrew Morton Reported-by: Vega Suggested-by: David Hildenbrand Acked-by: David Hildenbrand (Arm) Assisted-by: LLM Cc: Grazvydas Ignotas Cc: Liam R. Howlett Cc: Lorenzo Stoakes Cc: Michal Hocko Cc: Mike Rapoport Cc: Suren Baghdasaryan Cc: Vlastimil Babka Cc: Signed-off-by: Sasha Levin --- mm/memory.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index 8b0c2c735d3de..4f8199de44afb 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -7164,6 +7164,12 @@ int generic_access_phys(struct vm_area_struct *vma, unsigned long addr, bool writable; struct follow_pfnmap_args args = { .vma = vma, .address = addr }; + /* + * Limit access to one page at a time, as that's what follow_pfnmap_start() + * guarantees; expect the caller to retry to read larger ranges. + */ + len = min_t(int, len, PAGE_SIZE - offset); + retry: if (follow_pfnmap_start(&args)) return -EINVAL; @@ -7175,7 +7181,7 @@ int generic_access_phys(struct vm_area_struct *vma, unsigned long addr, if ((write & FOLL_WRITE) && !writable) return -EINVAL; - maddr = ioremap_prot(phys_addr, PAGE_ALIGN(len + offset), prot); + maddr = ioremap_prot(phys_addr, PAGE_SIZE, prot); if (!maddr) return -ENOMEM; @@ -7183,7 +7189,7 @@ int generic_access_phys(struct vm_area_struct *vma, unsigned long addr, goto out_unmap; if ((pgprot_val(prot) != pgprot_val(args.pgprot)) || - (phys_addr != (args.pfn << PAGE_SHIFT)) || + (phys_addr != ((resource_size_t)args.pfn << PAGE_SHIFT)) || (writable != args.writable)) { follow_pfnmap_end(&args); iounmap(maddr); -- 2.53.0