From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794064653; b=kIxwOIyFzy00cXGDRbV2g9xOR/bVHXjh/69mDzr0Gc/dQc2LCPQnLEgk86LULFrsMg0L sb1aOWOGJ+U/ow4vaX15ZWNIGDKNKRvJNlHyFP6jgqRkcD/tLbwlus9Tc4I6CRLrHukuG QJWoS+kzs1LsphPuIH+a3qpyoKZszQo8Gwu5oVLA4Y3hLujfIMOsqFcHKlS0gDbMflX1k Uw14LrN3eWWU8N8tDa2W4VKvo8kwJc2HSXzHMGUERJ911/WUjrEa6XILm3DeP7l6HFI48 KcHXImGP+KnmANY/x7FAzecy8w5XOErFKlSZ8egSnTHVJdbCDic96TQ/L1flkw/d4Mg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794064653; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=tbh94dQKivEgT1iqRIpxwsWx47qUMwwYOW7wdGibmKg=; b=w67MEYEi+LpQn/SbYFZ/C9qYBP2P84lJ4RrxCig063IKutO8bd5rZgm9QccHCRKJ8xZf 3+jD0D5NBHqMHRysbSe9djy2ves/xl9UAAuetObjNSGoYsIr+naYiW6jDE0dQQ2gJ+/SL GM81p6FZZwf6PTyMOmz08fhejdaoLTJemBXrwniqNGFILJqx7ukFOdPgYy2Z2cYxAs2ih ctm1CiYUIjcrRzgzAdA7esUqT7g5jiQUQA6vTkQef7BppOBgHtATGvkxqQokATohVrmAn QcEkoDKWeQTg3OIxsqvfTFXQncDKbC7uHqd+aJ4g49ED1TopNuvK5yXHmkBDDlrmqqQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="nF9hU//X"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 607C3606C038; Sat, 7 Nov 2026 15:17:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=nF9hU//X Received: by smtp.kernel.org (Postfix) with ESMTPSA id C517E1F008A3; Sat, 7 Nov 2026 15:17:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794064653; bh=tbh94dQKivEgT1iqRIpxwsWx47qUMwwYOW7wdGibmKg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=nF9hU//XLH1TEEQUJdGyubWl/7z5t+i8sn2jPvu9BB91n8IJXO1q3XBi+OfnK0FPt NTXcxk+79fVly/aDJMMQ881Y2jWxUf5Q7gPkI7ETzE1JEeUlUNnLZJrpuDhsnA4vlm VB6KSa2jz5r19G8TNqdaIWhq/E77VEAnndLX/u2w= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, SJ Park , Andrew Morton , Brendan Higgins , David Gow , Usama Arif , Sasha Levin Subject: [PATCH 7.3 0654/1257] mm/damon/core-kunit: extend damos_commit_filter_for() for wrong input Date: Sat, 7 Nov 2026 08:49:10 -0500 Message-ID: <20261107134957.327915846@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134939.434104957@linuxfoundation.org> References: <20261107134939.434104957@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: SJ Park [ Upstream commit a1c7fdaf165755fff928a6c25b69d7e0966b6910 ] damos_commit_filter_for() supposes damos_commit_filter() to always succeed with given inputs. damos_commit_filter() could return an error for invalid inputs. Existing callers always pass only valid inputs, but they may pass invalid inputs in future, for test purposes. Extend the function to be able to be used for wrong inputs-caused error testing. Link: https://lore.kernel.org/20260914142327.92510-8-sj@kernel.org Signed-off-by: SJ Park Signed-off-by: Andrew Morton Cc: Brendan Higgins Cc: David Gow Cc: Usama Arif Cc: Signed-off-by: Sasha Levin --- mm/damon/tests/core-kunit.h | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h index 65443aba03300..0d09a081cd84a 100644 --- a/mm/damon/tests/core-kunit.h +++ b/mm/damon/tests/core-kunit.h @@ -1062,9 +1062,15 @@ static void damos_test_commit_dests(struct kunit *test) } static void damos_test_commit_filter_for(struct kunit *test, - struct damos_filter *dst, struct damos_filter *src) + struct damos_filter *dst, struct damos_filter *src, + bool expect_fail) { - damos_commit_filter(dst, src); + int err; + + err = damos_commit_filter(dst, src); + KUNIT_EXPECT_EQ(test, err != 0, expect_fail); + if (expect_fail) + return; KUNIT_EXPECT_EQ(test, dst->type, src->type); KUNIT_EXPECT_EQ(test, dst->matching, src->matching); KUNIT_EXPECT_EQ(test, dst->allow, src->allow); @@ -1103,47 +1109,47 @@ static void damos_test_commit_filter(struct kunit *test) .type = DAMOS_FILTER_TYPE_ANON, .matching = true, .allow = true, - }); + }, false); damos_test_commit_filter_for(test, &dst, &(struct damos_filter){ .type = DAMOS_FILTER_TYPE_MEMCG, .matching = false, .allow = false, .memcg_id = 123, - }); + }, false); damos_test_commit_filter_for(test, &dst, &(struct damos_filter){ .type = DAMOS_FILTER_TYPE_YOUNG, .matching = true, .allow = true, - }); + }, false); damos_test_commit_filter_for(test, &dst, &(struct damos_filter){ .type = DAMOS_FILTER_TYPE_HUGEPAGE_SIZE, .matching = false, .allow = false, .sz_range = {.min = 234, .max = 345}, - }); + }, false); damos_test_commit_filter_for(test, &dst, &(struct damos_filter){ .type = DAMOS_FILTER_TYPE_UNMAPPED, .matching = true, .allow = true, - }); + }, false); damos_test_commit_filter_for(test, &dst, &(struct damos_filter){ .type = DAMOS_FILTER_TYPE_ADDR, .matching = false, .allow = false, .addr_range = {.start = 456, .end = 567}, - }); + }, false); damos_test_commit_filter_for(test, &dst, &(struct damos_filter){ .type = DAMOS_FILTER_TYPE_TARGET, .matching = true, .allow = true, .target_idx = 6, - }); + }, false); } static void damos_test_help_initailize_scheme(struct damos *scheme) -- 2.53.0