From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794064736; b=CD6/EeYnZQvhmXkzAo4AgqEJ0kJygAg+aZiH00D86FuBG2GOgf51lz9B88z4WNECaoIw 6DUv10y4PnBkvWTznnkGZwuTdLLt+ofO86IbOuyZ5/U5I7TvQvaLvwZDVHY2pG536ETTl 5Yh3xAleUb48Cr868GTs63qK6vrYs/3XIFurLowljJsOvKCX0+69hgd902hAVuHSfy1hk WRRZGWkVidnyjdOl1HaSyCiwF2tXF22/G++BIFc54ZSwVR5Uh9Vsm4UDe9z84p6Oc2jEd yfPZvpIsx6E8Sp4hzQz0vYyl53Qr1L5RpGsNl2dUjNds8CatbAmJLnuK197wJZj/r9Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794064736; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=7/6DGp8L1y8ORheRMN29T4knnYgjzzGk8wVrlcFfQGM=; b=SsAK0H/jA+OOUEIxmwMsKfznVZ2ybFKA3PAe6bNrPU2SRoOnrIGNTs4+RmhmWucwDTuD UDO0u98XGQi54TWRN3qoI2VbxctHMiLvBt4NCurbsbjmmR9+Ng2sQj4iPtqGkYYrc6UIM ZZxCnpQGEFDNUmOPwa5zsYIacaTttywwyNBvPlx11XjACvJ/1vT/Ubr+iR2fKZExQJFr6 Dc+CTQ7vDwSmid0fnU5R0Xb96OOxohd7aHicGYASRO01NDUi2HswVWSVsmmF40XXYJ7xb ETPFAfyjd+KlMBW0Sm1natw3ucBVzRxBjq5XDGeZTfvpKwwCZbAcTPRozyPdy7Gn0VQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=SoIq0bif; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50D76606A9C9; Sat, 7 Nov 2026 15:18:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=SoIq0bif Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC7361F008A2; Sat, 7 Nov 2026 15:18:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794064736; bh=7/6DGp8L1y8ORheRMN29T4knnYgjzzGk8wVrlcFfQGM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=SoIq0bifPSPUuElidQFjBm9czN6JEyzj+f5/MHBNljr+dnDQGx/cbvF5RzBJzucqU qygObhhF0dcNyAHdykB+3IflCapsajnyzy8iF7IN8uNFvzZ2vWsVVL8HP/mlORUPJa Ef7Yqfl6h7C12Tx6MYCxg+sI2QQKMbJak8LFmimI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Muhammad Bilal , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sasha Levin Subject: [PATCH 7.3 0673/1257] platform/x86: hp-wmi: fix heap OOB read and memory corruption in hp_wmi_perform_query() Date: Sat, 7 Nov 2026 08:49:29 -0500 Message-ID: <20261107134957.844846117@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134939.434104957@linuxfoundation.org> References: <20261107134939.434104957@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Muhammad Bilal [ Upstream commit 6dea092b261f04d632411c2be52d13190f5f67b1 ] hp_wmi_perform_query() evaluates an ACPI WMI method and expects a struct bios_return header in the returned buffer. However, it only checks that the ACPI object type is ACPI_TYPE_BUFFER without verifying that obj->buffer.length is at least sizeof(*bios_return) (8 bytes). If the firmware or ACPI method returns a buffer shorter than 8 bytes: 1. bios_return->return_code at offset 4 reads out of bounds from the allocated ACPI buffer slab. 2. If return_code evaluates to 0 and outsize is non-zero, (int)(obj->buffer.length - sizeof(*bios_return)) evaluates to a negative integer (e.g. -8 for a 0-length buffer). actual_outsize is set to this negative value and passed to memcpy(buffer, ..., actual_outsize), where the signed negative value is cast to size_t (e.g. 0xfffffffffffffff8), attempting to copy ~18 Exabytes and triggering an immediate kernel crash. Additionally, memset(buffer + actual_outsize, ...) performs an out-of-bounds write before buffer. Fix this by ensuring obj->buffer.length is at least sizeof(*bios_return) before accessing the return code, and compute actual_outsize safely using min_t(u32, ...), which is sound specifically because the guard above already rules out obj->buffer.length being smaller than sizeof(*bios_return) by the time that subtraction runs. Fixes: c3021ea1beee ("hp-wmi: allow setting input and output buffer sizes separately") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal Link: https://patch.msgid.link/20260826103012.240453-1-meatuni001@gmail.com Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen Signed-off-by: Sasha Levin --- drivers/platform/x86/hp/hp-wmi.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c index 615b4cf6fc451..8a0fe50ef0c29 100644 --- a/drivers/platform/x86/hp/hp-wmi.c +++ b/drivers/platform/x86/hp/hp-wmi.c @@ -691,8 +691,9 @@ static int hp_wmi_perform_query(int query, enum hp_wmi_command command, goto out_free; } - if (obj->type != ACPI_TYPE_BUFFER) { - pr_warn("query 0x%x returned an invalid object 0x%x\n", query, ret); + if (obj->type != ACPI_TYPE_BUFFER || + obj->buffer.length < sizeof(*bios_return)) { + pr_warn("query 0x%x returned wrong type or too small buffer\n", query); ret = -EINVAL; goto out_free; } @@ -711,7 +712,7 @@ static int hp_wmi_perform_query(int query, enum hp_wmi_command command, if (!outsize) goto out_free; - actual_outsize = min(outsize, (int)(obj->buffer.length - sizeof(*bios_return))); + actual_outsize = min_t(u32, outsize, obj->buffer.length - sizeof(*bios_return)); memcpy(buffer, obj->buffer.pointer + sizeof(*bios_return), actual_outsize); memset(buffer + actual_outsize, 0, outsize - actual_outsize); -- 2.53.0