From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794060578; b=HW8+9IoaQyne3QCPWjBCFn9kqodg53WbpDRCiAKEWUvsSqRfF9y7wKl6uEKQU27vDvgy rdD4CMu+9/l/Q2wUflh4n7SnxcbC1a0ldjluwAwiGnapDluU4BFVC8Flfq5Z/Wgb5BoZE prZZLo7tbbfhQo/mMZjKEl++DuH2qYsNeGeaPUPcUe+f89wlNKh2w5fd7bPi84xi7TJfy cxIzNcKWUsOfFwzBMpmafIcXyF2nr3ve4CKf3aA4d/xHRBsQCzgXJEkOhQNAwApWUtK8S hGTOH9f82rD2UERr6rLJRxuJYuRtsqNUSOX5IipiruMwAFI2yBJPD/81VPDHAUgCX3g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794060578; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=1QiqDcyBPmhxGUYG7TbMckKoDsM/3D7ESXteQXy0Ae0=; b=Krx1VQ+qzj4UgdndOHX/qk5WYPvXzY3RFTDEoq+4sZle5hkQL7cEfVdGLd/7e0+TWBS8 DtSwddDjsaJbzqRJ20dBczeZ5466m+VH143/rjcSSMuN8sDrvxzsZhRmWjiMZEvcRFpzM 4IWS+lN2fYVWlcvT+qGbtqJmN/6iMCn3muLGuxJrRb+UhVhcxIFpX+yGRs3HbnIZbtX0g 6TOgdNafyWE/jvojv9R7GOwNZCTcIDKBaPhnHJklmyzXIsSnGwBzlx5SHe61m9zrNivMj DoBxxuhxKUmrRdTquptlkNwqD65QdvyK+YdR/ZLAh5zH5LbV2mktCfNTZkyXZMms0uQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Gpl2iFL8; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BE03606A326; Sat, 7 Nov 2026 14:09:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Gpl2iFL8 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 454F91F008A1; Sat, 7 Nov 2026 14:09:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794060578; bh=1QiqDcyBPmhxGUYG7TbMckKoDsM/3D7ESXteQXy0Ae0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Gpl2iFL8NXLQ7KmLw5udE0bnm1Fimk+LrANnsdAEKspiEiLFXq7bBZtZmVnv9ZiSA utpGroUcmI5WJbTErOhOyO2q9G0up0+chnYo4pvy1vQbvdeOqkt5NdXJYIznntfUvW d6aITz77fI2B1J48acbCHishDXv+Mg/6oVXCxBas= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, SJ Park , Andrew Morton , Sasha Levin Subject: [PATCH 6.12 0010/1536] mm/damon/core: error damos_commit_quota_goal() for zero target_value Date: Sat, 7 Nov 2026 08:33:46 -0500 Message-ID: <20261107134957.961610507@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134957.653319350@linuxfoundation.org> References: <20261107134957.653319350@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: SJ Park commit 610c4438fb66e06d9e693c0ad3b2c1be54c0d61f upstream. Patch series "mm/damon: move zero damos quota target_value handling to the core layer". Having zero DAMOS quota target value can cause division by zero. DAMON API callers are checking the target value parameters to avoid that. It is easy to make mistakes in some of the multiple API callers. Move that to the core layer. Patch 1 adds the corner case handling into the core layer DAMON parameters validation logic. Patches 2 and 3 remove no more needed DAMON API callers side handling of the corner case in DAMON_LRU_SORT and DMON_SAMPLIE_MTIER, respectively. This patch (of 3): If a DAMOS scheme has a damos_quota_goal of zero target_value, damos_quota_goal() could trigger division-by-zero error. Hence each DAMON API callers should do the zero target_value validation. It is easy to make mistakes. Actually such bugs in DAMON_LRU_SORT and DAMON_SAMPLE_MTIER were found and fixed [1]. It is better to handle the corner case only once in the core layer, instead of multiple places in all DAMON API callers. One straightforward option is using an alternative denominator for the corner case in the damos_quota_goal(). However, the zero target_value is meaningless. In this case, the quota goal is always evaluated as achieved or over-achieved. The quota will only keep being reduced. Simply avoid using zero target_value by adding a check in the core layer DAMOS quota goal parameters validation/commit path, damos_commit_quota_goal(). Update it to return an error in the case. Also update its caller to propagate the error. Notes for stable kernel porting. The upstream commit doesn't have Fixes: and therefore not ported to stable kernels. It turned out it fixes commit 8b549a4fd3c5 ("mm/damon/sysfs-schemes: commit damos quota goals user input to DAMOS") which was merged into v6.8. The user impact is a race condition that can result in divide-by-zero. Hence backport. Reproducing the issue requires sysfs write permission, certain DAMON ABI usages that are supposed to be uncommon, and a rare race timing, though. The issue was discovered [2] by Sashiko as a part [3] of its bug report. Also, the upstream commit on this stable kernel can fix the issue for parameters commit paths but DAMON start path. That's because DAMON start path does not invoke damon_commit_quota_goals(). To fix the path with minimum change, add a new small validation of quota goal target value before damon_start() call. [2] https://sashiko.dev/#/bug/linux-7f814c9a-986f-4103-a55a-ef9537dcf62b [3] https://lore.kernel.org/20261021005234.94107-1-sj@kernel.org Link: https://lore.kernel.org/20260903010722.94244-1-sj@kernel.org Link: https://lore.kernel.org/20260903010722.94244-2-sj@kernel.org Link: https://lore.kernel.org/20260803134034.15217-1-sj@kernel.org [1] Signed-off-by: SJ Park Signed-off-by: Andrew Morton Signed-off-by: SJ Park Signed-off-by: Sasha Levin --- mm/damon/core.c | 18 +++++++++++++----- mm/damon/sysfs.c | 19 +++++++++++++++++++ 2 files changed, 32 insertions(+), 5 deletions(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index 81d44e41de210..ed32855c16ed8 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -698,14 +698,17 @@ static struct damos_quota_goal *damos_nth_quota_goal( return NULL; } -static void damos_commit_quota_goal( +static int damos_commit_quota_goal( struct damos_quota_goal *dst, struct damos_quota_goal *src) { + if (!src->target_value) + return -EINVAL; dst->metric = src->metric; dst->target_value = src->target_value; if (dst->metric == DAMOS_QUOTA_USER_INPUT) dst->current_value = src->current_value; /* keep last_psi_total as is, since it will be updated in next cycle */ + return 0; } /** @@ -723,18 +726,23 @@ static void damos_commit_quota_goal( int damos_commit_quota_goals(struct damos_quota *dst, struct damos_quota *src) { struct damos_quota_goal *dst_goal, *next, *src_goal, *new_goal; - int i = 0, j = 0; + int i = 0, j = 0, err; damos_for_each_quota_goal_safe(dst_goal, next, dst) { src_goal = damos_nth_quota_goal(i++, src); - if (src_goal) - damos_commit_quota_goal(dst_goal, src_goal); - else + if (src_goal) { + err = damos_commit_quota_goal(dst_goal, src_goal); + if (err) + return err; + } else { damos_destroy_quota_goal(dst_goal); + } } damos_for_each_quota_goal_safe(src_goal, next, src) { if (j++ < i) continue; + if (!src_goal->target_value) + return -EINVAL; new_goal = damos_new_quota_goal( src_goal->metric, src_goal->target_value); if (!new_goal) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index 5aa23c6545cb8..ad9fa8a86c9ef 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -1497,6 +1497,20 @@ static struct damon_ctx *damon_sysfs_build_ctx( return ctx; } +static bool damon_sysfs_valid_start_ctx(struct damon_ctx *ctx) +{ + struct damos *s; + struct damos_quota_goal *g; + + damon_for_each_scheme(s, ctx) { + damos_for_each_quota_goal(g, (&s->quota)) { + if (!g->target_value) + return false; + } + } + return true; +} + static int damon_sysfs_turn_damon_on(struct damon_sysfs_kdamond *kdamond) { struct damon_ctx *ctx; @@ -1517,6 +1531,11 @@ static int damon_sysfs_turn_damon_on(struct damon_sysfs_kdamond *kdamond) ctx = damon_sysfs_build_ctx(kdamond->contexts->contexts_arr[0]); if (IS_ERR(ctx)) return PTR_ERR(ctx); + if (!damon_sysfs_valid_start_ctx(ctx)) { + damon_sysfs_destroy_targets(ctx); + damon_destroy_ctx(ctx); + return -EINVAL; + } err = damon_start(&ctx, 1, false); if (err) { damon_destroy_ctx(ctx); -- 2.53.0