From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794061126; b=UsoVxF5Bd43/KDfLw0nlVLgoi4a12FSbIWX7Y9bQQK39K/oasm8HzDJwSpWOzfXEFv03 OCOLNpNBFVRzpeoqWh/eeWOspVpUu6RochpNkzT68XXHMT9MzUCuLUOskemTRdZrtGxPs Aw5zRcQYF9kN/EqxKRppjnQ53uczTaR+3aJSuWWaJnlk6yjvFersMZWtn7s1CA0MUcyN5 l/S/t7hwFr7dJ2F/N1i07etd7fOp2pKZyU4vrffKsMtWzCn+byXWRtx01s75PZ00E24br 8ahzFJKo2EmnGIUaBLcFbMFtrArSchzdNERrbcYXelFYPHyIWjtar9r4h5NmgFUN36A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794061126; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=I19YIzlJ70h2lVMYvTDkU+hxlThlkrJclYGftfL+mIU=; b=QepyE039T6apgmv05eadgBVx5w3R+FXSMFds7CY3JrV79Gc8wiUdkfyVHGZQ5m8pXlP6 vId1x5zMkAQJ9wa8w74Ef55DqWNX7lg1Hg2rvps6ljxlAzXIrpodNd7FZbmPr0RWPubPp ADb+H+Fqa5nz3cbjS3au4K0UgiDuIBvWPs+T8P1YBDFV3HbqSy3ZWlpBZFj3sofUKNCgS 4dv0lZ/Ebl2Do6/qbaq4cUKiDy05bQdxsqbjnJ8TLW0m9jFv+hLe1S3oqagxvCxNSyAIR aFwnqxtjWUOhBNAmWsWNzptKewqtubxfhnORfIgpB+GhBoymFUblKXHzF3DWwSn8oig== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=EO20JIEw; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21CD1606A333; Sat, 7 Nov 2026 14:18:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=EO20JIEw Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4B151F0089F; Sat, 7 Nov 2026 14:18:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794061126; bh=I19YIzlJ70h2lVMYvTDkU+hxlThlkrJclYGftfL+mIU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=EO20JIEwbKHoR8N14VzEi0MC/ifNm+/C+lDIqwlB0rWLhOt6j9IdWYy4aTup1Qgvn B4aNi4PkRcvH4m09VMQTloXTmhGXyAgatKoEg5Hid1NGq7MiD7rlW6iQYupRp+cuZz 3V36cDCNnHyXE/bhr0Pj2ArVk6le5R8FYjS53vX8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xiang Mei , Hans Verkuil Subject: [PATCH 6.12 0438/1536] media: go7007: only set audio_enabled if go7007_snd_init() succeeded Date: Sat, 7 Nov 2026 08:40:54 -0500 Message-ID: <20261107135009.855863959@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134957.653319350@linuxfoundation.org> References: <20261107134957.653319350@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Xiang Mei commit 2eacf058d2dbb0ae3aaf576459da9e5f2b6bbfbd upstream. go7007_register_encoder() sets go->audio_enabled before calling go7007_snd_init() and discards its return value. go7007_snd_init() assigns go->snd_context only on success, so a failed ALSA setup leaves audio_enabled set with snd_context still NULL. The disconnect path tests audio_enabled and calls go7007_snd_remove(), which dereferences snd_context unconditionally. go7007_snd_init() returns -ENODEV once its never-decremented static card counter reaches SNDRV_CARDS, so SNDRV_CARDS attach/detach cycles arm the next attach; no memory pressure is needed. Set go->audio_enabled only once go7007_snd_init() has succeeded. Oops: general protection fault, probably for non-canonical address ... KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] Workqueue: usb_hub_wq hub_event RIP: 0010:go7007_snd_remove (drivers/media/usb/go7007/snd-go7007.c:273) Call Trace: go7007_usb_disconnect (drivers/media/usb/go7007/go7007-usb.c:1336) usb_unbind_interface (drivers/usb/core/driver.c:461) device_remove (drivers/base/dd.c:618) device_release_driver_internal (drivers/base/dd.c:1349) bus_remove_device (drivers/base/bus.c:664) device_del (drivers/base/core.c:3965) usb_disable_device (drivers/usb/core/message.c:1478) usb_disconnect hub_event (drivers/usb/core/hub.c:5966) process_one_work (kernel/workqueue.c:3396) worker_thread (kernel/workqueue.c:3560) kthread (kernel/kthread.c:436) ret_from_fork (arch/x86/kernel/process.c:158) ret_from_fork_asm (arch/x86/entry/entry_64.S:245) Kernel panic - not syncing: Fatal exception Cc: stable@vger.kernel.org Fixes: 866b8695d67e ("Staging: add the go7007 video driver") Assisted-by: LLM Signed-off-by: Xiang Mei Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/go7007/go7007-driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/drivers/media/usb/go7007/go7007-driver.c +++ b/drivers/media/usb/go7007/go7007-driver.c @@ -306,10 +306,9 @@ int go7007_register_encoder(struct go700 if (ret < 0) return ret; - if (go->board_info->flags & GO7007_BOARD_HAS_AUDIO) { + if ((go->board_info->flags & GO7007_BOARD_HAS_AUDIO) && + go7007_snd_init(go) == 0) go->audio_enabled = 1; - go7007_snd_init(go); - } return 0; } EXPORT_SYMBOL(go7007_register_encoder);