From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794061673; b=fQN7Asolhva3zyU+ycjS2fUNdpjpZu9DkACN/KaOcM/Q6WdCLuCC+dS2Lx45OIaegxCw rjIA1rp6Wj9QPCjFD4VQK9raDB8VZcQC03sA2HgQBEuvgkUtTIbG9hpYYTbkpTKmQn7n2 t+GxF18JqqS/lM21CuCM7t0hX0HkV3PLBiSqGJA/pzxElXrLNqc6wkTzp61ArQoIpclim FT+7jAzZ+JBHeK0lrYXZABh+J20UF/Z4SNmTpI5Ei+ZLr21lZw7L2w7+Gde8sk9uRnFz0 iXM+azCDFnjnwHW98tDta28lksVFM2BdTicLvZBiK1XWcFepFzlxCmfIrbgPDCmGKvQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794061673; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=zErtV+ZMqwds/Cfp+nCZ3xmxf/0JorOPmwkmuEXvyEA=; b=sx8KkofAMzhP4EQgE9pV584QsWIK7LbQq0wOZHZ/ICx7d8zhH4+QEzLu4M2ZPhqVFfH/ MYWqzKaMXhxNOYHKQZqCLoFls0LUsQuivwMdF8xUDxRNnXDeuUFUNY9ZWFbYjYoSjxiuI Yx4vV6yl9CLyqnivfirJh9UO2Wjbk8U37VtelCjwmJ5mWELVbYS5HcBTxS73TVEs0vcX2 fJcwRhPiViwqEZcdp91UraiVHkMAiHRnSDKBSoioUeIyzNT9ilG++YZza2BLtDbcNKm2x lquhjwh/9wtgKPBSllWPk8Tmen1PwKjakZl1hP6vhZW0mLyGeKTxnGf29+9QYQ7Zksw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=bQXdKtnM; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F242E606A32E; Sat, 7 Nov 2026 14:27:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=bQXdKtnM Received: by smtp.kernel.org (Postfix) with ESMTPSA id A26741F0089F; Sat, 7 Nov 2026 14:27:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794061672; bh=zErtV+ZMqwds/Cfp+nCZ3xmxf/0JorOPmwkmuEXvyEA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bQXdKtnMuHCSNzLuJNems5si9sEn8epOiF2yayInJ8l+EhKebLI5VlDPvd+1OL4k5 4FDbt7WZ03VLgrA7mGcSX/anDsnaYsAl97suzKOD7IJxrQBrptRe3XNy6gCYe1Kxtv Or4rsAuwhe5fY58ZZ4cWB5wPHAQWE4AJDa9aj+RM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Darrick J. Wong" , Christoph Hellwig , Carlos Maiolino Subject: [PATCH 6.12 0727/1536] xfs: always report inode repair setup failures Date: Sat, 7 Nov 2026 08:45:43 -0500 Message-ID: <20261107135017.921107855@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134957.653319350@linuxfoundation.org> References: <20261107134957.653319350@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Darrick J. Wong commit ce9098338a7e1a77246684242d10779fc4d4a539 upstream. LOLLM noticed that xchk_setup_inode silently discards errors being returned by xrep_setup_inode. Fix that, and fix the stub macro so that it actually "returns" a value. Cc: stable@vger.kernel.org # v6.8 Fixes: 2d295fe65776d1 ("xfs: repair inode records") Signed-off-by: Darrick J. Wong Assisted-by: LOLLM # finding obvious bugs Reviewed-by: Christoph Hellwig Signed-off-by: Carlos Maiolino Signed-off-by: Greg Kroah-Hartman --- fs/xfs/scrub/inode.c | 2 +- fs/xfs/scrub/repair.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- a/fs/xfs/scrub/inode.c +++ b/fs/xfs/scrub/inode.c @@ -190,7 +190,7 @@ xchk_setup_inode( * make repairs to the ondisk inode buffer. */ if (xchk_could_repair(sc)) - xrep_setup_inode(sc, &imap); + return xrep_setup_inode(sc, &imap); return 0; out_cancel: --- a/fs/xfs/scrub/repair.h +++ b/fs/xfs/scrub/repair.h @@ -218,7 +218,7 @@ xrep_setup_nothing( #define xrep_setup_nlinks xrep_setup_nothing #define xrep_setup_dirtree xrep_setup_nothing -#define xrep_setup_inode(sc, imap) ((void)0) +#define xrep_setup_inode(sc, imap) (0) static inline int xrep_setup_symlink(struct xfs_scrub *sc, unsigned int *x) {