From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794061774; b=c7woqNwES1iU/fURMFFD4ROuYNWzqPLrHbQDLnb7xTZZ0t4/z+XDVsi0s0HZYwGnhhbE jefTa5veWnl7EcLT8zOHWIl9U1NCt2HUbYJMHaiwz5y5becKLZIsHngW3hjMuNhPlfuPC fLKCssofN7XCuyyLV/o2E+q0d6SptHDURwHj6A5Z72I+esy683BNFdWpK6YQAVS1En1vI DWoMRMbAiQi2SVniKbm6Bd4IE1iOqxjgA4lgVb+sSw/rlb0mZDMdTTlDNc3PBDc1uaVlF uPq9Oax0zu6L8NV5F5QlFVK8xhzdEhJlAwyMWCgkVJ/FRPcBV0UZAQ9Xk/cWGc6EApQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794061774; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=63TLTRrkHUJvEf7htJtHj5bJdjTMvDa1RqcL5mwjh9U=; b=d402d1NP8C1uh3SO/2sc1D8Oz27Zaf6+1nxqObBGATiMk2IityV04agjiJT9TrNC7fbF e6ZdD2bcMaXBv7bDP4nN0cSqro+ZT4DTGdcwDzuYKRb+/xWmY2ZFwIZoraqMO1pSH/sKB Hjy9wPD1ug5W4kgNW+8cMQA7Frg6P7+qTUIr65bPc6PynrAO+IeoVbvBNKJbulr1K7Jpa EtNffW3CWEQTjQlEOnBOiTB1jf6RLAAsxU+B9zapSIvaDDPha2N1dE3OcL90xiozmVUbx SHsxLTxqKjNEByd6V3p0SrDVEijxBVev7MTFtnxPSRh/ULUpXJQ382DWIZlwUvkJkIQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=lq8TGaJQ; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45EA8606A326; Sat, 7 Nov 2026 14:29:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=lq8TGaJQ Received: by smtp.kernel.org (Postfix) with ESMTPSA id E60D41F0089F; Sat, 7 Nov 2026 14:29:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794061774; bh=63TLTRrkHUJvEf7htJtHj5bJdjTMvDa1RqcL5mwjh9U=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=lq8TGaJQMaS2SIGHNZ7L+zocikuLbSe+c/tU4Fbto8NRKYXS8BSmm6O4oTScDSOFp J2RDKHl3bcoi8na2FMzWlJkYob4+AXwOSQJQHCVETlm3rEWNqIfgEPIF+3dD1OvFq8 qDaiLalQsXCNj/QRQ8uByCEuZKkIWlsc9eOm7Lsk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Andrej Scek , Basavaraj Natikar , Jiri Kosina Subject: [PATCH 6.12 0807/1536] HID: amd_sfh: Remove unsupported motion-state field from accelerometer report Date: Sat, 7 Nov 2026 08:47:03 -0500 Message-ID: <20261107135020.211251125@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134957.653319350@linuxfoundation.org> References: <20261107134957.653319350@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Basavaraj Natikar commit 6ff86122906357687735dd379c6279e3b2fa26af upstream. The accelerometer HID report descriptor declares a trailing motion-state field (usage 0x0451), but the Sensor Fusion Hub never reports this data, so each accelerometer input report is one byte shorter than the descriptor advertises. This was previously harmless because hid-core zero-padded short reports. Since commit 0a3fe972a7cb ("HID: core: Mitigate potential OOB by removing bogus memset()") such reports are rejected instead: hid-sensor-hub 0020:1022:0001.0003: Event data for report 1 was too short (15 vs 14) As a result the accelerometer input events are dropped and screen auto-rotation stops working on AMD SFH systems. Remove the motion-state field from the accelerometer report descriptor and drop the unused in_accel_shake_detection member, so the descriptor matches the report actually provided by the hardware. Fixes: 1434f9fc0e47 ("SFH: Create HID report to Enable support of AMD sensor fusion Hub (SFH)") Reported-by: Andrej Scek Closes: https://lore.kernel.org/linux-input/CADrS85612m-Hh-G4BJmOhy-y6r3Ni3kD8_GM-2QRBeWWEEZWuA@mail.gmail.com/ Cc: stable@vger.kernel.org Signed-off-by: Basavaraj Natikar Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_desc.h | 2 -- drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_desc.h | 7 ------- 2 files changed, 9 deletions(-) --- a/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_desc.h +++ b/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_desc.h @@ -48,8 +48,6 @@ struct accel3_input_report { int in_accel_x_value; int in_accel_y_value; int in_accel_z_value; - /* include if required to support the "shake" event */ - u8 in_accel_shake_detection; } __packed; struct gyro_feature_report { --- a/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_desc.h +++ b/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_desc.h @@ -169,13 +169,6 @@ static const u8 accel3_report_descriptor 0x95, 1, /* HID report count (1) */ 0x55, 0x0E, /* HID unit exponent(0x0E) */ 0X81, 0x02, /* HID Input (Data_Arr_Abs) */ - -0x0A, 0x51, 0x04, /* HID usage sensor data motion state */ -0x15, 0, /* HID logical Min_8(0) False = Still*/ -0x25, 1, /* HID logical Min_8(1) True = In motion */ -0x75, 8, /* HID report size(8) */ -0x95, 1, /* HID report count (1) */ -0X81, 0x02, /* HID Input (Data_Arr_Abs) */ 0xC0 /* HID end collection */ };