From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794272466; b=asGbFsS8KqvhPDM07rwgLjUVEp2jJl2aVFIv4ul+ba18l/JZ8RwDbTkIZ1Jq9xZ3rsJE Vl0SYKrvyrSDstr4LXQPTKALG24Y1ibxHZVEb18LLrXgXpqqbN1+9ppzDy1t2S8m8LPEl uVTu6A3iVlo6O7Fon32+rk6mDrqI5Z4huQ3S+1Uk0kqIg4Xmo54ijIYW995ZpNcs13bLf KVcyI0xmFPed2IMfmeu6qsfKMd1NPLa6y+MZ45T8dIf6NnOW9zzunbI2ZYsfJlactktxv uVkpv0a8wi4wIuy/ULoxgjsRnzBRbp//gLdYoMg38wm46sz/53feygxiTFPVCgMhtVA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794272466; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=/9QiOAjyGL3+Ckwr3fL4zXoIyDruWG3e0qv02dJhJyQ=; b=pEtZf/wDwrc3f1qNJrbX/rtJ07oYM3uDoAJ5jypdMUJkATWcymJhSt26daateX+0YjFt z5g7TYY/OmZGq3L1I3LeFppvubPtor61NWQA0qavfD5WgrQ5jOKGZ7BdqOMwrrXG99CfX C6VsniRBdoI0KuzTjV1O13jQdGopkiTj74oibHriBQ63epfRUZbddzOiGbRnGj8Wa0uHK LxhKdVDA0/w0hStKTOOqkJxYC5aoWK+zItZZcPYY844cHX4niWl4DxoNNFYPaYVcMo+z6 sMbmHeVPRaaI18m5NdpNBD1Elt3eHrgFRq9uNCwkTzG+zo9TO4mJjQqIqcNbwWd3J9g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=cc6OG0vH; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F9E3606A32A for ; Tue, 10 Nov 2026 01:01:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=cc6OG0vH Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A8761F0089F; Tue, 10 Nov 2026 01:01:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794272466; bh=/9QiOAjyGL3+Ckwr3fL4zXoIyDruWG3e0qv02dJhJyQ=; h=From:To:Cc:Subject:Date; b=cc6OG0vHB2Kvv4NCFUZwT8dt1yo3sG4YzdETT4eCh/frEmiDOZwUFwjQZF4kQzye/ OVsnCYvLxfe9E3j1SxKXy5v5vZS6dRZi5wegYKUWTRX1MMJBj8InIMkNoPusTsGvMu qarnc3Rh863dQQKWg04NVipZqGyBxqEFmtmnWfPZHBGpl52JuyRzwdYHxdvxpjK1sl J+lpl3oRYjUhtnKxjjuszaiQrsvxoVTrQGwZSwoxPkWnedEQsjlR0amvLHNF+b4tmJ V8CeD6pdFfFoaqraXUpE2EdJ2n64DSwcoqv3mKyvRjQ6cLtTIc5l38e1DBEkWv9O9G LoOv2IK5GpIMg== From: Sasha Levin To: sven@narfation.org Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] batman-adv: tt: clear ROAM flag when re-adding a pending local client" failed to apply to 7.3-stable tree Date: Mon, 9 Nov 2026 20:01:04 -0500 Message-ID: <20261109200104-failed-7.3-cc2186d78547@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 7.3-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-7.3.y git checkout FETCH_HEAD git cherry-pick -x cc2186d7854785b30d423f5d43757b086b300e55 # git commit -s git send-email --to '' --in-reply-to '20261109200104-failed-7.3-cc2186d78547@kernel.org' --subject-prefix 'PATCH 7.3.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From cc2186d7854785b30d423f5d43757b086b300e55 Mon Sep 17 00:00:00 2001 From: Sven Eckelmann Date: Wed, 7 Oct 2026 13:02:45 +0200 Subject: [PATCH] batman-adv: tt: clear ROAM flag when re-adding a pending local client When a ROAMING_ADV is received for an announced local client, batadv_tt_local_mark_removed() sets BATADV_TT_CLIENT_ROAM, queues a DEL|ROAM change and marks the entry as BATADV_TT_CLIENT_PENDING. If the client sends a frame again before the next TTVN commit, batadv_tt_local_add_existing() only clears the PENDING flag and returns early. The ADD cancels the queued DEL, but the entry keeps the ROAM flag: * batadv_is_my_client() reports the client as not served by this node * batadv_tt_local_client_is_roaming() reroutes unicast frames for it to the node which sent the ROAMING_ADV The ROAM flag is only removed with the next frame of the client. Since BATADV_TT_CLIENT_ROAM is set together with BATADV_TT_CLIENT_PENDING, it has to be cleared also at the same time with BATADV_TT_CLIENT_PENDING when the client roamed back. Cc: stable@vger.kernel.org Fixes: 068ee6e204e1 ("batman-adv: roaming handling mechanism redesign") Signed-off-by: Sven Eckelmann --- net/batman-adv/translation-table.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index 39b61426f1680..e13c2828da475 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c @@ -894,6 +894,7 @@ static bool batadv_tt_local_add_existing(struct batadv_priv *bat_priv, bool *roamed_back) { struct batadv_tt_common_entry *common = &tt_local->common; + bool readded = false; tt_local->last_seen = jiffies; @@ -908,8 +909,7 @@ static bool batadv_tt_local_add_existing(struct batadv_priv *bat_priv, * flag can be reset like it was never enqueued */ common->flags &= ~BATADV_TT_CLIENT_PENDING; - - return true; + readded = true; } if (common->flags & BATADV_TT_CLIENT_ROAM) { @@ -926,7 +926,7 @@ static bool batadv_tt_local_add_existing(struct batadv_priv *bat_priv, } } - return false; + return readded; } /** -- 2.53.0