From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794272618; b=jdZoPdYcBlzJHnc/q41ruN1ubaSNewKOnmQ7ZuTnYaVyb30qjm3swL2unPxYh8vlM8qG VarOZWOokuBulGFD/49A/ZsIXwyNL2gzpO/UcdsLon1y7KfMumQIMAFg4D3aFHFay+dJx ePTzVfzE4ySSYx/Fi/6NqHzyPaKYXwdCwqn1xjD/iozdgj7e00Jhr94go2oOYx3LyuX12 g7mUCIT9XKgu6m86pUa+PKyXGrLgnHlxbNd3AmMHD5GMKJamYFFUIuNprbQHvgflXjrbw VpJDgWV+iAjCrGUBgIl9e3j1fi0rcmD0N2zXumSO4Oav8mBPY92DBXdP9zntk3qw+dw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794272618; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=eqXFByj95y3Z9qRiJ0YtxHMhLRhJxDaV3/GLQRkQ/Gg=; b=rjhwDcYnBtMrAUsPuYB1aNoBRSZCkf38JHdpwNGvbVkacvSG8+y0Jb7WE90ZbFyEZmap P4OZrWSaAzJWj9GJrlgR6JvwZ6H28vVhFGGJT5ePOdXsgF8D+9J7ChDr7zZXDkiNL0JaL SMhIuEDH+iJ08rtrREEcOV99FVmwyv1Mr+BdiykKlfHBYpTMx5jmz7xmvzZAL4HWWLc+e 80GKa71v4qaCLROYNL/55qfELcPXsx9QxHiPgrjgO7FVz0lrQTAT8BiMQSrgA8kBLuRsg uVRqLbKa6jGu5hjac45k5O4laanbVe4/ZKQvo+q0bpirktQilcfAkA5WaYHxYQZXuuQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=bbShw8fl; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92DD0606A321 for ; Tue, 10 Nov 2026 01:03:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=bbShw8fl Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0611D1F0089F; Tue, 10 Nov 2026 01:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794272618; bh=eqXFByj95y3Z9qRiJ0YtxHMhLRhJxDaV3/GLQRkQ/Gg=; h=From:To:Cc:Subject:Date; b=bbShw8flNldMeb2pdYO7UFKlGoApERmLI44m0Cx1txDzEJng9b6TTDr/E6mHIIth1 MvKfkQFPT7RAJjhuPaF8QuLqcmvuVN918ZPQz2W9ciWDslBxoIY8VLtmwyAPE07npK wskvHbZyHZx0tLZRVOZTR5ezY6bxOWwsakxnaRJH0R8nKxUeQ+y5mQ6HRNUEO0GN9S Bn58uvmHBZ57/Dd5SP/61Q/XXjy51HE3+RrUE9gybqEdyCBOyqU1b/7sH41lH2J/Pe vQga7g/z88zoRPOgSk2ycY+4AgocPJer5F1u/CVuRvVCrr/DPqgm33FmiR6eShXivg mbN1Xde5GR4FQ== From: Sasha Levin To: linux@roeck-us.net, sashiko-bot@kernel.org Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] hwmon: (tmp108) Fix initial conversion delay and wait until ready" failed to apply to 6.18-stable tree Date: Mon, 9 Nov 2026 20:03:36 -0500 Message-ID: <20261109200336-failed-6.18-7cd60538073e@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.18-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.18.y git checkout FETCH_HEAD git cherry-pick -x 7cd60538073e465310c94b2a2f0ea8d2f03768ef # git commit -s git send-email --to '' --in-reply-to '20261109200336-failed-6.18-7cd60538073e@kernel.org' --subject-prefix 'PATCH 6.18.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 7cd60538073e465310c94b2a2f0ea8d2f03768ef Mon Sep 17 00:00:00 2001 From: Guenter Roeck Date: Fri, 30 Oct 2026 20:02:08 -0700 Subject: [PATCH] hwmon: (tmp108) Fix initial conversion delay and wait until ready MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In tmp108_common_probe(), the driver only adds the 30 ms conversion delay (TMP108_CONVERSION_TIME_MS) to ready_time if the sensor was previously in TMP108_MODE_SHUTDOWN. However, the TMP108 hardware defaults to continuous conversion mode (TMP108_MODE_CONTINUOUS) upon power-on reset, including immediately after enabling the vcc supply regulator during probe, while the temperature register retains its power-on reset value of 0x0000 (0°C) until the first conversion completes. Because the initial mode is not shutdown, the delay is bypassed and early reads via thermal zone registration or sysfs before the first conversion finishes return an uninitialized 0°C reading. In addition, returning -EAGAIN from tmp108_read() while waiting for a conversion to complete after probe or resume can trigger an unnecessary tight retry loop in callers or fail initial reads. Unconditionally set ready_time to TMP108_CONVERSION_TIME_MS ahead in tmp108_common_probe(), track ready_time as ktime_t, and wait for the remaining conversion time in tmp108_read() using usleep_range() instead of returning -EAGAIN. Reported-by: Sashiko Fixes: 66e1c9171339 ("hwmon: Add Texas Instruments TMP108 temperature sensor driver.") Cc: stable@vger.kernel.org Signed-off-by: Guenter Roeck --- drivers/hwmon/tmp108.c | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/drivers/hwmon/tmp108.c b/drivers/hwmon/tmp108.c index 91d20a1ce1120..862b944d3e609 100644 --- a/drivers/hwmon/tmp108.c +++ b/drivers/hwmon/tmp108.c @@ -13,7 +13,7 @@ #include #include #include -#include +#include #include #include #include @@ -78,7 +78,7 @@ struct tmp108 { struct regmap *regmap; u16 orig_config; - u64 ready_time; + ktime_t ready_time; const struct tmp108_params *params; }; @@ -121,6 +121,7 @@ static int tmp108_read(struct device *dev, enum hwmon_sensor_types type, struct tmp108 *tmp108 = dev_get_drvdata(dev); unsigned int regval; int err, hyst; + s64 delay; if (type == hwmon_chip) { if (attr == hwmon_chip_update_interval) { @@ -137,12 +138,10 @@ static int tmp108_read(struct device *dev, enum hwmon_sensor_types type, switch (attr) { case hwmon_temp_input: - /* Is it too early to return a conversion ? */ - if (time_before64(get_jiffies_64(), tmp108->ready_time)) { - dev_dbg(dev, "%s: Conversion not ready yet..\n", - __func__); - return -EAGAIN; - } + /* Wait if it is too early to return a conversion */ + delay = ktime_us_delta(tmp108->ready_time, ktime_get()); + if (delay > 0) + usleep_range(delay, delay + 1000); err = regmap_read(tmp108->regmap, TMP108_REG_TEMP, ®val); if (err < 0) return err; @@ -477,11 +476,8 @@ static int tmp108_common_probe(struct device *dev, struct regmap *regmap, char * return err; } - tmp108->ready_time = get_jiffies_64(); - if ((tmp108->orig_config & TMP108_CONF_MODE_MASK) == - TMP108_MODE_SHUTDOWN) - tmp108->ready_time += - msecs_to_jiffies(TMP108_CONVERSION_TIME_MS); + tmp108->ready_time = ktime_add_ms(ktime_get(), + TMP108_CONVERSION_TIME_MS); err = devm_add_action_or_reset(dev, tmp108_restore_config, tmp108); if (err) { @@ -528,8 +524,8 @@ static int tmp108_resume(struct device *dev) err = regmap_update_bits(tmp108->regmap, TMP108_REG_CONF, TMP108_CONF_MODE_MASK, TMP108_MODE_CONTINUOUS); - tmp108->ready_time = get_jiffies_64() + - msecs_to_jiffies(TMP108_CONVERSION_TIME_MS); + tmp108->ready_time = ktime_add_ms(ktime_get(), + TMP108_CONVERSION_TIME_MS); return err; } -- 2.53.0