From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794274088; b=SxnNIZ7Ey4F6XFHoxlQjsv/b+l82MsxRk8D5xQ7dldGMdJ8PP+B/m41Rw8BjwNsQ9McV pCCRfRmSc5MYot4iX62DUwma7Qu9POmpiuSJwaT73jE84CTfwne9BanRDfT9BRMvHRxul /hOrd14OppBZvFjk6ptWyq1IaUk0KOvkpQl+V4i/Q1hPrN/c6xofICZN51CrUGviE+cFM 79TqwGnEns3+Ac4T1AZa//THagGjThKif6ZAJcKSkdR3D2ZCmuAxN/vQyWWGkEskn5UNF 6CVUk5fEv7UC94GnEw0ws2G07MKvQxYvVWTHPuk2EhmSJsEe2kusCGUxcYmB/gqfUfA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794274088; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=S9bAiQwSVXhrNWrXBTGlXJAEnYQ9EmEyVM6xKqa9LZU=; b=tmimM0IeADnyy5fA5Js1px6obA2e67iBjyPjenm8i+WKshgHaQ0WFETb6sJviSj/LHQh M3lTbNdJoyScuSAF6ZE0jD6YsNByqy1kkNDOn9Tk4IDbxt7OKMOxvBt9PRXciwZY1M4N/ IkNwT/DuY6o6bvsdLPI9NtTfctgxQEEbmjA+4OaLS7kfYrfMwa+cF6qyCJG4CwiGTgkd3 N8YpWLl7Pyo4baHUohXdVHHElZR7ffnaS5w9YDcDEsM6VCX/ogrgJGpQTTyidI6B9R2bK dRaXe3/oMP1XpqoIRAnLMLcNXReGXlErSDMtMn7ST8yNb9hMbI8wa1V7l9cZkppod0w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=QfWInbje; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8915F606A338 for ; Tue, 10 Nov 2026 01:28:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=QfWInbje Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA03C1F008A5; Tue, 10 Nov 2026 01:28:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794274088; bh=S9bAiQwSVXhrNWrXBTGlXJAEnYQ9EmEyVM6xKqa9LZU=; h=From:To:Cc:Subject:Date; b=QfWInbjeBPRoqc8co/CR6zCCPeNzOcRcqLxA65md6hSfe41FpN3QbLjC92NmTLu5Q K9bh1CkQVMx5ulG/PZy1bnfFaR2xE8TDxakrWxsV2HRzNmshgIhYrTmvgLF6ctf8rT E7FIAER3P0zPYCrq2J9Q+9Mjrww7KpVK2fIYatB2Dp48ccln7kqsqkLLBBwMrQd3zk 9MoaZ4PZRiGzRrcGmSJLOIBEmyCzht9di3Ebk/4oMT+OLrsFWMb4mL0e/PWXox7bMF JGBRA+nRs3ozD2g/1YMLL+NLIvxojytjnkwPrzWz+MRsAApqQYS3n8l+S5GTNadozN bn7DXAsKLlzww== From: Sasha Levin To: david@kernel.org, gourry@gourry.net, rppt@kernel.org, ljs@kernel.org, usama.anjum@arm.com Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] mm/userfaultfd: wake waiters when registration modes are removed" failed to apply to 5.10-stable tree Date: Mon, 9 Nov 2026 20:28:06 -0500 Message-ID: <20261109202806-failed-5.10-4eee9c389b07@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 4eee9c389b072e161549d46dcb1ae10b0222717e # git commit -s git send-email --to '' --in-reply-to '20261109202806-failed-5.10-4eee9c389b07@kernel.org' --subject-prefix 'PATCH 5.10.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 4eee9c389b072e161549d46dcb1ae10b0222717e Mon Sep 17 00:00:00 2001 From: "David Hildenbrand (Arm)" Date: Sat, 31 Oct 2026 10:39:54 +0100 Subject: [PATCH] mm/userfaultfd: wake waiters when registration modes are removed UFFDIO_REGISTER can replace MISSING or MINOR tracking without waking faults that are already queued. For example, switching an anonymous range from MISSING to WP leaves a missing-fault waiter asleep until userspace explicitly wakes it. When a registration change removes a UFFD mode, wake waiters in the affected interval after updating the VMA. The VMA is write-locked at this point, so no new faults can queue under the old modes and woken threads cannot retry until mmap_write_unlock(). Waiters for retained modes in the same interval may also wake and refault. The hang reproduces for MISSING-to-WP and MINOR-to-MISSING transitions, with both read and unread fault events. Fixes: 63b2d4174c4a ("userfaultfd: wp: add the writeprotect API to userfaultfd ioctl") Cc: stable@vger.kernel.org Reviewed-by: Gregory Price (Meta) Tested-by: Gregory Price (Meta) Signed-off-by: Gregory Price (Meta) Reviewed-by: Mike Rapoport (Microsoft) Reviewed-by: Lorenzo Stoakes (ARM) Tested-by: Muhammad Usama Anjum Link: https://patch.msgid.link/20261031-fixes_core-v3-25-d6437171ecc3@kernel.org Signed-off-by: David Hildenbrand (Arm) --- mm/userfaultfd.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c index be630674fda9b..03f1b15bfe63e 100644 --- a/mm/userfaultfd.c +++ b/mm/userfaultfd.c @@ -2270,6 +2270,9 @@ static struct vm_area_struct *userfaultfd_clear_vma(struct vma_iterator *vmi, return ret; } +static void wake_userfault_range(struct userfaultfd_ctx *ctx, + unsigned long start, unsigned long end); + /* Assumes mmap write lock taken, and mm_struct pinned. */ static int userfaultfd_register_range(struct userfaultfd_ctx *ctx, struct vm_area_struct *vma, @@ -2287,6 +2290,8 @@ static int userfaultfd_register_range(struct userfaultfd_ctx *ctx, prev = vma; for_each_vma_range(vmi, vma, end) { + const bool any_mode_removed = vma->vm_flags & __VM_UFFD_FLAGS & ~vm_flags; + cond_resched(); VM_WARN_ON_ONCE(!vma_can_userfault(vma, vm_flags, wp_async)); @@ -2332,6 +2337,10 @@ static int userfaultfd_register_range(struct userfaultfd_ctx *ctx, */ userfaultfd_set_ctx(vma, ctx, vm_flags); + /* Retry faults for removed modes while the VMA is write-locked. */ + if (any_mode_removed) + wake_userfault_range(ctx, start, vma_end); + if (vma_is_hugetlb(vma) && uffd_disable_huge_pmd_share(vma)) hugetlb_unshare_all_pmds(vma); @@ -3648,6 +3657,17 @@ static __always_inline void wake_userfault(struct userfaultfd_ctx *ctx, __wake_userfault(ctx, range); } +static void wake_userfault_range(struct userfaultfd_ctx *ctx, + unsigned long start, unsigned long end) +{ + struct userfaultfd_wake_range range = { + .start = start, + .len = end - start, + }; + + wake_userfault(ctx, &range); +} + static __always_inline int validate_unaligned_range( struct mm_struct *mm, __u64 start, __u64 len) { -- 2.53.0