From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794274156; b=wmnE2xN3VOVW70+8HTQWTr/RxYnXgbu2p3btW/yuiEE7iUTwKFjOF0ao1OzlvGuhVeZ6 7Fgu/a1YvBoYr0ZlCs4mioLaG/hsdFGbhGUJWf6QWbLBiyxetmCTDMff+aoJLH02Dxtg1 vHQNoo6ftHwHxrI1DmeakxyuJm8Etf+0437PtISHgmADmFXUUP6kQwHJA8OP2D6Lp1Wch t6YB9+aLuxdQP731XlE/VGtZS5ay84IM9CXWkpBaJ8lG3OU530h4aJMr45/ZTvxF3jEJi YumyKEB4Q6doHJUu8Aj+GLfDVKgAo0h8gvZSDV6cr31b6CixQOOBkzQCvH1fVdQsAog== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794274156; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=fQ4sO9j0P/Yp4zAuynqRkJ7lhKusBx/jjMLH+hzpCvY=; b=CFnhvDQpdZcK82Nenmm42ki1PSwgsvTz3bN0MWk9CwfDFSMGhpxcnuYkeAGWV7aIgOn7 U9JXyHDmsBF4KAC2py2mHN8XKTeni8dzDrg7psitEyrTxsJ8pkBmTRFFglFXKk6YGL1kN 544xYcflIs+rqAI5Yu4dSRs1MT3Av6LCYKYwp+l6cTCKPicwQmOXH+al8uJjhiTkWC/Pc FxHyTqbhe9gbexOhIIJCMI1faRdA6Au/XFcSP7H9tXnfu7LRH3nweuuD3X7y9pFR1nthy XY0HjoVeF5ZcFmUviu7IbgTPWeHm1UAgw52zgmbkKvHKv1I1dDWYrHiEevqOWXsfikg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=SRp8gPLx; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C8A0606A32A for ; Tue, 10 Nov 2026 01:29:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=SRp8gPLx Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1021A1F008A1; Tue, 10 Nov 2026 01:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794274156; bh=fQ4sO9j0P/Yp4zAuynqRkJ7lhKusBx/jjMLH+hzpCvY=; h=From:To:Cc:Subject:Date; b=SRp8gPLxmRxMHms6O02amh9MxUC0/vRTz1fPHZpWEKtKUPOCENG9wAxvWZAzOcbMU c13XmKc7M+enLRF/438Xm7kadsoBD87CpcJ7Xu4vTw3696hDSVN28nc5458iLb+Jdu kS2ixMhxh/PUaafXk/NAc6rdbp/jn1tWNrSas6OKr+YHmgoyPpfSDrex9aHA+6SpEy Rmb+00FG9Cj4T7Uf5amPw+ztvmpI6Rr1oTHAcYmkxnVWw53qG6T3yIS4JAX/kkLqwK Mombyvg1wGPNlJZte7+yyjhqB0PQvSMTwI7pIboyPcLqbQQ10VfRCEmHRPBfGnD96S bEqhLtvsoCN4Q== From: Sasha Levin To: matthias.goergens@gmail.com, jack@suse.cz Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] udf: don't use eloc after the end of the unallocated space table" failed to apply to 5.10-stable tree Date: Mon, 9 Nov 2026 20:29:14 -0500 Message-ID: <20261109202914-failed-5.10-94401199df90@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 94401199df90e1c2a50c6e4b73618ac5a4ba83ba # git commit -s git send-email --to '' --in-reply-to '20261109202914-failed-5.10-94401199df90@kernel.org' --subject-prefix 'PATCH 5.10.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 94401199df90e1c2a50c6e4b73618ac5a4ba83ba Mon Sep 17 00:00:00 2001 From: Matthias Goergens Date: Fri, 30 Oct 2026 22:05:37 +0800 Subject: [PATCH] udf: don't use eloc after the end of the unallocated space table When udf_next_aext() returns 0, its eloc, elen and etype outputs hold no defined value. Two walks of the unallocated space table still use eloc after the walk has reached the end of the table. udf_table_prealloc_blocks() looks for a free extent starting at first_block and decides whether it found one by comparing eloc with first_block after the walk. If the table's list ends in a continuation descriptor that leads to an empty allocation extent, eloc is then the block of that allocation extent, which is in use, and if that is first_block, the block is handed out as preallocation. Once udf_discard_prealloc() no longer frees the wrong block, this is what still makes fsx in generic/091 and generic/263 read back bad data on a table, in about one run in four. Only take the extent if the walk stopped at it. When udf_table_free_blocks() cannot merge the freed blocks into an existing extent, it appends a new one and sets only its block number, so the partition reference comes from whatever eloc held after the walk, and with long allocation descriptors it is written to disk. For a table without extents, eloc was never set. Take the partition reference from the freed blocks instead. Short allocation descriptors do not store the partition reference, which is why this half remains a latent long-descriptor fix rather than a reproduced failure. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Matthias Goergens Link: https://patch.msgid.link/fd9ca4c4ba98c00c012ec861f6c0bc08a3b1d07b.1793349907.git.matthias.goergens@gmail.com Signed-off-by: Jan Kara --- fs/udf/balloc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c index 2ec577b4321c9..75124188e7452 100644 --- a/fs/udf/balloc.c +++ b/fs/udf/balloc.c @@ -457,6 +457,7 @@ static void udf_table_free_blocks(struct super_block *sb, int adsize; + eloc.partitionReferenceNum = bloc->partitionReferenceNum; eloc.logicalBlockNum = start; elen = EXT_RECORDED_ALLOCATED | (count << sb->s_blocksize_bits); @@ -532,7 +533,7 @@ static int udf_table_prealloc_blocks(struct super_block *sb, eloc.logicalBlockNum, elen, first_block); } - if (first_block == eloc.logicalBlockNum) { + if (ret > 0 && first_block == eloc.logicalBlockNum) { epos.offset -= adsize; alloc_count = (elen >> sb->s_blocksize_bits); -- 2.53.0