From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,ziy@nvidia.com,ying.huang@linux.alibaba.com,
stable@vger.kernel.org,shivankg@amd.com,shakeel.butt@linux.dev,
matthew.brost@intel.com,joshua.hahnjy@gmail.com,gourry@gourry.net,
david@kernel.org,byungchul@sk.com,boris@bur.io,apopple@nvidia.com,
chenridong@xiaomi.com,akpm@linux-foundation.org
Subject: [merged mm-hotfixes-stable] mm-migrate-move-nr_kernel_file_pages-on-cross-node-migration.patch removed from -mm tree
Date: Mon, 09 Nov 2026 22:45:07 -0800 [thread overview]
Message-ID: <20261110064507.C32C61F008A3@smtp.kernel.org> (raw)
The quilt patch titled
Subject: mm/migrate: move NR_KERNEL_FILE_PAGES on cross-node migration
has been removed from the -mm tree. Its filename was
mm-migrate-move-nr_kernel_file_pages-on-cross-node-migration.patch
This patch was dropped because it was merged into the mm-hotfixes-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Ridong Chen <chenridong@xiaomi.com>
Subject: mm/migrate: move NR_KERNEL_FILE_PAGES on cross-node migration
Date: Tue, 27 Oct 2026 12:32:14 +0800
NR_KERNEL_FILE_PAGES counts page cache folios of mappings flagged
AS_KERNEL_FILE (currently the btrfs btree inode). It is a per-node
counter: filemap_add_folio() adds to folio_pgdat() of the new folio and
filemap_unaccount_folio() subtracts from folio_pgdat() of the folio
being removed.
__folio_migrate_mapping() does not move it when such a folio is
migrated to another node, so the source node keeps the count forever
and the destination node underflows once the folio is freed. btree
folios are migratable through btree_migrate_folio(), so demotion,
DAMON-based migration (DAMOS_MIGRATE_{HOT,COLD}) or memory offlining
all hit this.
Reproducer, on a QEMU guest with two memory tiers (node0 is DRAM with
all CPUs, node1 is a CPU-less slower node described via HMAT) and
/sys/kernel/mm/numa/demotion_enabled set:
1. mount a btrfs and create 20000 empty files, so that btree folios
are cached on node0;
2. echo 2G > /sys/devices/system/node/node0/reclaim, which demotes
them to node1;
3. umount and drop caches.
nr_kernel_file_pages in /sys/devices/system/node/nodeN/vmstat after
each step:
without this patch with this patch
node0 node1 node0 node1
1. cached 1868 0 1868 0
2. demoted 1868 0 36 1832
3. dropped 1832 0 (*) 0 0
(*) the counter has underflowed to -1832; negative values read as 0.
The global value in /proc/vmstat is 0 after step 3 in both cases.
Move it together with the other node-keyed page cache counters. It is
a node-only counter, so use the node accessor, matching how it is
accounted elsewhere. Interrupts are disabled here, as for the zone
counters below.
This was pointed out by Shivank while reviewing the NR_FILE_THPS fix
for the same function.
Link: https://lore.kernel.org/20261027043214.2248986-1-ridong.chen@linux.dev
Fixes: e3a9ac4e866e ("mm: add vmstat for kernel_file pages")
Signed-off-by: Ridong Chen <chenridong@xiaomi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Suggested-by: Shivank Garg <shivankg@amd.com>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
Reviewed-by: Shivank Garg <shivankg@amd.com>
Acked-by: Zi Yan <ziy@nvidia.com>
Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Joshua Hahn <joshua.hahnjy@gmail.com>
Cc: Byungchul Park <byungchul@sk.com>
Cc: Gregory Price <gourry@gourry.net>
Cc: Ying Huang <ying.huang@linux.alibaba.com>
Cc: Alistair Popple <apopple@nvidia.com>
Cc: Boris Burkov <boris@bur.io>
Cc: <stable@vger.kernel.org>
---
mm/migrate.c | 6 ++++++
1 file changed, 6 insertions(+)
--- a/mm/migrate.c~mm-migrate-move-nr_kernel_file_pages-on-cross-node-migration
+++ a/mm/migrate.c
@@ -705,6 +705,12 @@ static int __folio_migrate_mapping(struc
mod_lruvec_state(old_lruvec, NR_FILE_THPS, -nr);
mod_lruvec_state(new_lruvec, NR_FILE_THPS, nr);
}
+ if (test_bit(AS_KERNEL_FILE, &mapping->flags)) {
+ __mod_node_page_state(oldzone->zone_pgdat,
+ NR_KERNEL_FILE_PAGES, -nr);
+ __mod_node_page_state(newzone->zone_pgdat,
+ NR_KERNEL_FILE_PAGES, nr);
+ }
#ifdef CONFIG_SWAP
if (folio_test_swapcache(folio)) {
mod_lruvec_state(old_lruvec, NR_SWAPCACHE, -nr);
_
Patches currently in -mm which might be from chenridong@xiaomi.com are
mm-memcontrol-drop-unused-vmscan-tracepoint-include.patch
mm-vmscan-move-vmscan-tracepoints-to-a-local-header.patch
mm-vmscan-move-struct-scan_control-to-a-dedicated-header.patch
mm-vmscan-pass-scan_control-to-the-vmscan-tracepoints.patch
mm-mglru-add-tracepoint-for-scan_folios.patch
mm-mglru-add-lruvec_gen_size-helper.patch
mm-mglru-add-tracepoint-for-aging.patch
mailmap-add-entries-for-ridong-chen.patch
reply other threads:[~2026-11-10 6:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110064507.C32C61F008A3@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=boris@bur.io \
--cc=byungchul@sk.com \
--cc=chenridong@xiaomi.com \
--cc=david@kernel.org \
--cc=gourry@gourry.net \
--cc=joshua.hahnjy@gmail.com \
--cc=matthew.brost@intel.com \
--cc=mm-commits@vger.kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=shivankg@amd.com \
--cc=stable@vger.kernel.org \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox