From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794316658; b=BHV2YY7Ylh+UhpDHr9XIYH4HvrauC0kzwnN9sKUeTEclfTwOTbgolaaP0XDsCNtj66iR +KcyZntjLIXJ2PopHEyennWrMH2lCI3k3UE+5H0DNUYqNNVDc/1jNlemu73qwBay4BRSy jXwN3Q+mLh5J4CdkVtYFFv384PfFCO2we+jooRpVYFnfAqcq/3woJoiHBOtfWEqdqyH7T YX2pEL2zgnEan6peyZoeKGl0VWXBgVdSXcCVHjFhupxOPSw+zodWFrmzCtle6MiJfdO4C iHWAebgwyarJaz+XJ5Y4BnHXRgdpsBqjS7DL/4QPxBBj0LLa2yDm6ekk6N0zfmVcKMA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794316658; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=pS//+7eQzAkjp5aMXyvhoY9fkh+VAKd3VXQONkOpcRU=; b=VN96y6GS2T591TbIg7Jg44ewO/m31Sku8DorZiWtjjqUI0MsgjrePdA1mUOGex08v6ft 9uxXszhvQYgCJM5mZWtmBAZzdlgfVeGCoaK251MEcDbIHAl56wEFGljtkjdGAj89Yfjtt hctQOptIni5c7kVt7QfDKVYEYrFqqho9LbCWPb0zl7GYxWb1A7Zxy1aMG3sOVv6/qnTc+ WuyFeR29APSCNXHlGgJmjWhwvaNNz5a+Bis17YTebPf6sxxwwBLohRidyFrIGfXWSe01A CeoC0uCfAAbgSYi8fEu3d35AY2YJ2NE0kXP8YGfZU1T8pU2l+ImEGrs21p2MXr5Xkqw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=MvX1Owbr; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1D6C606B2F8 for ; Tue, 10 Nov 2026 13:17:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=MvX1Owbr Received: by smtp.kernel.org (Postfix) with ESMTPSA id 164241F008A2; Tue, 10 Nov 2026 13:17:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794316657; bh=pS//+7eQzAkjp5aMXyvhoY9fkh+VAKd3VXQONkOpcRU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=MvX1OwbrECNOdDZVQ1Abci7CYFwhdb18nYGHT/7BbUWf0pIJkC4+FHTgBAQ90UrJe 8JpO65WNT+bz9sMzG1AjC4Bkuri4Me+18d0mfF0UDfz0+MBSf5VUXVy6qUClJHLMAf DvPsDY2zEaKfJNG353BQLgr8A4K1Gl3Y42Pf8gqr09YWndHzWKG0UK+BudOO2tV78t X5Qn6VOGWhliNEzL4Q5PKLHK1bUO1mZk1rUK0E7o1JyJzMQ7bESqFb8u+Md0As9WRB khaPNLcI1m5yh3q/JyNbCwZu8sd4wD+BmeaIydrEAREUybhiS2kmSaJ3i7XqirVkBM 2CEkljjqqTz3A== From: Sasha Levin To: stable@vger.kernel.org Cc: Ryusuke Konishi , syzbot+f6c7e1f1809f235eeb90@syzkaller.appspotmail.com, Wang Jianjian , Viacheslav Dubeyko , Sasha Levin Subject: [PATCH 6.6.y 2/2] nilfs2: ignore non-fatal signals during synchronous log write wait Date: Tue, 10 Nov 2026 08:17:34 -0500 Message-ID: <20261110131728.1706995-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261110131728.1706995-1-sashal@kernel.org> References: <20261107053051-failed-6.6-7131aaa74bcc@kernel.org> <20261110131728.1706995-1-sashal@kernel.org> X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Ryusuke Konishi [ Upstream commit 7131aaa74bcc7c9da1f1d1c8724da75c775557a0 ] Based on a syzbot report, Wang Jianjian pointed out that following a successful directory operation in nilfs_rename(), a synchronous write requested within nilfs_transaction_commit(), triggered by a sync flag set by nilfs_commit_chunk(), could be interrupted by a user signal. This interruption leaves in-memory metadata updates intact while returning an error, causing inconsistency with the VFS dentry cache and ultimately triggering a kernel warning. According to "signal(7)", local disks are not classified as "slow devices" (such as terminals, FIFOs, or pipes) and their I/O operations on disk devices are not interrupted by signals. In kernel space, waiting for such disk I/O should therefore not be aborted by ordinary (non-fatal) signals. Suppress this issue by modifying nilfs_segctor_sync(), which waits for the log writer thread to complete synchronous writes, to catch only fatal signals via fatal_signal_pending() and return -EINTR rather than -ERESTARTSYS. To complement this change and prevent the wait loop from busy-looping when schedule() returns immediately due to a pending non-fatal signal, switch the wait state from TASK_INTERRUPTIBLE to TASK_KILLABLE. This serves as an effective interim stabilization measure without structural changes until a comprehensive fix for metadata consistency is implemented. Reported-by: syzbot+f6c7e1f1809f235eeb90@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=f6c7e1f1809f235eeb90 Fixes: 9ff05123e3bf ("nilfs2: segment constructor") Tested-by: syzbot+f6c7e1f1809f235eeb90@syzkaller.appspotmail.com Cc: Wang Jianjian Cc: stable@vger.kernel.org Signed-off-by: Ryusuke Konishi Signed-off-by: Viacheslav Dubeyko Signed-off-by: Sasha Levin --- fs/nilfs2/ioctl.c | 2 +- fs/nilfs2/recovery.c | 2 +- fs/nilfs2/segment.c | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c index f8c53a411d549..d15d88571fe27 100644 --- a/fs/nilfs2/ioctl.c +++ b/fs/nilfs2/ioctl.c @@ -960,10 +960,10 @@ static int nilfs_ioctl_clean_segments(struct inode *inode, struct file *filp, * Return: 0 on success, or one of the following negative error codes on * failure: * * %-EFAULT - Failure during execution of requested operation. + * * %-EINTR - Interrupted. * * %-EIO - I/O error. * * %-ENOMEM - Insufficient memory available. * * %-ENOSPC - No space left on device (only in a panic state). - * * %-ERESTARTSYS - Interrupted. * * %-EROFS - Read only filesystem. */ static int nilfs_ioctl_sync(struct inode *inode, struct file *filp, diff --git a/fs/nilfs2/recovery.c b/fs/nilfs2/recovery.c index b5207e4c50007..af1b2a6a93db7 100644 --- a/fs/nilfs2/recovery.c +++ b/fs/nilfs2/recovery.c @@ -743,11 +743,11 @@ static void nilfs_abort_roll_forward(struct the_nilfs *nilfs) * * Return: 0 on success, or one of the following negative error codes on * failure: + * * %-EINTR - Interrupted. * * %-EINVAL - Inconsistent filesystem state. * * %-EIO - I/O error. * * %-ENOMEM - Insufficient memory available. * * %-ENOSPC - No space left on device (only in a panic state). - * * %-ERESTARTSYS - Interrupted. */ int nilfs_salvage_orphan_logs(struct the_nilfs *nilfs, struct super_block *sb, diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index ab2359959b566..5c7802de2679b 100644 --- a/fs/nilfs2/segment.c +++ b/fs/nilfs2/segment.c @@ -2243,7 +2243,7 @@ static int nilfs_segctor_sync(struct nilfs_sc_info *sci) wake_up(&sci->sc_wait_daemon); for (;;) { - set_current_state(TASK_INTERRUPTIBLE); + set_current_state(TASK_KILLABLE); /* * Synchronize only while the log writer thread is alive. @@ -2257,11 +2257,11 @@ static int nilfs_segctor_sync(struct nilfs_sc_info *sci) err = wait_req.err; break; } - if (!signal_pending(current)) { + if (!fatal_signal_pending(current)) { schedule(); continue; } - err = -ERESTARTSYS; + err = -EINTR; break; } finish_wait(&sci->sc_wait_request, &wait_req.wq); @@ -2295,10 +2295,10 @@ static void nilfs_segctor_wakeup(struct nilfs_sc_info *sci, int err, bool force) * * Return: 0 on success, or one of the following negative error codes on * failure: + * * %-EINTR - Interrupted. * * %-EIO - I/O error (including metadata corruption). * * %-ENOMEM - Insufficient memory available. * * %-ENOSPC - No space left on device (only in a panic state). - * * %-ERESTARTSYS - Interrupted. * * %-EROFS - Read only filesystem. */ int nilfs_construct_segment(struct super_block *sb) @@ -2325,10 +2325,10 @@ int nilfs_construct_segment(struct super_block *sb) * * Return: 0 on success, or one of the following negative error codes on * failure: + * * %-EINTR - Interrupted. * * %-EIO - I/O error (including metadata corruption). * * %-ENOMEM - Insufficient memory available. * * %-ENOSPC - No space left on device (only in a panic state). - * * %-ERESTARTSYS - Interrupted. * * %-EROFS - Read only filesystem. */ int nilfs_construct_dsync_segment(struct super_block *sb, struct inode *inode, -- 2.53.0