From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794320674; b=D1TsFMKsANVYO2+GyM9/i9O/B1WO/uPn0Waktl4L3MDgZ8WUFIn0Sp+ZICcRw+1RzJNF +n4NerU1ZDc+BTnWWc3EyJa5bFDxwDBiczjAgp9byEO8a/LEA84wJkqp0KqmLIqUsyAcZ FGAkDpVCdJhf07YA1aQhnJtqJrWBPboUm6v3cG2eAr5yW/hwyi9a1dfagKf4Q96eYdGqa PM3I0vvqlsmgWob/bpIWOwHh4c3/5NuxMNzO1QDhK1CT3rFvDLkc9+A1awK5hnlSFqHem loekPa66ghk5keKLVM3Fwd7OKn3CbgoM8b+b/hYMe2CgabDkONqzQRhRO06SKBOMkWQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794320674; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=osoM7e+K66M8Pm9fOYbYPZ2VopV5CNuhL+k4mGVB5LU=; b=Ecvph25jH/HhMmz9g+54qJCopPq3U5c+quxIIuENHUjzB4sbiXEg2B2M/3c4wo8Ai6B4 gMnnDxMjl5scPIwTX9SVLYrlsL9yccFrJpMK6WPsAftuhQIBBcRQtLQ7AdHFfPFjqmXK3 pELThwMk0Zk/p2nHuN1cW8SVDaQrMxt6lXWAv0qSh3bnPH3UmTySOu2nh4c2th9x3pKWO zM49Q6325Cm3cLiF2oBy7eKpOjal43RSS+ozN9zVlYHqSxLkcsSMnWJT9PwBuQKTEDL2h eGz7ZcGLph9RdhCYtALoFu2hhsb+i3AHofVmBR0GaSZV5lPAY2CXy6Q8uUKFhVCUMLQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=mWAxZjuB; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0325606A32A for ; Tue, 10 Nov 2026 14:24:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=mWAxZjuB Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1F521F0089F; Tue, 10 Nov 2026 14:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794320674; bh=osoM7e+K66M8Pm9fOYbYPZ2VopV5CNuhL+k4mGVB5LU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mWAxZjuBGA58LzszG0S7T0vwTL31WSOEZXPAn701eNgMj6tXla2P/gTAtSZ29UnG/ MsnHABjHsF9b98/7HJD+kjVwzi4q1RDKlTvkTBbtw/VdEHaYyrT7xxYcv8rqj5EPpi 9DA7h4oOr9E/264a2LSwtO/aCki571PYMnl74duBJW2gAmJx834SSaJIQPd/Yw5IUQ VtqqYVQKNPKJcfOGtEzvLgnqPBVwlxvmuJMXdJsO8iCIrZ+e5Sj8OACILAmx3G+YVx xFfZGbb86/2dO58YfJ2pPkvXN/vhS7hpSczpBsbAqFLe90L5lymLk4WtOVFF5b8vMA kasV5fEUx8yAg== From: Sasha Levin To: stable@vger.kernel.org Cc: Niklas Cassel , Damien Le Moal , Sasha Levin Subject: [PATCH 6.1.y 1/2] ata: ahci: print the lpm policy on boot Date: Tue, 10 Nov 2026 09:24:31 -0500 Message-ID: <20261110142342.1878224-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261107054205-failed-6.1-34a4a34431ed@kernel.org> References: <20261107054205-failed-6.1-34a4a34431ed@kernel.org> X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Niklas Cassel [ Upstream commit affccb16c117d188eb09495cbdea149cecbf00b9 ] The target LPM policy can be set using either a Kconfig or a kernel module parameter. However, if the board type is set to anything but board_ahci_low_power, then the LPM policy will overridden and set to ATA_LPM_UNKNOWN. Additionally, if the default suspend is suspend to idle, depending on the hardware capabilities of the HBA, ahci_update_initial_lpm_policy() might override the LPM policy to either ATA_LPM_MIN_POWER_WITH_PARTIAL or ATA_LPM_MIN_POWER. All this means that it is very hard to know which LPM policy a user will actually be using on a given system. In order to make it easier to debug LPM related issues, print the LPM policy on boot. One common LPM related issue is that the device fails to link up. Because of that, we cannot add this print to ata_dev_configure(), as that function is only called after a successful link up. Instead, add the info using ata_port_desc(), with the help of a new ata_port_desc_misc() helper. The port description is printed once per port during boot. Before changes: ata1: SATA max UDMA/133 abar m524288@0xa5780000 port 0xa5780100 irq 170 ata2: SATA max UDMA/133 abar m524288@0xa5780000 port 0xa5780180 irq 170 After changes: ata1: SATA max UDMA/133 abar m524288@0xa5780000 port 0xa5780100 irq 170 lpm-pol 4 ata2: SATA max UDMA/133 abar m524288@0xa5780000 port 0xa5780180 irq 170 lpm-pol 4 Signed-off-by: Niklas Cassel Signed-off-by: Damien Le Moal Stable-dep-of: 34a4a34431ed ("ata: libahci: Free the IRQs when activating a multi-IRQ host fails") Signed-off-by: Sasha Levin --- drivers/ata/libahci.c | 2 +- drivers/ata/libata-core.c | 2 +- drivers/ata/libata-sff.c | 10 +++++----- drivers/ata/pata_cs5520.c | 2 +- include/linux/libata.h | 5 +++++ 5 files changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c index 4016809a6a8b7..1211d46d2475b 100644 --- a/drivers/ata/libahci.c +++ b/drivers/ata/libahci.c @@ -2637,7 +2637,7 @@ static int ahci_host_activate_multi_irqs(struct ata_host *host, if (rc) return rc; - ata_port_desc(host->ports[i], "irq %d", irq); + ata_port_desc_misc(host->ports[i], irq); } return ata_host_register(host, sht); diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 675eafc8a023f..b80113ebb3fc9 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -6066,7 +6066,7 @@ int ata_host_activate(struct ata_host *host, int irq, return rc; for (i = 0; i < host->n_ports; i++) - ata_port_desc(host->ports[i], "irq %d", irq); + ata_port_desc_misc(host->ports[i], irq); rc = ata_host_register(host, sht); /* if failed, just free the IRQ and leave ports alone */ diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c index 3601fd44430f6..f51697e203404 100644 --- a/drivers/ata/libata-sff.c +++ b/drivers/ata/libata-sff.c @@ -2388,7 +2388,7 @@ int ata_pci_sff_activate_host(struct ata_host *host, for (i = 0; i < 2; i++) { if (ata_port_is_dummy(host->ports[i])) continue; - ata_port_desc(host->ports[i], "irq %d", pdev->irq); + ata_port_desc_misc(host->ports[i], pdev->irq); } } else if (legacy_mode) { if (!ata_port_is_dummy(host->ports[0])) { @@ -2398,8 +2398,8 @@ int ata_pci_sff_activate_host(struct ata_host *host, if (rc) goto out; - ata_port_desc(host->ports[0], "irq %d", - ATA_PRIMARY_IRQ(pdev)); + ata_port_desc_misc(host->ports[0], + ATA_PRIMARY_IRQ(pdev)); } if (!ata_port_is_dummy(host->ports[1])) { @@ -2409,8 +2409,8 @@ int ata_pci_sff_activate_host(struct ata_host *host, if (rc) goto out; - ata_port_desc(host->ports[1], "irq %d", - ATA_SECONDARY_IRQ(pdev)); + ata_port_desc_misc(host->ports[1], + ATA_SECONDARY_IRQ(pdev)); } } diff --git a/drivers/ata/pata_cs5520.c b/drivers/ata/pata_cs5520.c index f4289a532f871..8b0c419936070 100644 --- a/drivers/ata/pata_cs5520.c +++ b/drivers/ata/pata_cs5520.c @@ -212,7 +212,7 @@ static int cs5520_init_one(struct pci_dev *pdev, const struct pci_device_id *id) if (rc) return rc; - ata_port_desc(ap, "irq %d", irq[i]); + ata_port_desc_misc(ap, irq[i]); } return ata_host_register(host, &cs5520_sht); diff --git a/include/linux/libata.h b/include/linux/libata.h index a1e9a637de591..52b73315dae33 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -1555,6 +1555,11 @@ void ata_port_desc(struct ata_port *ap, const char *fmt, ...); extern void ata_port_pbar_desc(struct ata_port *ap, int bar, ssize_t offset, const char *name); #endif +static inline void ata_port_desc_misc(struct ata_port *ap, int irq) +{ + ata_port_desc(ap, "irq %d", irq); + ata_port_desc(ap, "lpm-pol %d", ap->target_lpm_policy); +} static inline bool ata_tag_internal(unsigned int tag) { -- 2.53.0