From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794328023; b=lrBDoQINEUmBuFB25oB7Y7dDRVlUEJ0Dp8YtOwsQycxOD5/GUhGZU9PezUS2TB6fxyZz if1nm35dmeUWEU1h6LFQAdve+tXVjlH2kQKqA1HsI7DRsuyNg39SvTB6khbHOengq8pp/ ReMVowy9rA3QRbXmryjfij3d5/sZdKmprwOgQUmc3cWJsu2cxmHrW1iYPXhgsjztwynQV +Ok7W7xZSnWj2nQC6UUMt6tbc3B+50wSz1a40ELp6+sxm+CzUIr7i38mMXRnTe3CdpKoq Vhe7Afb1LI1QLzen9vnV0OOUyzmTznzy+dv9oinkBCTTp0lD1Yzd33qC07pmb0pHwTA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794328023; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=+yv6p3Ei3iK5gLrJeZ0o4l6HPjXQ7UIGhXaL6irxjxA=; b=GYga+A77JKernZpmIXjsMN4KDjqVE+YtQkx29sOmKBglA2kQ8xd1O2CFPeEoYWFe2nnI hb9Z9cgr/+w7nIDbiivqt54NV767l1z2tV3xZllt59yNEBaJw4tZDp4Xup1FDexuwcCs2 CR0xdSogd8RDMr+OA1+QuvgKhdfo/gCeCJyc2zrLoevwOkxh9REfGG1gfXcZcKuPp0yAL a4k/7NI4qSMy54B6oUvTwXHqFCYaI/Cl2IYlO1zMiu2EUcjkwDbAswHH6lhtlfuemMRcg nir6kv1WPOcl9tRnIs1zRyEpvs7I6mnIITh2e/IYzbJhR6T5MMDUFxvzgxehnyWC+Eg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Mp9ZiLF2; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DF96606D7D9 for ; Tue, 10 Nov 2026 16:27:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Mp9ZiLF2 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD6181F008A1; Tue, 10 Nov 2026 16:26:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794328020; bh=+yv6p3Ei3iK5gLrJeZ0o4l6HPjXQ7UIGhXaL6irxjxA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Mp9ZiLF2hQdL5E+/9Pnb8HI3yT57QkelH8Tonez5DjqrHRNaEJaaFm+ECifKQvSVr IdVVrrxcpiqE0cJ3Ti+9YKwCkz6ltrEAAZtfIa7VbBxTXSNo27kq4vixr0t18BwaHQ cy/FsFjqj/YzZLddcWGu6M4HFTR6eojA+ygz6ik0RpoPVoTB+IVdr/8OFwiEejBnzy aLuogVafqLt3e0Ltz3cYyWn5PInnNcHdHdQHgD8tSqj5Xd6bRbIWGA8PJU0FXG0wwS Qgxw4uEzNGJ3Mv6JgBcoUb5NU4vL4QeCOlkbdqyBDHaTvM75FEaVNi+6ooFsIqWhqi b8UlChMOSRTKw== From: Sasha Levin To: stable@vger.kernel.org Cc: Jun Yang , stable@kernel.org, TencentOS Corvus AI , Xin Long , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10.y 2/2] sctp: re-point retained control chunks on association migration Date: Tue, 10 Nov 2026 11:26:57 -0500 Message-ID: <20261110162640.2496297-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261110162640.2496297-1-sashal@kernel.org> References: <20261107062420-failed-5.10-52ffeaa358d1@kernel.org> <20261110162640.2496297-1-sashal@kernel.org> X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jun Yang [ Upstream commit 52ffeaa358d1f3d91aa87a26ad90d77769cff74b ] sctp_sock_migrate() transfers DATA chunk ownership but leaves retained control chunks pointing at the old socket. A later retransmission can therefore access the socket after it has been freed. Extend the migration walk to cover retained control chunks and use sctp_control_set_owner_w() to assign their new owner. Reuse the DATA ownership check so each chunk is processed once per pass, even when it is reachable through multiple lists or retained pointers. Preserve a control chunk's existing authentication key across migration so its final release can still generate SCTP_AUTH_FREE_KEY when needed. Fixes: d04adf1b3551 ("sctp: reset owner sk for data chunks on out queues when migrating a sock") Cc: stable@kernel.org Reported-by: TencentOS Corvus AI Signed-off-by: Jun Yang Acked-by: Xin Long Link: https://patch.msgid.link/20261009074244.3718-3-juny24602@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- include/net/sctp/sm.h | 1 + net/sctp/sm_make_chunk.c | 5 ++-- net/sctp/socket.c | 53 ++++++++++++++++++++++++++++++---------- 3 files changed, 44 insertions(+), 15 deletions(-) diff --git a/include/net/sctp/sm.h b/include/net/sctp/sm.h index 5c491a3bc27e4..f6f0adb05d2d2 100644 --- a/include/net/sctp/sm.h +++ b/include/net/sctp/sm.h @@ -250,6 +250,7 @@ struct sctp_chunk *sctp_make_fwdtsn(const struct sctp_association *asoc, struct sctp_fwdtsn_skip *skiplist); struct sctp_chunk *sctp_make_auth(const struct sctp_association *asoc, __u16 key_id); +void sctp_control_set_owner_w(struct sctp_chunk *chunk); struct sctp_chunk *sctp_make_strreset_req(const struct sctp_association *asoc, __u16 stream_num, __be16 *stream_list, bool out, bool in); diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c index 362c314fd48e9..de17f6ef1540a 100644 --- a/net/sctp/sm_make_chunk.c +++ b/net/sctp/sm_make_chunk.c @@ -95,7 +95,7 @@ static void sctp_control_release_owner(struct sk_buff *skb) } } -static void sctp_control_set_owner_w(struct sctp_chunk *chunk) +void sctp_control_set_owner_w(struct sctp_chunk *chunk) { struct sctp_association *asoc = chunk->asoc; struct sk_buff *skb = chunk->skb; @@ -108,7 +108,8 @@ static void sctp_control_set_owner_w(struct sctp_chunk *chunk) * For now don't do anything for now. */ if (chunk->auth) { - chunk->shkey = asoc->shkey; + if (!chunk->shkey) + chunk->shkey = asoc->shkey; sctp_auth_shkey_hold(chunk->shkey); } skb->sk = asoc ? asoc->base.sk : NULL; diff --git a/net/sctp/socket.c b/net/sctp/socket.c index a3e9996120b89..74031d3e064a3 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -154,9 +154,24 @@ static void sctp_clear_owner_w(struct sctp_chunk *chunk) static void sctp_set_owner_w_migrate(struct sctp_chunk *chunk) { - sctp_set_owner_w(chunk); - if (chunk->shkey) - sctp_auth_shkey_release(chunk->shkey); + struct sctp_shared_key *shkey = chunk->shkey; + + if (chunk->msg) + sctp_set_owner_w(chunk); + else + sctp_control_set_owner_w(chunk); + + if (shkey) + sctp_auth_shkey_release(shkey); +} + +static void sctp_process_tx_chunk(struct sctp_association *asoc, + struct sctp_chunk *chunk, bool clear, + void (*cb)(struct sctp_chunk *)) +{ + if ((clear && asoc->base.sk == chunk->skb->sk) || + (!clear && asoc->base.sk != chunk->skb->sk)) + cb(chunk); } #define traverse_and_process() \ @@ -164,17 +179,14 @@ do { \ msg = chunk->msg; \ if (msg == prev_msg) \ continue; \ - list_for_each_entry(c, &msg->chunks, frag_list) { \ - if ((clear && asoc->base.sk == c->skb->sk) || \ - (!clear && asoc->base.sk != c->skb->sk)) \ - cb(c); \ - } \ + list_for_each_entry(c, &msg->chunks, frag_list) \ + sctp_process_tx_chunk(asoc, c, clear, cb); \ prev_msg = msg; \ } while (0) -static void sctp_for_each_tx_datachunk(struct sctp_association *asoc, - bool clear, - void (*cb)(struct sctp_chunk *)) +static void sctp_for_each_tx_chunk(struct sctp_association *asoc, + bool clear, + void (*cb)(struct sctp_chunk *)) { struct sctp_datamsg *msg, *prev_msg = NULL; @@ -197,6 +209,21 @@ static void sctp_for_each_tx_datachunk(struct sctp_association *asoc, list_for_each_entry(chunk, &q->out_chunk_list, list) traverse_and_process(); + + list_for_each_entry(chunk, &q->control_chunk_list, list) + sctp_process_tx_chunk(asoc, chunk, clear, cb); + + list_for_each_entry(chunk, &asoc->asconf_ack_list, transmitted_list) + sctp_process_tx_chunk(asoc, chunk, clear, cb); + + list_for_each_entry(chunk, &asoc->addip_chunk_list, list) + sctp_process_tx_chunk(asoc, chunk, clear, cb); + + if (asoc->strreset_chunk) + sctp_process_tx_chunk(asoc, asoc->strreset_chunk, clear, cb); + + if (asoc->addip_last_asconf) + sctp_process_tx_chunk(asoc, asoc->addip_last_asconf, clear, cb); } static void sctp_for_each_rx_skb(struct sctp_association *asoc, struct sock *sk, @@ -9470,9 +9497,9 @@ static int sctp_sock_migrate(struct sock *oldsk, struct sock *newsk, * paths won't try to lock it and then oldsk. */ lock_sock_nested(newsk, SINGLE_DEPTH_NESTING); - sctp_for_each_tx_datachunk(assoc, true, sctp_clear_owner_w); + sctp_for_each_tx_chunk(assoc, true, sctp_clear_owner_w); sctp_assoc_migrate(assoc, newsk); - sctp_for_each_tx_datachunk(assoc, false, sctp_set_owner_w_migrate); + sctp_for_each_tx_chunk(assoc, false, sctp_set_owner_w_migrate); /* If the association on the newsk is already closed before accept() * is called, set RCV_SHUTDOWN flag. -- 2.53.0