From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794335329; b=BKfzz/3Lzl+oGBw7SO81hjke83lwXpC6ZANlGqjY6k0pO86orFABKUIezsoNqT/2Cikm HHxVD71P2qeuIdQjnV+b8+Rfs/6GWpxipqj3P312Mk6YkNn9JnFJluOQAATr0VxBl4G0O wFBz5daNc9fG52/5dqK0SI0jIpZEPZRBZo+1fC2bUFeRLIVgm3F7KWhNB5WzXbD0dflW4 lzP//sOv+8tmMbz0i4L8Gt2aJyPl7GX7Ams3R5j18z86wgAuO+ITAmPNJqjCoaHXJZBWr T6ylVbJuOVbXyhDzsfhqxPuuuwQ7Jx5ik53hn8krkfWzOVOyMK1Q8mUs9ZG05KhcIlg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794335329; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=2IuCb2qzOTnuhP5nKnIBiMpzzz2YJO3NX/2MEYyDQ4Y=; b=ys/W2b3TuoRh2Q41D7tIAfVJy73z5ncud4DwDOVD/HAdUvnxF10q8Fwm7CfPtX63Y+cM kvs0LVGIlj0PN7KZQZa3YovnBTbIAxnA0Z7sSj9cbH/3W0NZekFWV5an4RYB3NjwGFAI1 ZmQYrzNJW+jnW3hACA16bnftlM170juG9u8KXCulXWwllzfVQxbQG+yuCTply5bosq/Mv yNR4cA4dm9OgIgX0EPSCd915VWaa7fA2BdbDydKSAHLkD97yO11lYp2H5szvFeCRczH67 y3xyHInrwBo97cu1UJcNsaq0ZJYXhhiEmfIyegchkVHVTeTDdzSXW1/22wGMPm8FG/A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=b82czbwd; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE708606A31C for ; Tue, 10 Nov 2026 18:28:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=b82czbwd Received: by smtp.kernel.org (Postfix) with ESMTPSA id E20431F008A3; Tue, 10 Nov 2026 18:28:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794335328; bh=2IuCb2qzOTnuhP5nKnIBiMpzzz2YJO3NX/2MEYyDQ4Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=b82czbwdJm7ZsgF79YLloQCk2IspLtVU3ZMVhKdlGCh2JD/lXR68pW9s37Y8DWHv/ hchEMAg2EHEJOM8CENJnuk2YRtQTUXbgIWSMI8Ke0Bf0D5ET0v7Z2sk8J1WikF0Zg3 66zk3SRrkOLO7m5VaxsYLQB+EOAsO3MTofpTKmnkc216QlAk1XxPK45dlaDKRuECMZ 51RSVBf5pPmWzmseXdIGPlsKUwgRqjeHpu0Uff87IOH4vih2ddBSFnCzw8FSoQv/6R HpjAJ24yYFaRHTQXTFUaTSm2dW8yv+4nmR/qEIkWu09Ixe9cFm4yTL3wCN2NkDXGy6 ZOmXzro8QCiWQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Karl Mehltretter , Thomas Gleixner , Radu Rendec , Sasha Levin Subject: [PATCH 6.6.y] irqchip/atmel-aic[5]: Disable interrupts in the irq_pm_shutdown() callbacks Date: Tue, 10 Nov 2026 13:28:46 -0500 Message-ID: <20261110182827.3161295-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261107053532-failed-6.6-0ca21fe11145@kernel.org> References: <20261107053532-failed-6.6-0ca21fe11145@kernel.org> X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Karl Mehltretter [ Upstream commit 0ca21fe111457c843624a835641bb490e704bb2f ] irq_gc_shutdown() calls the irq_pm_shutdown() callbacks from syscore_shutdown() with interrupts enabled. aic_pm_shutdown() and aic5_pm_shutdown() take the generic chip lock with raw_spin_lock(), and irq_gc_eoi() takes the same lock from the interrupt handler. An interrupt from the chip while the lock is held spins in irq_gc_eoi() and hangs the reboot. Lockdep reports this on every reboot of a SAM9X75 Curiosity board: WARNING: inconsistent lock state inconsistent {IN-HARDIRQ-W} -> {HARDIRQ-ON-W} usage. busybox/101 [HC0[0]:SC0[0]:HE1:SE1] takes: c1c2b434 (&gc->lock){?.-.}-{2:2}, at: aic5_pm_shutdown+0x34/0xd8 {IN-HARDIRQ-W} state was registered at: ... irq_gc_eoi+0x28/0x60 handle_fasteoi_irq+0x120/0x214 ... aic5_pm_shutdown from irq_gc_shutdown+0x4c/0x58 irq_gc_shutdown from syscore_shutdown+0x5c/0x9c syscore_shutdown from kernel_restart+0x34/0x78 kernel_restart from sys_reboot+0x180/0x25c Use the irqsave guard, as commit 33517881ede7 ("irqchip/brcmstb-l2: Use _irqsave locking variants in non-interrupt code") did for brcmstb-l2. Fixes: b1479ebb7720 ("irqchip: atmel-aic: Add atmel AIC/AIC5 drivers") Signed-off-by: Karl Mehltretter Signed-off-by: Thomas Gleixner Assisted-by: LLM Reviewed-by: Radu Rendec Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260926004124.88221-1-kmehltretter@gmail.com [ sashal: Replaced scoped irqsave guards with explicit irq_gc_lock_irqsave()/irq_gc_unlock_irqrestore() pairs using local flags. ] Signed-off-by: Sasha Levin --- drivers/irqchip/irq-atmel-aic.c | 5 +++-- drivers/irqchip/irq-atmel-aic5.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/irqchip/irq-atmel-aic.c b/drivers/irqchip/irq-atmel-aic.c index 4631f68479537..120ec1ae95d7b 100644 --- a/drivers/irqchip/irq-atmel-aic.c +++ b/drivers/irqchip/irq-atmel-aic.c @@ -126,11 +126,12 @@ static void aic_resume(struct irq_data *d) static void aic_pm_shutdown(struct irq_data *d) { struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d); + unsigned long flags; - irq_gc_lock(gc); + irq_gc_lock_irqsave(gc, flags); irq_reg_writel(gc, 0xffffffff, AT91_AIC_IDCR); irq_reg_writel(gc, 0xffffffff, AT91_AIC_ICCR); - irq_gc_unlock(gc); + irq_gc_unlock_irqrestore(gc, flags); } #else #define aic_suspend NULL diff --git a/drivers/irqchip/irq-atmel-aic5.c b/drivers/irqchip/irq-atmel-aic5.c index 145535bd75605..61636866b4916 100644 --- a/drivers/irqchip/irq-atmel-aic5.c +++ b/drivers/irqchip/irq-atmel-aic5.c @@ -224,15 +224,16 @@ static void aic5_pm_shutdown(struct irq_data *d) struct irq_domain_chip_generic *dgc = domain->gc; struct irq_chip_generic *bgc = irq_get_domain_generic_chip(domain, 0); struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d); + unsigned long flags; int i; - irq_gc_lock(bgc); + irq_gc_lock_irqsave(bgc, flags); for (i = 0; i < dgc->irqs_per_chip; i++) { irq_reg_writel(bgc, i + gc->irq_base, AT91_AIC5_SSR); irq_reg_writel(bgc, 1, AT91_AIC5_IDCR); irq_reg_writel(bgc, 1, AT91_AIC5_ICCR); } - irq_gc_unlock(bgc); + irq_gc_unlock_irqrestore(bgc, flags); } #else #define aic5_suspend NULL -- 2.53.0