From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794366824; b=CcGnVzaAtclm7uzPLxZPfgNWaVwgL/UsvrVYNmUliPB5azLnqZ4DFzmOl+3ppL+59FtZ TMwn26gbdNoV1WEQEuFVpDXaKiASZA6qtQNThRHrUma4Xi1d5ctC1hVS3Q9jtvwNON3lk EB69CB/lzYqXscy7jyKmSyYfHnvIyuBYIT4v97JZWxmUSmguY9qlLsgT/yXg/3+emYaHd ZqDGrTNrMfW4yLHtiE1XnHxM5IEZhjVvj9Zkje/f15OswTQoWhpqyO18G7299VuqpFgsx aYrVEhXMOBCltjVX0g4PkErznOCeaDUoQ+NGubx2f/XuTMEjwuNO1jK7pz2EWTxljVg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794366824; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=wvtjnfSH72Sa4P6wphnKiBG2RdBGk8hCkQBuH8DY7PU=; b=gvvTQaEAu/vzs4uvDngE++R7+g/CTa2NJzHxuEIFVvh1VIi0xgwiNF4zkIKS72kjhPuN 2KLdAbmHBUttAR30ldJTt8SwT8i2r4ZIIRF5UG6Tj5cW8McvffGky3x7SkOmUfD9KIzut uzGW0VWvXJM3/xin6GCcXbsqsEKAM2XvG6qG7bQlyrplTiS+GHq3ZGi6A77BeSifVYXE2 sv8dtcJkZ7soVPxQWdSnEQJGRuudFYtfx5vCEflRZmJ0E95+izYDXAL6+e5Ku2QfCI+ca 7b8JDxRc3FZyaq5C7GTyj2mpjpv9gKDAtThia66QxR5TejZdKoOtnCb9DNUBZlvd6bQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ihvqaD0u; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 846C6606A31C for ; Wed, 11 Nov 2026 03:13:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ihvqaD0u Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FE061F0089F; Wed, 11 Nov 2026 03:13:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794366824; bh=wvtjnfSH72Sa4P6wphnKiBG2RdBGk8hCkQBuH8DY7PU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ihvqaD0uxqZ30/KjjgPwajKZb10pT0/hku3jcmxsDS1aSXLLD6EzPNY2VvPAYpXPJ m5CBEKy1ebNJE+o8+dlifqYZTq9kh1u5v1psvwsJ+0WHT6peJkd2DnQSBTOvKF2dE2 /C/jIsd4clyCfWoBSImyMgDdJDmWPMagUdNjIFLzbp7iU2HGk8CrUliLMhyr1PVjs9 nzWVlz4IUT6NYdjzK7dTtGyMD2aAhGgfdw9iGSY3TRGZrO8IP8KcAzofJRGCgmW3Dt 0MG7zpoyV6CWQni6wcNHP2sdtEpZwimiLWdOi/4sWG8FSi0ZnFavKhuu98hKGt0Fhi VxTNjM1ZIu29g== From: Sasha Levin To: stable@vger.kernel.org Cc: Shuvam Pandey , Andy Shevchenko , Neel Natu , Dmitry Antipov , "Darrick J. Wong" , Kees Cook , Andrew Morton , Sasha Levin Subject: [PATCH 6.12.y 1/2] lib/tests: extend cmdline KUnit with next_arg() tests Date: Tue, 10 Nov 2026 22:13:40 -0500 Message-ID: <20261111031318.849711-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261107052511-failed-6.12-5d72266218b1@kernel.org> References: <20261107052511-failed-6.12-5d72266218b1@kernel.org> X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Shuvam Pandey [ Upstream commit dcc8a57815534e3844f342b28ecfb6e626a816a0 ] The cmdline KUnit suite covers get_option() and get_options(), but it does not exercise next_arg(). Extend the suite with one test for a quoted value containing spaces and one regression test for a bare quote token after a normal parameter. The regression test covers the bare quote token path fixed by commit 9847f21225c4 ("lib/cmdline: avoid page fault in next_arg"). [shuvampandey1@gmail.com: extend cmdline next_arg() coverage with mixed tokens] Link: https://lore.kernel.org/20260316211249.88601-1-shuvampandey1@gmail.com Link: https://lore.kernel.org/20260316101227.15807-1-shuvampandey1@gmail.com Signed-off-by: Shuvam Pandey Reviewed-by: Andy Shevchenko Cc: Neel Natu Cc: Dmitry Antipov Cc: "Darrick J. Wong" Cc: Kees Cook Signed-off-by: Andrew Morton Stable-dep-of: 5d72266218b1 ("lib/cmdline: fix get_options() count and overflow with large ranges") Signed-off-by: Sasha Levin --- lib/cmdline_kunit.c | 62 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) diff --git a/lib/cmdline_kunit.c b/lib/cmdline_kunit.c index c1602f797637b..af44ae9e92c3e 100644 --- a/lib/cmdline_kunit.c +++ b/lib/cmdline_kunit.c @@ -139,11 +139,73 @@ static void cmdline_test_range(struct kunit *test) } while (++i < ARRAY_SIZE(cmdline_test_range_strings)); } +static void cmdline_test_next_arg_quoted_value(struct kunit *test) +{ + char in[] = "foo=\"bar baz\" qux=1"; + char *next, *param, *val; + + next = next_arg(in, ¶m, &val); + KUNIT_EXPECT_STREQ(test, param, "foo"); + KUNIT_ASSERT_NOT_NULL(test, val); + KUNIT_EXPECT_STREQ(test, val, "bar baz"); + KUNIT_EXPECT_STREQ(test, next, "qux=1"); + + next = next_arg(next, ¶m, &val); + KUNIT_EXPECT_STREQ(test, param, "qux"); + KUNIT_ASSERT_NOT_NULL(test, val); + KUNIT_EXPECT_STREQ(test, val, "1"); + KUNIT_EXPECT_STREQ(test, next, ""); +} + +static void cmdline_test_next_arg_bare_quote_regression(struct kunit *test) +{ + char in[] = "foo=bar \""; + char *next, *param, *val; + + next = next_arg(in, ¶m, &val); + KUNIT_EXPECT_STREQ(test, param, "foo"); + KUNIT_ASSERT_NOT_NULL(test, val); + KUNIT_EXPECT_STREQ(test, val, "bar"); + KUNIT_EXPECT_STREQ(test, next, "\""); + + /* This hits the i == 0 quoted-token case fixed by 9847f21225c4. */ + next = next_arg(next, ¶m, &val); + KUNIT_EXPECT_STREQ(test, param, ""); + KUNIT_EXPECT_PTR_EQ(test, val, NULL); + KUNIT_EXPECT_STREQ(test, next, ""); +} + +static void cmdline_test_next_arg_mixed_tokens(struct kunit *test) +{ + char in[] = "bbb= jjj kkk=\"a=b\""; + char *next, *param, *val; + + next = next_arg(in, ¶m, &val); + KUNIT_EXPECT_STREQ(test, param, "bbb"); + KUNIT_ASSERT_NOT_NULL(test, val); + KUNIT_EXPECT_STREQ(test, val, ""); + KUNIT_EXPECT_STREQ(test, next, "jjj kkk=\"a=b\""); + + next = next_arg(next, ¶m, &val); + KUNIT_EXPECT_STREQ(test, param, "jjj"); + KUNIT_EXPECT_NULL(test, val); + KUNIT_EXPECT_STREQ(test, next, "kkk=\"a=b\""); + + next = next_arg(next, ¶m, &val); + KUNIT_EXPECT_STREQ(test, param, "kkk"); + KUNIT_ASSERT_NOT_NULL(test, val); + KUNIT_EXPECT_STREQ(test, val, "a=b"); + KUNIT_EXPECT_STREQ(test, next, ""); +} + static struct kunit_case cmdline_test_cases[] = { KUNIT_CASE(cmdline_test_noint), KUNIT_CASE(cmdline_test_lead_int), KUNIT_CASE(cmdline_test_tail_int), KUNIT_CASE(cmdline_test_range), + KUNIT_CASE(cmdline_test_next_arg_quoted_value), + KUNIT_CASE(cmdline_test_next_arg_bare_quote_regression), + KUNIT_CASE(cmdline_test_next_arg_mixed_tokens), {} }; -- 2.53.0