From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794414191; b=iJ5al2ItPdBlnF8yAnt2n6WLTCjv5Gh9jz3Ha3HgyrxGaZ5bi6dM4iev2KBAmZ3HLxTD X9ct2SYn+BVHkD1Zo68rJ159s/YJJ0KoeVVSih9pGdIVgAr8PR0SnSmICrgypqLsm+fhB V9tmL38uDz20bWe/+UF4GVjwKPEJ3joYt52cVM64OYv19SUhNXkBKZMP3FznZ8wJEbN2l ZBwLza43tEQ1sEAr+ZB8iOM5mpYPbZFxDAKthe7cSNZoV67GsvL1vgolQI6pKsBqxgBDa FjACGZxYtaQAfcYxF2+wuapEtV7XEQ86wdjrnoADEH9X3QdPz4lHFZiurdonvsH9ZRg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794414191; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=wfFArA7J0wRCJThF/QSgbMG8+awFvlF9gfpVXcEasLs=; b=L0kklJP33pSOyeuYEawLUHnlykmoW5LLwN9mTGKF/otUeH/LcuTM3D1K5NyxZkg2MRy6 +WS40q6IfTcvP/1KXA/hry1Jku9vPpi0P4YXicKNI5vs5o41cRkdrw4nU4F1HfOoYWZQr UdeYlccztAzrzSBDQZT8nkNYlbdAbN+Zkry+x6PPd7tMrZU0RY82PTEbe3jbifZ4iN7Of uCIkB+buZTmPwVIHrZD7IfwqdLs+kQMkPaG3VqFe/vTD5gWO+tlHurpXfAOQ7raP6Hp27 EwHGVlznWTiwGbEXsyvo8BCaVCfp8nCmrn9pZW2gi6K3HFeB+OxjedjIhhKNljeVi0A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=BJkmTCQp; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1053D606A321 for ; Wed, 11 Nov 2026 16:23:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=BJkmTCQp Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2C661F00A07; Wed, 11 Nov 2026 16:23:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794414190; bh=wfFArA7J0wRCJThF/QSgbMG8+awFvlF9gfpVXcEasLs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=BJkmTCQpMwmO7qUM/usQ4zYLixhgijxoJoxwyH3MGrYd+pIo6/pLIUnr1bRVrNQSc +cLtIO8KhYwgLX3LF9v9dblO7xUCO4UnuQIcev6YIJe5kOzzvgEHusZYAQo01lHPFb 7zT1Jiw9GXb52LjXVnKHKAddMmR5BixV26pF8Sc9KhOWm7XBMj+YmgJitD7fIQqval JkWJ8Xlfi9UILQAorwbAOIbVBBaTwY3zi0DH6bsKNBYqV1VKUmHNj6ofHWYNvQ+QvV W7hJLxRfJjVWCfLjlhKMxCAySz6Yis6y57afURK6IPU+tvKtk3np5KEx8C0gGy56/0 DOG0AHpUmz+kg== From: Sasha Levin To: stable@vger.kernel.org Cc: Eric Dumazet , syzbot , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10.y 2/4] ip6mr: fix use-after-free in ip6mr_sk_done() Date: Wed, 11 Nov 2026 11:23:05 -0500 Message-ID: <20261111162230.3239471-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261111162230.3239471-1-sashal@kernel.org> References: <20261107062657-failed-5.10-6ace56ed7b13@kernel.org> <20261111162230.3239471-1-sashal@kernel.org> X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Eric Dumazet [ Upstream commit 7d9b1b578d67a14ae7a7a526ee115b233fa264c4 ] Apparently addrconf_exit_net() is called before igmp6_net_exit() and ndisc_net_exit() at netns dismantle time: net_namespace: call ip6table_mangle_net_exit() net_namespace: call ip6_tables_net_exit() net_namespace: call ipv6_sysctl_net_exit() net_namespace: call ioam6_net_exit() net_namespace: call seg6_net_exit() net_namespace: call ping_v6_proc_exit_net() net_namespace: call tcpv6_net_exit() ip6mr_sk_done sk=ffffa354c78a74c0 net_namespace: call ipv6_frags_exit_net() net_namespace: call addrconf_exit_net() net_namespace: call ip6addrlbl_net_exit() net_namespace: call ip6_flowlabel_net_exit() net_namespace: call ip6_route_net_exit_late() net_namespace: call fib6_rules_net_exit() net_namespace: call xfrm6_net_exit() net_namespace: call fib6_net_exit() net_namespace: call ip6_route_net_exit() net_namespace: call ipv6_inetpeer_exit() net_namespace: call if6_proc_net_exit() net_namespace: call ipv6_proc_exit_net() net_namespace: call udplite6_proc_exit_net() net_namespace: call raw6_exit_net() net_namespace: call igmp6_net_exit() ip6mr_sk_done sk=ffffa35472b2a180 ip6mr_sk_done sk=ffffa354c78a7980 net_namespace: call ndisc_net_exit() ip6mr_sk_done sk=ffffa35472b2ab00 net_namespace: call ip6mr_net_exit() net_namespace: call inet6_net_exit() This was fine because ip6mr_sk_done() would not reach the point decreasing net->ipv6.devconf_all->mc_forwarding until my patch in ip6mr_sk_done(). To fix this without changing struct pernet_operations ordering, we can clear net->ipv6.devconf_dflt and net->ipv6.devconf_all when they are freed from addrconf_exit_net() BUG: KASAN: use-after-free in instrument_atomic_read include/linux/instrumented.h:71 [inline] BUG: KASAN: use-after-free in atomic_read include/linux/atomic/atomic-instrumented.h:27 [inline] BUG: KASAN: use-after-free in ip6mr_sk_done+0x11b/0x410 net/ipv6/ip6mr.c:1578 Read of size 4 at addr ffff88801ff08688 by task kworker/u4:4/963 CPU: 0 PID: 963 Comm: kworker/u4:4 Not tainted 5.17.0-rc2-syzkaller-00650-g5a8fb33e5305 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: netns cleanup_net Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 print_address_description.constprop.0.cold+0x8d/0x336 mm/kasan/report.c:255 __kasan_report mm/kasan/report.c:442 [inline] kasan_report.cold+0x83/0xdf mm/kasan/report.c:459 check_region_inline mm/kasan/generic.c:183 [inline] kasan_check_range+0x13d/0x180 mm/kasan/generic.c:189 instrument_atomic_read include/linux/instrumented.h:71 [inline] atomic_read include/linux/atomic/atomic-instrumented.h:27 [inline] ip6mr_sk_done+0x11b/0x410 net/ipv6/ip6mr.c:1578 rawv6_close+0x58/0x80 net/ipv6/raw.c:1201 inet_release+0x12e/0x280 net/ipv4/af_inet.c:428 inet6_release+0x4c/0x70 net/ipv6/af_inet6.c:478 __sock_release net/socket.c:650 [inline] sock_release+0x87/0x1b0 net/socket.c:678 inet_ctl_sock_destroy include/net/inet_common.h:65 [inline] igmp6_net_exit+0x6b/0x170 net/ipv6/mcast.c:3173 ops_exit_list+0xb0/0x170 net/core/net_namespace.c:168 cleanup_net+0x4ea/0xb00 net/core/net_namespace.c:600 process_one_work+0x9ac/0x1650 kernel/workqueue.c:2307 worker_thread+0x657/0x1110 kernel/workqueue.c:2454 kthread+0x2e9/0x3a0 kernel/kthread.c:377 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 Fixes: f2f2325ec799 ("ip6mr: ip6mr_sk_done() can exit early in common cases") Signed-off-by: Eric Dumazet Reported-by: syzbot Signed-off-by: David S. Miller Stable-dep-of: 6ace56ed7b13 ("ipv6: remove ifaddr from hash during ifdown list cleanup") Signed-off-by: Sasha Levin --- net/ipv6/addrconf.c | 2 ++ net/ipv6/ip6mr.c | 8 +++++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 0e45127b14cdd..8daa9f564eec7 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -7188,7 +7188,9 @@ static void __net_exit addrconf_exit_net(struct net *net) NETCONFA_IFINDEX_ALL); #endif kfree(net->ipv6.devconf_dflt); + net->ipv6.devconf_dflt = NULL; kfree(net->ipv6.devconf_all); + net->ipv6.devconf_all = NULL; } static struct pernet_operations addrconf_ops = { diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c index bcb2f8513d847..0de23d06e3aee 100644 --- a/net/ipv6/ip6mr.c +++ b/net/ipv6/ip6mr.c @@ -1573,15 +1573,17 @@ static int ip6mr_sk_init(struct mr_table *mrt, struct sock *sk) int ip6mr_sk_done(struct sock *sk) { - int err = -EACCES; struct net *net = sock_net(sk); + struct ipv6_devconf *devconf; struct mr_table *mrt; + int err = -EACCES; if (sk->sk_type != SOCK_RAW || inet_sk(sk)->inet_num != IPPROTO_ICMPV6) return err; - if (!atomic_read(&net->ipv6.devconf_all->mc_forwarding)) + devconf = net->ipv6.devconf_all; + if (!devconf || !atomic_read(&devconf->mc_forwarding)) return err; rtnl_lock(); @@ -1593,7 +1595,7 @@ int ip6mr_sk_done(struct sock *sk) * so the RCU grace period before sk freeing * is guaranteed by sk_destruct() */ - atomic_dec(&net->ipv6.devconf_all->mc_forwarding); + atomic_dec(&devconf->mc_forwarding); write_unlock_bh(&mrt_lock); inet6_netconf_notify_devconf(net, RTM_NEWNETCONF, NETCONFA_MC_FORWARDING, -- 2.53.0