From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794585468; b=oy+ytgORYT4ZWSR+savXgxhjOVms0SHZQKdnaDRZfGpBBg3f1pF4MplDGSwYrGTqhqaS MjM4BBzT0nn2HhYtqSeoGuLx4Ba1GaG10ce0SSZ9AS5ky9I0C0MY7UYNuZyD/wV8mB5WD coiq8fkyRnpwRbMKEhnIlRQME10NQbaekrnt44eOvx9YFv7prqVhGQh16XBhcYV2OHcCA 6+ZufHe1k6wEK17eMrkJvUemsfno2AVWa7gafHan3zCI3/FmrT+/VYI0Kgxygyrv86G5R hI+s7Wi4Fs8zaWMDLVyzlNLtzK7rLDYu6C3CU4IZB8Xr5/psYOMZYMnO0uVq3tcuKhQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794585468; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=ffCvv6YAfccIvE12ipXvilJpEfsLNxc867wBBBsdmwk=; b=pmGoD5XHmXjPL8MjxnhjL8LlPYzPblP8vNPR2mvGGZo2kabx1eqkdeyqlCB6XgSx+jgo j5tBq4Ewy0QgdndPFcoTtv9dcMe0eKG5D1yuPNrlOViMIUcQqNLMP7lEiun50XTNot30V Mdcm7c+BwuUe4bVS21HbVWPAR1KmRHQDtiYfacByHEu69jnyUxMhu7ltt+9Q2/9wRJQvx mVmkpZndSHnj1fKR0lp0pLnRQ+FgK5PeuOlOWp4HE1HALPyWSUwDNetFfoBVD9Rjuhgjl JhUpR6ITRf1Mlt+HQxT+Qf8jEeXOLx3OZK9zZsV4Axp1Lla/luA6y0/50BZe9oF7WXw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=UVM4iJBY; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41A10606EB88; Fri, 13 Nov 2026 15:57:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=UVM4iJBY Received: by smtp.kernel.org (Postfix) with ESMTPSA id E12561F000C4; Fri, 13 Nov 2026 15:57:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794585468; bh=ffCvv6YAfccIvE12ipXvilJpEfsLNxc867wBBBsdmwk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=UVM4iJBYHzqsFDnHXFCzmlsWdjC7zA/R53FYWFV23xTagrMZrFmIYJVdWh8B9nhfd a/uyEE5KdKbDJDixDSScLvc7dafEsarstXt/cSqEEWO0dIRvS0owHYPVR8RF33BLcC 4ZRthOy2gg91eEc7NGgWMV/hS2iQ28vSR0nFLgk0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Jouni=20H=C3=B6gander?= , Mika Kahola , Joonas Lahtinen , Sasha Levin Subject: [PATCH 7.3 123/507] drm/i915/psr: Dont clip plane state destination rectangle Date: Fri, 13 Nov 2026 10:47:07 -0500 Message-ID: <20261113153758.596581957@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261113153753.358973689@linuxfoundation.org> References: <20261113153753.358973689@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jouni Högander [ Upstream commit e30830d21860fbf030ad162c3db4d1219477dfb5 ] clip_area_update() uses drm_rect_intersect which modifies passed r1 rectangle. Early transport alignment passes the cursor uapi.dst rectangle to clip_area_update, so the cursor uapi.dst is unintentionally modified by drm_rect_intersect. Fix this by using local copy in clip_area_update(). Also make the damage and the display area const. Fixes: 1bff93b8bc27 ("drm/i915/psr: Extend SU area to cover cursor fully if needed") Cc: # v6.9+ Assisted-by: GitHub-Copilot:claude-opus-5 Signed-off-by: Jouni Högander Reviewed-by: Mika Kahola Link: https://patch.msgid.link/20260929094434.77129-9-jouni.hogander@intel.com (cherry picked from commit 8621f3bcea6b0a790a954ddf2e6514c20a24ac1a) Signed-off-by: Joonas Lahtinen Signed-off-by: Sasha Levin --- drivers/gpu/drm/i915/display/intel_psr.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c index 1a9706d43b625..7aaf5b4d35035 100644 --- a/drivers/gpu/drm/i915/display/intel_psr.c +++ b/drivers/gpu/drm/i915/display/intel_psr.c @@ -2702,23 +2702,25 @@ static u32 psr2_pipe_srcsz_early_tpt_calc(struct intel_crtc_state *crtc_state, } static void clip_area_update(struct drm_rect *overlap_damage_area, - struct drm_rect *damage_area, - struct drm_rect *display_area) + const struct drm_rect *damage_area, + const struct drm_rect *display_area) { - if (!drm_rect_intersect(damage_area, display_area)) + struct drm_rect inter = *damage_area; + + if (!drm_rect_intersect(&inter, display_area)) return; if (overlap_damage_area->y1 == -1) { - overlap_damage_area->y1 = damage_area->y1; - overlap_damage_area->y2 = damage_area->y2; + overlap_damage_area->y1 = inter.y1; + overlap_damage_area->y2 = inter.y2; return; } - if (damage_area->y1 < overlap_damage_area->y1) - overlap_damage_area->y1 = damage_area->y1; + if (inter.y1 < overlap_damage_area->y1) + overlap_damage_area->y1 = inter.y1; - if (damage_area->y2 > overlap_damage_area->y2) - overlap_damage_area->y2 = damage_area->y2; + if (inter.y2 > overlap_damage_area->y2) + overlap_damage_area->y2 = inter.y2; } static bool intel_psr2_sel_fetch_pipe_alignment(struct intel_crtc_state *crtc_state) -- 2.53.0