From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794585526; b=cs03qd8DP2YHnA7wT/y7ac0xgVkaaeaoQmvwE7oAuwekqZSWVIAdscvac7LDa31SoOkB hIEb3vlQZu3sWGxt4vg4ZsZJJ2srKMakKTmC/QQy6AdCCQXR03SD2H8/hgyM3qT9Bvzno TFoqUVXt6jrQd2IZmQSRDtZSuVYF1bXRFjzABsLU792bOeXJ/wI/T8H9A/Veh/ibSnO+M Rz0rU+IxgdOt1/xA++zY8i25zr8wSr5HcDGKOaTXixDhhHl6O6dyArgid2w1TGwGSszua olOH6Fik+F7zhJG0Dce7FOVnHWaUX7n9ZDb+AKTrlF53GbrNGsaSbB4GnNSqsEfZpOA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794585526; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=66UONgxH9CZLkyGEd0Z2upVqRtApB05yRHQqXLHnbc4=; b=wAmYs4/AMHCs6hXF07asH7FuYBRRzBdoHvsHZRQ6HtbSm7RztgtT/QRHZclUFMlzoMS5 kXa6ZolCHnRiNNvrzRAjbOV+hA0Q14lY6kozKHmCOpsAgixa46hyYrpttd8gA63y2HPRE xgA4agmSeLgeor1a6jxrexF9OC79FKX0S4tEgSflVCbn0+zQ8psG7IFFdNWQt9x8iNjZW RIwSiMxwF/yupbVEVHGQfc8ygh9/U5JHBLAfSyR4CHhk5xKqtJn45kfeUVB+PlN7YJ1ie FKJUOMRGNE1j6rLv9vcS3qz9Js8ol4hwa1DZRI27HBZ/azLH07kBR1RdBXZLqRD+qww== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="r/sp44A0"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7658606A885; Fri, 13 Nov 2026 15:58:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=r/sp44A0 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92F461F000C6; Fri, 13 Nov 2026 15:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794585525; bh=66UONgxH9CZLkyGEd0Z2upVqRtApB05yRHQqXLHnbc4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=r/sp44A0/rJBmhHeCzcq+MsTaM0n8NWgtrPpT6aZ5wgLfe0wOGJ58UzKIEqKDg4lF c1q4cYkYetXDwkEZkzYh6gtWm0mUtJqNhW/2/f46eNxmSIrWPJqRZdeL8NXMqGXinN cEny2TXy3vDkYBiHUCOfkvI4HRGeVMwAbo1Eh+zM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ijae Kim , Myeonghun Pak , Guenter Roeck , Sasha Levin Subject: [PATCH 7.3 168/507] hwmon: (sht15) Stop deferred work before releasing its resources Date: Fri, 13 Nov 2026 10:47:52 -0500 Message-ID: <20261113153800.171568874@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261113153753.358973689@linuxfoundation.org> References: <20261113153753.358973689@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Myeonghun Pak [ Upstream commit 5eab1e7f7ed12893f3864fe46ffcd5a41a752d6a ] The IRQ handler and regulator notifier can leave work pending after a measurement or notification completes. Neither work item is drained before its resources are released on removal or probe failure. Disable read_work before freeing the IRQ, since the worker can re-enable it. Use request_irq()/free_irq() for explicit teardown. Unregister the regulator notifier before cancelling update_supply_work and disabling the regulator. Apply the same ordering to probe failures. Fixes: 251eb40f5ccd ("hwmon: sht15 humidity sensor driver") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Link: https://patch.msgid.link/20261024014044.27853-1-mhun512@gmail.com [groeck: Dropped obsolete 'Assisted-by: tag] Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/sht15.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/hwmon/sht15.c b/drivers/hwmon/sht15.c index 7bb2105d1ae22..48d93c61345c1 100644 --- a/drivers/hwmon/sht15.c +++ b/drivers/hwmon/sht15.c @@ -31,6 +31,7 @@ #include #include #include +#include /* Commands */ #define SHT15_MEASURE_TEMP 0x03 @@ -976,25 +977,22 @@ static int sht15_probe(struct platform_device *pdev) goto err_release_reg; } - ret = devm_request_irq(&pdev->dev, gpiod_to_irq(data->data), - sht15_interrupt_fired, - IRQF_TRIGGER_FALLING, - "sht15 data", - data); + ret = request_irq(gpiod_to_irq(data->data), sht15_interrupt_fired, + IRQF_TRIGGER_FALLING, "sht15 data", data); if (ret) goto err_release_reg; disable_irq_nosync(gpiod_to_irq(data->data)); ret = sht15_connection_reset(data); if (ret) - goto err_release_reg; + goto err_free_irq; ret = sht15_soft_reset(data); if (ret) - goto err_release_reg; + goto err_free_irq; ret = sysfs_create_group(&pdev->dev.kobj, &sht15_attr_group); if (ret) { dev_err(&pdev->dev, "sysfs create failed\n"); - goto err_release_reg; + goto err_free_irq; } data->hwmon_dev = hwmon_device_register(data->dev); @@ -1007,9 +1005,13 @@ static int sht15_probe(struct platform_device *pdev) err_release_sysfs_group: sysfs_remove_group(&pdev->dev.kobj, &sht15_attr_group); +err_free_irq: + disable_work_sync(&data->read_work); + free_irq(gpiod_to_irq(data->data), data); err_release_reg: if (!IS_ERR(data->reg)) { regulator_unregister_notifier(data->reg, &data->nb); + cancel_work_sync(&data->update_supply_work); regulator_disable(data->reg); } return ret; @@ -1023,12 +1025,16 @@ static void sht15_remove(struct platform_device *pdev) hwmon_device_unregister(data->hwmon_dev); sysfs_remove_group(&pdev->dev.kobj, &sht15_attr_group); + disable_work_sync(&data->read_work); + free_irq(gpiod_to_irq(data->data), data); + ret = sht15_soft_reset(data); if (ret) dev_err(&pdev->dev, "Failed to reset device (%pe)\n", ERR_PTR(ret)); if (!IS_ERR(data->reg)) { regulator_unregister_notifier(data->reg, &data->nb); + cancel_work_sync(&data->update_supply_work); regulator_disable(data->reg); } } -- 2.53.0