From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795057278; b=dvxqqkG+ILfqtvMSxj6KlgeT9aD5BPeObl6aygTJFMlu2IuwTJefqE7RL/hhxLg7LS+I hOV/DR5bB94BbiGUm/+XuDZ0vXu8I/8ZaLA2jCt1E1C5fWkZrVA/afTXmBjh/mzGTlYa2 QqcEL0eHksx4qLlpWcD3wpUcotqiWdlXyX7N4dTzCXBQ63zOj9mnkMendHcz0npTaOwGm fclBlpy/ZPE6AVQfP5Lo0psCq21i1cFL/ZClzP5kEDQnLksMG/b40Hho2D5e5RMYNxE4d HD2nMbTBaHi12KP6QzDtC/Gn/B3y0YmLQuB2hpRJhLBXsrzLkj1mfqV6nSSwHo6wGOg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795057278; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=AD/w+3JVCmQdRnRoMcYadDZOw+35O7vvr52zLnsPPLQ=; b=SF7RgoabpyQAMwHvipNjYP/TPH9u7HqSZ2bgUssSPMOtJlNJJNwAxsqHYrIv6BK1VcIa Bg6yfCSM7Mm9P8SKCwZZFSE74U4NWJ9135f9Bmicgk9uolphHty9upv/mbHASYDPXqFp7 yh9IAeZf61PhvYnWNDdR2R6Ph3oDpIOnU7VZf8ssQcDdISGkbauMUVcdztysTto52hImc Jb3IcJ5Q/81zD0TSQ2iF5XEUlPTfChYh+JnoR2+jVUCdFfet8uP7fL6YbkKIzkejWIg0d 3tNMAI6OlXh44agipZFFH91D0UbFNA0PEmTAm7xx0cWfco2TqxZXRXqRgjr0Sdr9xYg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Unrch8FO; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9779260A2609; Thu, 19 Nov 2026 03:01:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Unrch8FO Received: by smtp.kernel.org (Postfix) with ESMTPSA id E67081F000C8; Thu, 19 Nov 2026 03:01:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795057278; bh=AD/w+3JVCmQdRnRoMcYadDZOw+35O7vvr52zLnsPPLQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Unrch8FOYHC9tTkGvx9JXhRU6x8oeDkMiXcnG4i/a7pUgWCuF6H17+8dXGc6S/weg qkgcf6ABJaY5hJI2aoO/kLmduAw5GZ+TGKryhaoT9vClUPj3Trf2JauIz3zqZfonuC GTVw1Hq5r9STuVfcmrNosXwkOWKTywsNVA8CuJbo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shivaprasad G Bhat , Kyle Mahlkuch , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.10 0074/1848] scsi: qla2xxx: Handle INTx not connected while passing through Date: Wed, 18 Nov 2026 15:35:12 +0100 Message-ID: <20261118145914.249885916@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shivaprasad G Bhat [ Upstream commit 7268e509b43ac1734e1bdb7d18553f7e1080dfb4 ] The PCI_INTERRUPT_PIN reports if the device supports the INTx. However, when the device is assigned to a guest via vfio, the PCI_INTERRUPT_PIN is set to 0 (i.e none) if the line is not connected and/or the platform cannot route the interrupt. In such cases, the guest PCI_INTERRUPT_PIN is 0 and the port number becomes -1 (255, uint8_t underflow) for qla[25|27|28]xx and qla2031 devices. The flt_region_nvram is never set, and subsequently the LUN detection fails. Below warnings show the NVRAM configuration failure: []-0073:1: Inconsistent NVRAM checksum=0xffffffc0 id=HCAM version=0x100. []-0074:1: Falling back to functioning (yet invalid -- WWPN) defaults. []-0076:1: NVRAM configuration failed. Handle this case and set the port_no to devfn like its done everywhere else. Reference: commit 2bd42b03ab6b ("vfio/pci: Virtualize zero INTx PIN if no pdev->irq") Signed-off-by: Shivaprasad G Bhat Reviewed-by: Kyle Mahlkuch Link: https://patch.msgid.link/177885270578.1573.14283751510936407585.stgit@linux.ibm.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_os.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index eacf6e234e34b..1202b3d1782e4 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -2680,11 +2680,16 @@ qla2x00_set_isp_flags(struct qla_hw_data *ha) else { /* Get adapter physical port no from interrupt pin register. */ pci_read_config_byte(ha->pdev, PCI_INTERRUPT_PIN, &ha->port_no); - if (IS_QLA25XX(ha) || IS_QLA2031(ha) || - IS_QLA27XX(ha) || IS_QLA28XX(ha)) - ha->port_no--; - else - ha->port_no = !(ha->port_no & 1); + if (ha->port_no == 0) { + /* None of INT[A|B|C|D] may be virtualized by vfio */ + ha->port_no = PCI_FUNC(ha->pdev->devfn); + } else { + if (IS_QLA25XX(ha) || IS_QLA2031(ha) || + IS_QLA27XX(ha) || IS_QLA28XX(ha)) + ha->port_no--; + else + ha->port_no = !(ha->port_no & 1); + } } ql_dbg_pci(ql_dbg_init, ha->pdev, 0x000b, -- 2.53.0