From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795057638; b=oZtqBmOPnWSIJlz+E4N3U3fH8ylCTmPDVEeyd0u6pWu0uYcmIDZwx3nfuKTAebpcH3W9 niZiswSnCdMoYHz5JR+rIFc0ALJ/VuXwlsQ+kbjuouT801Ihy1VD3+L+ZcQxAEWQEix+N NFQqWTWRQxrrekXtZFOVJWET26w9Aja2xUbqdp1jVEgZ6Bp7J6LfAqfw9FqyJjJPxUGFQ ZzqAwmRkj5Fmdeuz9MMNG8yR8g20K9XtuoUxybbD1DPfve70iQj3usvn6Evjhb1pZPqtD DaCMd/AtFR9xxrh3uaQEwd8r8ZCK9Jv8FQOeKJ5PrCbI7S6xQKFxRGS/FNS7CE+7w9A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795057638; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=LHHTlBYSbRscTjLN4XF7OpUQiquYJ5PW0ab2sVBn2hU=; b=P7lhoKMr+oFyhejBw2AFYSzfqb8nt8KTVb/bMBqFmuzYu6tslT3ROgLDqvQznm0c/zT7 DjeAOuwtdU8Owwp4VUwxI0iGpc4K8mqz5YpmcCHDN2F1kCSVZ6PLCbmxFxgiRM5bnRlGO NYfi10hnhGkOBTRWkc3dV3RiEcbvOe6wOa/WtPsj9ZGCH7ZfVRTj4bj8dkS6g8CzkirW+ V/IQMly9ZdvzGmI/LSX7E81uIxHVoeVsb1wGrH88pFiviEuvUZqAG1AJTA3rKRKOoe8pj JmCyTyTh+sKUFr6sbI6S5w2Huttrb/8BAo/teHyzWjSdOY85nWT/rbVsb7+MoCkoblw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=BpwysPS9; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0D4C606A337; Thu, 19 Nov 2026 03:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=BpwysPS9 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53E8F1F000C4; Thu, 19 Nov 2026 03:07:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795057637; bh=LHHTlBYSbRscTjLN4XF7OpUQiquYJ5PW0ab2sVBn2hU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=BpwysPS9CMfsIo8/unAroq75kLYnwav45w7kWAaKTO9NlCty9YiVMspy32ZJfjtcD BV+Fkuem3azE3vBT281JLr74an4piWtu2R/atg8B1jMNZ5F/9lm2lmOS27Xfn3Kt1w PPPbt/dweETjK9vaCSUSW1fg+tQomcJb0moaFeYM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tarun Noonemunthala , Takashi Iwai , Sasha Levin Subject: [PATCH 5.10 0201/1848] ALSA: hda/realtek: Add quirk for HP ENVY 13-aq1xxx Date: Wed, 18 Nov 2026 15:37:19 +0100 Message-ID: <20261118145920.266614621@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tarun Noonemunthala [ Upstream commit a01a223bd685be42e908d970de32eeb3646097f3 ] The HP ENVY Laptop 13-aq1xxx (PCI SSID 103c:86ad) uses an ALC285 codec with two speaker pairs: front (pin 0x14) and bottom (pin 0x17). The BIOS leaves pin 0x14 as [N/A] ("not connected"), so the generic parser never enables the front pair and only the bottom speakers are audible. The vendor driver (RTKVHD64.sys) programs that pin with the value 0x90170150 and runs the HP amplifier initialization, which is already implemented in the driver as ALC285_FIXUP_HP_GPIO_AMP_INIT. Add a board fixup that applies the pin configuration for 0x14 and chains to the existing amplifier init fixup. The pin value was recovered from the vendor driver's own configuration data. The patch and this changelog were prepared with an AI coding assistant (see the Assisted-by tag below); the change was reviewed and tested by the submitter on the affected machine. Tested on an HP ENVY 13-aq1xxx by rebuilding snd-hda-codec-alc269 from the Fedora 7.1.10 source and loading it: the codec now reports "line_outs=2 (0x14/0x17)", pin 0x14 comes up as an output (Pin-ctls 0x40) with its amplifier unmuted, and both speaker pairs play. Assisted-by: OpenCode:deepseek-v4.1-flash checkpatch Signed-off-by: Tarun Noonemunthala Link: https://patch.msgid.link/20260923094014.58867-1-ntarun2000@gmail.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/pci/hda/patch_realtek.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 52a4433686313..2cc9d961b96be 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7022,6 +7022,7 @@ enum { ALC285_FIXUP_HP_SPECTRE_X360_EB1, ALC285_FIXUP_HP_SPECTRE_X360_DF1, ALC285_FIXUP_HP_ENVY_X360, + ALC285_FIXUP_HP_ENVY_13AQ, ALC288_FIXUP_DELL_HEADSET_MODE, ALC288_FIXUP_DELL1_MIC_NO_PRESENCE, ALC288_FIXUP_DELL_XPS_13, @@ -8865,6 +8866,15 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC285_FIXUP_HP_GPIO_AMP_INIT, }, + [ALC285_FIXUP_HP_ENVY_13AQ] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x14, 0x90170150 }, /* front speakers */ + { } + }, + .chained = true, + .chain_id = ALC285_FIXUP_HP_GPIO_AMP_INIT, + }, [ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP] = { .type = HDA_FIXUP_FUNC, .v.func = alc285_fixup_ideapad_s740_coef, @@ -9266,6 +9276,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x861f, "HP Elite Dragonfly G1", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x864f, "HP Laptop 15-dy0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2), SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED), + SND_PCI_QUIRK(0x103c, 0x86ad, "HP ENVY 13-aq1xxx", ALC285_FIXUP_HP_ENVY_13AQ), SND_PCI_QUIRK(0x103c, 0x86c1, "HP Laptop 15-da3001TU", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2), SND_PCI_QUIRK(0x103c, 0x86c7, "HP Envy AiO 32", ALC274_FIXUP_HP_ENVY_GPIO), SND_PCI_QUIRK(0x103c, 0x86c8, "HP Laptop 14s-dr1xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2), -- 2.53.0