From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795057978; b=J5laytsx4mdjYW87CKj4imIEcqfImimZnPi+H9wTYXPOFKw2J54dxo4xTRISL2hJ4mEH ZYL6Hn3MKtHe0zO8OlOkszUh9Hl9QS8A+FlUb2zZalSWdXah6p8r+tlH9qUFtDgBWhzip agULEN+2I69+3bZf734V6QAFmEqSyugSVGpDNpMHUOswLPkLGQP8t6XwbQeniEx7rRH5B LijcQGiuVe9hH4w5njWM37br7H2zKIdG4q01+HmRUPR78ImkVxWMuW3+lSiMOkz/1KW1m 4bsL95cFoYBFGYixjr+cBmad07+NylXux+Vm7j9mUiIYEfMka/lRa30yEBR7B+nQBig== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795057978; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=D7mcsbLPqeuwhSAfa3mkP0Q31aUVvch1u8fkeZ+0sM0=; b=cvTybwU1pYRL7Xj200xKSBQaXUe+82YfsK4czZntXMivay23bXGOiRVW5bHOjNe2PAym 9UiPxHdEQlO005K2aJN7Fd6ZkvxWAeMmoHmt7kg47CICaHzvO/AFLRXrJk/OoRVcHV9Yp WJCB/JPhgwE/HHU+BqdZkZXRIPiTxDyki1nDrUi94a+Qcoq5wTdlrF4FyMhjxubiv25aP 4x+C6V137RmpWssvKOXlj4kzJMbNjrsjigowdS6+FRy89Q0ixJEJYFfhZ6Wb7URNVr0zY YtzOAA1iWhqFmlOmmAeYL/5x175EpyQzpK0SYsyFtSkeFzRtFMf57556Wh0iK4Xcw4A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="rX08/GAD"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80D0B606A32A; Thu, 19 Nov 2026 03:12:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=rX08/GAD Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DB331F000C4; Thu, 19 Nov 2026 03:12:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795057978; bh=D7mcsbLPqeuwhSAfa3mkP0Q31aUVvch1u8fkeZ+0sM0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=rX08/GAD/XgrhlwcYm8K9P9QmMM/5sadAwZeuF0OPfppGnzRveIGMRVSIUAlC7xvh A1c/pjAGQumQbdPs2WwZ5zFHVzOtdVJlpaxGteJbps63T1Y0NJiOk5hfqllNVCR8du OpIW/P2kNPggwJaCWtDFRBXUyzSCEvsCZT2z9ZxA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fredric Cover , Paulo Alcantara , Sasha Levin Subject: [PATCH 5.10 0323/1848] smb: client: fix early procfs exposure race Date: Wed, 18 Nov 2026 15:39:21 +0100 Message-ID: <20261118145925.670639539@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fredric Cover [ Upstream commit 7b1afb631395c958993cda4631002258ef4151ea ] Currently, init_cifs() calls cifs_proc_init() near the beginning of the function, before INIT_LIST_HEAD, leading to a momentarily uninitialized, but exposed, procfs. If a userspace process reads this empty procfs, iterating over a zeroed list_head leads to a NULL pointer dereference and a kernel oops/panic. For example, if a delay is added between cifs_proc_init() and INIT_LIST_HEAD, and a userspace process is polling /proc/fs/cifs/DebugData, the following oops occurs: BUG: kernel NULL pointer dereference, address: 0000000000000608 Oops: Oops: 0000 [#1] SMP PTI CPU: 0 UID: 0 PID: 3477 Comm: cat Not tainted 7.3.0-02212-g4df4d2a577db-dirty #6 PREEMPT(lazy) RIP: 0010:cifs_debug_data_proc_show+0x103/0xd80 [cifs] Call Trace: ? seq_read_iter+0x86/0x400 ? seq_read_iter+0x86/0x400 seq_read_iter+0x183/0x400 proc_reg_read_iter+0x62/0x90 copy_splice_read+0x215/0x310 splice_file_to_pipe+0xec/0x1c0 do_splice+0x4b8/0x780 __se_sys_splice+0x18f/0x250 do_syscall_64+0x109/0x330 entry_SYSCALL_64_after_hwframe+0x77/0x7f Fix this by moving cifs_proc_init() down in init_cifs(), ensuring it runs only after all internal lists, locks, counters, and workqueues are fully ready, but before registering the filesystem. Update the error cleanup ladder and exit_cifs() to maintain proper LIFO order. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Fredric Cover Cc: stable@vger.kernel.org Signed-off-by: Paulo Alcantara [ sashal: Adjusted context to match the existing CIFS initialization and cleanup sequence. ] Signed-off-by: Sasha Levin --- fs/cifs/cifsfs.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c index 228087c90de25..e90792dd60e5d 100644 --- a/fs/cifs/cifsfs.c +++ b/fs/cifs/cifsfs.c @@ -1536,7 +1536,6 @@ static int __init init_cifs(void) { int rc = 0; - cifs_proc_init(); INIT_LIST_HEAD(&cifs_tcp_ses_list); #ifdef CONFIG_CIFS_DNOTIFY_EXPERIMENTAL /* unused temporarily */ INIT_LIST_HEAD(&GlobalDnotifyReqList); @@ -1582,10 +1581,8 @@ init_cifs(void) } cifsiod_wq = alloc_workqueue("cifsiod", WQ_FREEZABLE|WQ_MEM_RECLAIM, 0); - if (!cifsiod_wq) { - rc = -ENOMEM; - goto out_clean_proc; - } + if (!cifsiod_wq) + return -ENOMEM; /* * Consider in future setting limit!=0 maybe to min(num_of_cores - 1, 3) @@ -1646,19 +1643,22 @@ init_cifs(void) if (rc) goto out_register_key_type; + cifs_proc_init(); + rc = register_filesystem(&cifs_fs_type); if (rc) - goto out_init_cifs_idmap; + goto out_clean_proc; rc = register_filesystem(&smb3_fs_type); if (rc) { unregister_filesystem(&cifs_fs_type); - goto out_init_cifs_idmap; + goto out_clean_proc; } return 0; -out_init_cifs_idmap: +out_clean_proc: + cifs_proc_clean(); exit_cifs_idmap(); out_register_key_type: #ifdef CONFIG_CIFS_UPCALL @@ -1684,8 +1684,6 @@ init_cifs(void) destroy_workqueue(decrypt_wq); out_destroy_cifsiod_wq: destroy_workqueue(cifsiod_wq); -out_clean_proc: - cifs_proc_clean(); return rc; } @@ -1695,6 +1693,7 @@ exit_cifs(void) cifs_dbg(NOISY, "exit_smb3\n"); unregister_filesystem(&cifs_fs_type); unregister_filesystem(&smb3_fs_type); + cifs_proc_clean(); cifs_dfs_release_automount_timer(); exit_cifs_idmap(); #ifdef CONFIG_CIFS_UPCALL @@ -1711,7 +1710,6 @@ exit_cifs(void) destroy_workqueue(decrypt_wq); destroy_workqueue(fileinfo_put_wq); destroy_workqueue(cifsiod_wq); - cifs_proc_clean(); } MODULE_AUTHOR("Steve French"); -- 2.53.0