From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795058114; b=hwp5n78/e1eC1IrEjA6b/PsnJOPwmZ2tI0uPDdA7OJZ2layCOhVBz3OUOI9a40rWo5/X akusa7jjnundjBx/jCbcJVfs57lokU3K/MFetcn7IBab9Tl6K9AKxIXS9PVCnfdBS8yvQ JKZYHTPQkV440ZejSYJFFwvNOkQrcDzXskQnthNhvKkKdlasnBfS4WGzbIGhPdzEaQkyI 08MQzYi8zQRnyzDFfUhLSyab+LASTLDfR36f3o4N7YX1wc3NJucRt0nQjBnrVJ41hQpTT FvLPYtTHbwDPebWUZ1Vv6GzQFGdiDRkqxBQjaqY4UdpdemrkNSu7YUXQ7TYvdLHayMA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795058114; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=I80SSz7R3v2BdoADGnWXENTR42iflCPt20EZigTFl6E=; b=AfYWIGspvH99xHsYAdR7F6Xj+w9WBHnoY12DqBR1WuX9MsQc23+9clhSRMJENwW4iZgq 2mZkd/f60Xr6j2BfbwgJ3xynIa9/0kO/+nCH75qdzif0y605Q44BuLjsMjgdUwP1vqP2j jYPwWaS+lKlDFBGJYAaJr7IuiN2uEipYs/RUeDCLiV0lQ0pz/Kzzy3q6VcTPNDMsMfYZJ qSwfhzv5v+wYiyjC3l/nETKQLLZVmjMc5HbqN8RqABeVmA9vBxiYoSjFibgMtsloyLeex px4nTjf9VyyRqJpSpcfGX232rcMxd2P3N5dEvFKfF2reIJR8MVuJCWbPPPoVSQK3mnw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="Q9DBehF/"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9C6D606A325; Thu, 19 Nov 2026 03:15:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Q9DBehF/ Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E97E1F000C4; Thu, 19 Nov 2026 03:15:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795058113; bh=I80SSz7R3v2BdoADGnWXENTR42iflCPt20EZigTFl6E=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Q9DBehF/U+/kIp6SnLf5gtQEphJpCEcXrBbwRAB8nO4k0owqQ3VQnuQu8Tch3dMMw B5DJMV10hh/PgayYGxmsHUYVxHUDV9tgbp58DZT9rLG0KwPMrVs+TKYAdcebY4rOZJ QuipEAfWSiAT0yWF9xt4azfkLMM0N/B+V2QKfUWU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuhao Jiang , Junrui Luo , Hans Verkuil , Sasha Levin Subject: [PATCH 5.10 0370/1848] media: vicodec: fix out-of-bounds write on under-rounded coded dimensions Date: Wed, 18 Nov 2026 15:40:08 +0100 Message-ID: <20261118145928.896533995@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Junrui Luo [ Upstream commit 0183746ebca4c478027e2261b904f844f1443b19 ] A capture format whose width or height is one more than a multiple of 16 makes the FWHT codec write one 8x8 block row, or column, past the end of the capture plane, and read the same block out of the reference frame for P-coded frames. vic_round_dim() is documented to round a frame dimension up so that both the luma and the chroma plane end up a multiple of 8, but it only rounds the chroma plane: round_up((dim) / (div), 8) * (div) For div == 2 the result is a multiple of 16 in every case but one: when dim % 16 == 1, dim / div is already a multiple of 8 and the macro returns dim - 1. encode_plane() and decode_plane() round the same dimension with round_up(dim, 8), which yields dim + 7 -- one block more than the coded dimension that sized the buffer. On a KASAN-enabled kernel, a 641x360 YUYV P-frame triggers: BUG: KASAN: slab-out-of-bounds in add_deltas+0x450/0xcc0 Read of size 1 at addr ffff888009070800 by task trigger_bin/70 Call Trace: add_deltas+0x450/0xcc0 decode_plane+0x1916/0x3390 fwht_decode_frame+0x173/0x620 v4l2_fwht_decode+0x751/0x1120 device_run+0x6bb/0x1850 Round the dimension itself up to a multiple of 8 * div. The rounding changes only for div == 2 and dim % 16 == 1, and MAX_WIDTH and MAX_HEIGHT are both multiples of 16, so the rounded value still fits the advertised limits. Fixes: 3b15f68e19c2 ("media: vicodec: Add support for resolution change event.") Reported-by: Yuhao Jiang Assisted-by: Claude:claude-opus-5 Cc: stable@vger.kernel.org Signed-off-by: Junrui Luo Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/test-drivers/vicodec/codec-fwht.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/test-drivers/vicodec/codec-fwht.h b/drivers/media/test-drivers/vicodec/codec-fwht.h index b6fec2b1cbcaf..8d2e39e7abee9 100644 --- a/drivers/media/test-drivers/vicodec/codec-fwht.h +++ b/drivers/media/test-drivers/vicodec/codec-fwht.h @@ -93,7 +93,7 @@ * both luma and chroma components resolutions are rounded up to * a multiple of 8 */ -#define vic_round_dim(dim, div) (round_up((dim) / (div), 8) * (div)) +#define vic_round_dim(dim, div) round_up(dim, 8 * (div)) struct fwht_cframe_hdr { u32 magic1; -- 2.53.0