From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795058359; b=buCEe/IQXSGwpu3WHRRZHmLDL6XGi+6O6dkH4zi8zvvSlBhGP3TXgQLvzrjMI+y4FwPH MzXvBBQZcv6v4sMsC+IZxCszgVcnXzuil9kGoXYu9qzRswvyIQqFUNCVXbvZbC7uOIZ9R EXl8S/yY2vuIhH/V/yY+iv9S1KaGqBNc3u/E57ODJCo+QcF14fiNCR29FmBLqb3u2AScd 9z+d1VMHvbKX7YheTpQqfq0fv+pYcFdHtV8HMBp9EdIZ7iibWvEBVNN+XZskme5dAU4Wk TfeuVtOIwGoMznTHb7pHotAeeVmS8Wiu/N7y6plZt/m6mIjEgkzsUoOY+pPDsrYiOaw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795058359; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=AeeUOwE1wf6Bckf0VnSilr4aKt0raOh9N/FKzf3CVek=; b=t8pddJyXz0sVHLd3i6wrStxT2oF8/JMJdAFkEW0aDmsxV6geVaKSvJPQ+ZFMJBfXDVxL z06aCi/m9Htcw0+ouKx2QCQGRhmPfd78W8il9Us+E0dq6vrKa0TzfBmKGalCWoQ1b2BXV P2CHZL7l7YNigf19WCqXReYib/nDjYhYZrpZrp4ogNJNwEwN/YoLmd0f1zHh/NTiHJ1i/ UqQ3ZeLopgwIWZH/72NyVCOKxD0qs0J9Br/X7fV/PAo8On0/gattX4/t+QsoQMs2JWY9H IO7heAnEHN9XWTRRDG/g92w9aODYhmTCurCcursTgzMbuowEh10Sel0c8XXWpk7DlJA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=UwRB38wv; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A59BD606A32F; Thu, 19 Nov 2026 03:19:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=UwRB38wv Received: by smtp.kernel.org (Postfix) with ESMTPSA id F25421F000C4; Thu, 19 Nov 2026 03:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795058359; bh=AeeUOwE1wf6Bckf0VnSilr4aKt0raOh9N/FKzf3CVek=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=UwRB38wvBIIJt1rPT/XRcEzDt+K6CXZVL87c+6fkghSTkvZVoIZPfYNN/PX+sULj4 wuYBzXAR+KxjNPH83oAMI/jyglkqmUKq6xnSyWLlWtZiPNr9FQi36DAyVBAYKKcxHF sX9ax5/vpRLD46K9biTNouJk0mj5k6lCKelRdQ7M= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Imre Kaloz , Bjorn Helgaas , Andy Shevchenko , Sasha Levin Subject: [PATCH 5.10 0458/1848] PCI: Disable MSI for ULi M1575 EHCI controller Date: Wed, 18 Nov 2026 15:41:36 +0100 Message-ID: <20261118145933.633632335@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Imre Kaloz [ Upstream commit 5f30217ec296fb5742f6fd306586dbca5b81b4eb ] With MSI, the ULi M1575 EHCI controller (10b9:5239) intermittently stops executing its asynchronous schedule. Control transfers time out ("device not accepting address", "device descriptor read/64"), the port is handed to the companion OHCI controller, and the device ends up at full speed. On a configured hub the stall shows up as hub descriptor and status read failures. Only re-initializing the controller recovers it. On a Sun Ultra 45, 65 of 800 controller initializations stalled with MSI and none of 200 with INTx. Each initialization is an unbind and bind of ehci-pci on the EHCI function, with MSI or INTx selected through its msi_bus attribute; with this quirk, 0 of 100 cycles of the same loop stalled. The stall reproduces on a kernel that already contains commit 0b60557230ad ("usb: ehci: Prevent missed ehci interrupts with edge-triggered MSI"). The OHCI functions (10b9:5237) keep MSI. They showed no stall, and the hub enumerated through them on MSI during the EHCI failures, so only the EHCI function is quirked. The illumos EHCI driver also disables MSI on this chip, in ehci_register_intrs_and_init_mutex() in usr/src/uts/common/io/usb/hcd/ehci/ehci_util.c. Until USB HCDs started trying MSI first in v5.9, the controller always used INTx. Disable MSI so it uses INTx again on this chipset. Fixes: 306c54d0edb6 ("usb: hcd: Try MSI interrupts on PCI devices") Signed-off-by: Imre Kaloz Signed-off-by: Bjorn Helgaas Reviewed-by: Andy Shevchenko Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260930191100.6127-1-kaloz@kernel.org Signed-off-by: Sasha Levin --- drivers/pci/quirks.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index b3ea52038aec9..7e05cf575cfc7 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -1833,6 +1833,8 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4388, quirk_no_msi); DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4389, quirk_no_msi); DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x438a, quirk_no_msi); DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x438b, quirk_no_msi); +/* ULi M1575 EHCI (10b9:5239): MSI stalls the async schedule */ +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AL, 0x5239, quirk_no_msi); static void quirk_pcie_mch(struct pci_dev *pdev) { -- 2.53.0