From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795058409; b=5srOK61Ln6E3VQ2v+8QPJ6wGx2na59UgOAAG193aaoMxehssTpJDkIWHvgkasOKj/RRz WPToAi1ZJZzv8WfLu1XFJg4KO6ToQOZb0juRtp5f+hvLc1XhpaIkH8TiEKkoyzVUQpqxL su/TjRXNh9SfcY0xg9ju63RQ/79amqIK7AlMqoMIC17hkSETvxOu9zcxmRku8oaBMrTRS d310ex3EvpRUAk51ifM+9PxLUhcr3kwedD3Uc7PJ1B3Jmc8yJnRuPzqtOJifV86eN7l5U 9RXuasExlkQhoEgFl+4ovo/oy7+f6xRdeeomIbvjKL9uiTHAFb8h41SfmwtseAPoLoA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795058409; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=j0OpLbQ0puDMgo/f42gADHz+aZWEK5KgbzHdvlM1+ZA=; b=NXzVsL/ESjSmTfpthFt9s5QQCv4S6ufOc3IJ3/mof6suLrZJQFObBl9jS+1knNWk8Z+U UKy5NmFfyelZaAIpXTFVRA2+4HI2/BLXp+FjbfmfIxTB9cS6r87CHeSxcxYwJNvHl5KdX cCp8vQRhhE6SUDmFhAw4KQQz1AVFKLZAG4AmpmbhXBDHQTpIovnbGWSe7wQ9dDLGMRf+t S9A3schT4BV8XHOMqLYJUSXXg5kp9LkjjtQb6R7xQtbz+802sdyiblw49RWgKDHIA1HMh GCYgV5w6vwj1fLsRU/5mN61ttswTAZTIGrLIivffA1wwn2QM2RteMwhj7ooPlWgqU0g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=WanUIqcj; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9254C606A325; Thu, 19 Nov 2026 03:20:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=WanUIqcj Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED8D81F000C4; Thu, 19 Nov 2026 03:20:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795058409; bh=j0OpLbQ0puDMgo/f42gADHz+aZWEK5KgbzHdvlM1+ZA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=WanUIqcje7to557fK1dMzTEHcqMk/NhwcB/1jmMloVNlPbOVGsQQUnQ71a+1w6zx+ fMFC0WTHBgon/Cqt9jLXs7P8a8Dd5fCLu9rN2QPZO8ma6sv+W0HCf49DrHvJ5WwqPm 3rV8oXFh0bgT3utFDSNqtCDahh2kw1UC2otNkXOU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, DAI RENJIE , Andrew Morton , Bradley Morgan , Mark Brown , Kees Cook , Bjorn Helgaas , Sasha Levin Subject: [PATCH 5.10 0474/1848] resource: fix lost wakeup when waiting for a muxed region Date: Wed, 18 Nov 2026 15:41:52 +0100 Message-ID: <20261118145934.138249981@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: DAI RENJIE [ Upstream commit 405c00e43a9c72a0b9b318cc2d2e298386ffb58e ] A task waiting for a muxed region can sleep forever in TASK_UNINTERRUPTIBLE even though the region it waits for is already free. __request_region_locked() queues itself on muxed_resource_wait and drops resource_lock before setting TASK_UNINTERRUPTIBLE, while __release_region() wakes the queue after dropping the same lock. A wakeup landing in between finds TASK_RUNNING, does not match TASK_NORMAL and is discarded; callers hold a muxed region only across a bounded transaction, so no further release is coming. The task is unkillable and its caller never returns. The window is one store wide, but an interrupt is enough to hold the waiter in it, and the machine this was seen on runs PREEMPT_DYNAMIC in its voluntary default. Since v6.11 spd5118 exports the DDR5 sensors of AMD boards through i2c-piix4, which takes a muxed region per SMBus transaction; a third of the in-tree users of request_muxed_region() are hwmon drivers, so reading a world-readable attribute is all an unprivileged user needs to drive the contention. The blocked task sleeps holding the i2c adapter bus lock, and 27 more piled up behind it. Reproduced by building a kernel with the two orderings selectable at runtime and a 2ms delay inside the window. Switching only that knob, a two-thread barriered reproducer loses the wakeup 200 times out of 200 before the fix and 0 out of 200 after it; without the delay it goes 20000 times through the wait path and loses none. Fix it by setting the task state before dropping resource_lock, as prepare_to_wait() does: the releasing side needs resource_lock to unlink the resource, so it cannot reach the wakeup before the state is published. Link: https://lore.kernel.org/20260821-b4-resource-muxed-lost-wakeup-v1-1-37eb6473a76c@gmail.com Fixes: 8b6d043b7ee2 ("resource: shared I/O region support") Signed-off-by: DAI RENJIE Signed-off-by: Andrew Morton Reviewed-by: Bradley Morgan Reviewed-by: Andrew Morton Assisted-by: Claude:claude-opus-5 Cc: Mark Brown Cc: Kees Cook Cc: Bjorn Helgaas Cc: Signed-off-by: Sasha Levin --- kernel/resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/resource.c b/kernel/resource.c index 30abba56cc141..83fbc40dcbef2 100644 --- a/kernel/resource.c +++ b/kernel/resource.c @@ -1184,8 +1184,8 @@ struct resource * __request_region(struct resource *parent, } if (conflict->flags & flags & IORESOURCE_MUXED) { add_wait_queue(&muxed_resource_wait, &wait); - write_unlock(&resource_lock); set_current_state(TASK_UNINTERRUPTIBLE); + write_unlock(&resource_lock); schedule(); remove_wait_queue(&muxed_resource_wait, &wait); write_lock(&resource_lock); -- 2.53.0