From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795058753; b=GP2rIust1xuMOrKeJ3MNbkeySbU9qTcX/F+1Oo/utdY+hzkt/Gis5lwTjn7Y0Q+utTJF UCYdErxpDawkcpU/Tc9RWl0siezldeBwmFoe46cMRVgqocS4lOBjlnH+jGoOILyvvMgyS INibxK5Vt6JIy8+STA6z2OEGAgYh5x+/67FtFT/iCHgy3SicBGRTmvvMuy3puidbxGGtX vWcPx3PKMTmJ3M0Xr75klcKvclq153vlgWtIyaMJGA0bKThnbI0yDRgKg5yzVPthtpz91 IBrT4t9D0XnsslF4bexXpQh9+enYMhyAb6hffkLe3CODz6lEL4knCw+HrDIaowF7tzw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795058753; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=VQulxDqz4Ht28+LZ2jMNPdyPfkJa7Zvc9FGaSkMs3Pk=; b=dOX3crcQZtw58VjX3P8dE2bC+nxNPakDgV5N6/aCWpIlzfyyCraC9VfVP7rO4ivI6zSX /zhpbMVRb/RJPxV5wUfTT9vOi8Wez5Pv58wiMUIWZHAspWSKjvRRF38yTUjEhyffITZBe rr7JxOy/pLEeVOhMy27FQFXbKqzJfo3JZWEGpN25wn4m/b2npfa7jA8HIIshSpaWj98dj +/ihCGIuBq4NGBisQWjo9Ra2MMVT/M3ILnMFDfIl266Q5otQwsXOXzRE95SACfIbPMroJ ZIAvaK/pWf/BJvTthwBBs2vYPKXAwrqkIxSG6l0MKXK+2UcsAjzRSZjfaboGoAG3i2Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=mMSVTjxR; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D675606A31C; Thu, 19 Nov 2026 03:25:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=mMSVTjxR Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96E9D1F000C4; Thu, 19 Nov 2026 03:25:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795058753; bh=VQulxDqz4Ht28+LZ2jMNPdyPfkJa7Zvc9FGaSkMs3Pk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mMSVTjxRrTXHaIrwTPDS10s6pyCOaVlL21XrHRNXA0paZnFgU285weCfmOMhJaqM3 ls9r1wQenlQPy/sf9zEId6TQYmbqO47nUPlOKMuy29EnVqEs4wc4xGJBmxZPHhHNb5 U8Pyqvy7YxUjIrJU9+S/4AfAhs01VC3FOPQ5BMsc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, co+e015e82956da641b@bugs.sh, Christoph Hellwig , Weiming Shi , Keith Busch , Sasha Levin Subject: [PATCH 5.10 0598/1848] nvmet-rdma: reject short connection requests Date: Wed, 18 Nov 2026 15:43:56 +0100 Message-ID: <20261118145940.392569191@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Weiming Shi [ Upstream commit 635e760169a87abf03874cd4636cd91b580cb427 ] nvmet_rdma_parse_cm_connect_req() treats RDMA-CM private data as a struct nvme_rdma_cm_req but accepts any nonzero private_data_len. The iWARP path allocates exactly the peer-provided length, so a six-byte MPA request reaches the parser and the hsqsize load reads two bytes past the allocation. Require the complete request structure before reading any of its fields. The decoded KASAN report is: BUG: KASAN: slab-out-of-bounds in nvmet_rdma_cm_handler (drivers/nvme/target/rdma.c:1427 drivers/nvme/target/rdma.c:1475 drivers/nvme/target/rdma.c:1614 drivers/nvme/target/rdma.c:1814) Read of size 2 at addr ff1100010459d366 by task kworker/u16:1/41 Workqueue: iw_cm_wq cm_work_handler Call Trace: dump_stack_lvl (lib/dump_stack.c:94 lib/dump_stack.c:120) print_report (mm/kasan/report.c:378 mm/kasan/report.c:482) kasan_report (mm/kasan/report.c:595) nvmet_rdma_cm_handler (drivers/nvme/target/rdma.c:1427 drivers/nvme/target/rdma.c:1475 drivers/nvme/target/rdma.c:1614 drivers/nvme/target/rdma.c:1814) cma_cm_event_handler (drivers/infiniband/core/cma.c:2181) iw_conn_req_handler (drivers/infiniband/core/cma.c:2640) cm_work_handler (drivers/infiniband/core/cm.c:2502 drivers/infiniband/core/cm.c:3858) process_one_work (kernel/workqueue.c:3396) worker_thread (kernel/workqueue.c:3479 kernel/workqueue.c:3560) kthread (kernel/kthread.c:436) ret_from_fork (arch/x86/kernel/process.c:158) ret_from_fork_asm (arch/x86/entry/entry_64.S:245) Allocated by task 12: __kasan_kmalloc (mm/kasan/common.c:398 mm/kasan/common.c:415) __kmalloc_node_track_caller_noprof (mm/slub.c:5414 mm/slub.c:5545) kmemdup_noprof (mm/util.c:138) cm_event_handler (drivers/infiniband/core/iwcm.c:194 drivers/infiniband/core/iwcm.c:1076) siw_cm_upcall (drivers/infiniband/sw/siw/siw_cm.c:408) siw_proc_mpareq (drivers/infiniband/sw/siw/siw_cm.c:750) siw_cm_work_handler (drivers/infiniband/sw/siw/siw_cm.c:1086) The buggy address is located 0 bytes to the right of allocated 6-byte region [ff1100010459d360, ff1100010459d366) Cc: stable@vger.kernel.org Fixes: 8f000cac6e7a ("nvmet-rdma: add a NVMe over Fabrics RDMA target driver") Reported-by: Assisted-by: LLM Reviewed-by: Christoph Hellwig Signed-off-by: Weiming Shi Signed-off-by: Keith Busch Signed-off-by: Sasha Levin --- drivers/nvme/target/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c index 5ce6aa4103d89..521208929339a 100644 --- a/drivers/nvme/target/rdma.c +++ b/drivers/nvme/target/rdma.c @@ -1392,7 +1392,7 @@ nvmet_rdma_parse_cm_connect_req(struct rdma_conn_param *conn, struct nvme_rdma_cm_req *req; req = (struct nvme_rdma_cm_req *)conn->private_data; - if (!req || conn->private_data_len == 0) + if (!req || conn->private_data_len < sizeof(*req)) return NVME_RDMA_CM_INVALID_LEN; if (le16_to_cpu(req->recfmt) != NVME_RDMA_CM_FMT_1_0) -- 2.53.0